From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1gwwqB-0007k9-Tf for mharc-grub-devel@gnu.org; Thu, 21 Feb 2019 17:29:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56065) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwwq9-0007ix-O2 for grub-devel@gnu.org; Thu, 21 Feb 2019 17:29:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gwwq9-0005wz-1e for grub-devel@gnu.org; Thu, 21 Feb 2019 17:29:13 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:39702) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gwwq8-0005w7-Mc for grub-devel@gnu.org; Thu, 21 Feb 2019 17:29:12 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x1LMOj89023510; Thu, 21 Feb 2019 22:29:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=XWs0JJYfzhDgkq4d/auiiTIwwNuJMniPimwd6ICDyss=; b=X4AxcGTWHs0B+Te44AGiFbWQ4jHL743BzCC54aFuRsyWfpCzOttBYpOaeu3FM5dVgvIR UUyz+vqr4QFCbmEr+ggcI7LXeYKkxiGQZwHGv12HGFP1/6o2ZcpWuVfuhFH5sZo48Uiu ENDXJ/xwnlQvRBtllUcp+9IaWrhGDMLRBphCZkykeldWO7CzWpOfoDEiUaA799p2cpIF M3dcCnzY8JD7t0GlZAh8lM2wdZnI6QBJisGsp0JAQvkDhVJTuhRGc0kMNAwKrDaMj7QF a9SxyJUCLjBASPC3dqd3tJzivWKQtXyiZpzTtFiZhyppXnW5QNZZhG9K1HoyBWx6amH2 hg== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2120.oracle.com with ESMTP id 2qpb5ru4ew-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 21 Feb 2019 22:29:06 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x1LMT0d1002587 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 21 Feb 2019 22:29:00 GMT Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x1LMSx4A011916; Thu, 21 Feb 2019 22:28:59 GMT Received: from tomti.i.net-space.pl (/10.175.187.233) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 21 Feb 2019 14:28:58 -0800 Date: Thu, 21 Feb 2019 23:28:54 +0100 From: Daniel Kiper To: Andre Przywara Cc: Daniel Kiper , Vladimir Serbinenko , Andrei Borzenkov , Mark Rutland , grub-devel@gnu.org Subject: Re: [PATCH v2 9/9] net: dhcp: add explicit net_dhcp command Message-ID: <20190221222854.finren6p6ahgox23@tomti.i.net-space.pl> References: <20190212174700.184741-1-andre.przywara@arm.com> <20190212174700.184741-10-andre.przywara@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190212174700.184741-10-andre.przywara@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9174 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=829 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902210153 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 156.151.31.85 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Feb 2019 22:29:14 -0000 On Tue, Feb 12, 2019 at 05:47:00PM +0000, Andre Przywara wrote: > From: Andrei Borzenkov > > Mostly for cosmetic reasons, we add a "net_dhcp" command, which is > (at the moment) identical to the existing "net_bootp" command. Both > actually trigger a DHCP handshake now, and both should be able to deal > with pure BOOTP servers. > We could think about dropping the DHCP options from the initial DISCOVER > packet when the user issues the net_bootp command, but it's unclear > whether this is really useful, as both protocols should be able to > coexist. > > Signed-off-by: Andre Przywara Reviewed-by: Daniel Kiper Daniel