From: Cornelia Huck <cohuck@redhat.com>
To: "Jason J. Herne" <jjherne@linux.ibm.com>
Cc: qemu-devel@nongnu.org, qemu-s390x@nongnu.org,
pasic@linux.ibm.com, alifm@linux.ibm.com, borntraeger@de.ibm.com
Subject: Re: [Qemu-devel] [PATCH 10/15] s390-bios: Support for running format-0/1 channel programs
Date: Fri, 22 Feb 2019 09:35:59 +0100 [thread overview]
Message-ID: <20190222093559.5334886d.cohuck@redhat.com> (raw)
In-Reply-To: <397b094e-d140-d1c3-5ced-ca2d2e0e5d8e@linux.ibm.com>
On Thu, 21 Feb 2019 13:01:40 -0500
"Jason J. Herne" <jjherne@linux.ibm.com> wrote:
> On 2/4/19 6:24 AM, Cornelia Huck wrote:
> > On Tue, 29 Jan 2019 08:29:17 -0500
> > "Jason J. Herne" <jjherne@linux.ibm.com> wrote:
(...)
> >> -#define SCSW_FCTL_CLEAR_FUNC 0x1000
> >> -#define SCSW_FCTL_HALT_FUNC 0x2000
> >> +/* Function Control */
> >> #define SCSW_FCTL_START_FUNC 0x4000
> >> +#define SCSW_FCTL_HALT_FUNC 0x2000
> >> +#define SCSW_FCTL_CLEAR_FUNC 0x1000
> >> +
> >> +/* Activity Control */
> >> +#define SCSW_ACTL_RESUME_PEND 0x0800
> >> +#define SCSW_ACTL_START_PEND 0x0400
> >> +#define SCSW_ACTL_HALT_PEND 0x0200
> >> +#define SCSW_ACTL_CLEAR_PEND 0x0100
> >> +#define SCSW_ACTL_CH_ACTIVE 0x0080
> >> +#define SCSW_ACTL_DEV_ACTIVE 0x0040
> >> +#define SCSW_ACTL_SUSPENDED 0x0020
> >> +
> >> +/* Status Control */
> >> +#define SCSW_SCTL_ALERT 0x0010
> >> +#define SCSW_SCTL_INTERMED 0x0008
> >> +#define SCSW_SCTL_PRIMARY 0x0004
> >> +#define SCSW_SCTL_SECONDARY 0x0002
> >> +#define SCSW_SCTL_STATUS_PEND 0x0001
> >> +
> >> +/* SCSW Device Status Flags */
> >> +#define SCSW_DSTAT_ATTN 0x80
> >> +#define SCSW_DSTAT_STATMOD 0x40
> >> +#define SCSW_DSTAT_CUEND 0x20
> >> +#define SCSW_DSTAT_BUSY 0x10
> >> +#define SCSW_DSTAT_CHEND 0x08
> >> +#define SCSW_DSTAT_DEVEND 0x04
> >> +#define SCSW_DSTAT_UCHK 0x02
> >> +#define SCSW_DSTAT_UEXCP 0x01
> >> +
> >> +/* SCSW Subchannel Status Flags */
> >> +#define SCSW_CSTAT_PCINT 0x80
> >> +#define SCSW_CSTAT_BADLEN 0x40
> >> +#define SCSW_CSTAT_PROGCHK 0x20
> >> +#define SCSW_CSTAT_PROTCHK 0x10
> >> +#define SCSW_CSTAT_CHDCHK 0x08
> >> +#define SCSW_CSTAT_CHCCHK 0x04
> >> +#define SCSW_CSTAT_ICCHK 0x02
> >> +#define SCSW_CSTAT_CHAINCHK 0x01
> >
> > Any reason you're not following the Linux kernel definitions here?
> > Might make it easier for folks familiar with the kernel implementation.
> >
>
> There wasn't any real reason. I do like some of my names better as I feel that they all
> should start with SCSW_. But in the interest of homogenizing I could change to the kernel
> implementation. Let me know if you think its worth the time, I could go either way on it.
TBH, some of the kernel defines _are_ a bit wonky, but I'm used to
them :)
Not sure if any of the others who will look at this code are that
familiar with the kernel code, though, so I'll leave the decision to
the bios maintainers. (Your names are more consistent...)
(...)
> >> +io_new_code:
> >> + /* disable I/O interrupts in cr6 */
> >> + stctg 6,6,0(15)
> >> + ni 4(15), 0x00
> >> + lctlg 6,6,0(15)
> >
> > What about leaving the isc enabled in cr6 all the time and just
> > controlling interrupts via enabling/disabling I/O interrupts?
> >
>
> Its really all about leaving the system in as close to a default and unaltered state as
> possible. I could just set isc sometime at the beginning of dasd ipl and clear it right
> before transferring control, if you feel strongly about it.
Not feeling strongly. Nobody probably cares about how often you change
cr6 during load...
next prev parent reply other threads:[~2019-02-22 8:36 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 13:29 [Qemu-devel] [PATCH 00/15] s390: vfio-ccw dasd ipl support Jason J. Herne
2019-01-29 13:29 ` [Qemu-devel] [PATCH 01/15] s390 vfio-ccw: Add bootindex property and IPLB data Jason J. Herne
2019-01-30 16:56 ` Cornelia Huck
2019-01-30 20:12 ` Jason J. Herne
2019-01-30 22:21 ` Farhan Ali
2019-02-08 16:07 ` Jason J. Herne
2019-01-31 18:20 ` Cornelia Huck
2019-02-04 10:26 ` Cornelia Huck
2019-02-13 13:41 ` Jason J. Herne
2019-02-13 14:52 ` Cornelia Huck
2019-02-06 11:30 ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2019-02-08 16:04 ` Jason J. Herne
2019-02-11 8:15 ` Cornelia Huck
2019-02-11 8:39 ` Thomas Huth
2019-01-29 13:29 ` [Qemu-devel] [PATCH 02/15] s390-bios: decouple cio setup from virtio Jason J. Herne
2019-01-30 22:23 ` Farhan Ali
2019-02-04 10:28 ` Cornelia Huck
2019-02-05 9:55 ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2019-01-29 13:29 ` [Qemu-devel] [PATCH 03/15] s390-bios: decouple common boot logic " Jason J. Herne
2019-01-30 22:27 ` Farhan Ali
2019-02-04 10:31 ` Cornelia Huck
2019-01-29 13:29 ` [Qemu-devel] [PATCH 04/15] s390-bios: Extend find_dev() for non-virtio devices Jason J. Herne
2019-02-04 10:33 ` Cornelia Huck
2019-02-11 16:38 ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2019-02-13 13:59 ` Jason J. Herne
2019-03-04 19:23 ` Thomas Huth
2019-01-29 13:29 ` [Qemu-devel] [PATCH 05/15] s390-bios: Factor finding boot device out of virtio code path Jason J. Herne
2019-01-31 13:44 ` Farhan Ali
2019-02-04 10:45 ` Cornelia Huck
2019-02-11 17:57 ` Jason J. Herne
2019-02-12 9:32 ` Cornelia Huck
2019-01-29 13:29 ` [Qemu-devel] [PATCH 06/15] s390-bios: Clean up cio.h Jason J. Herne
2019-01-31 14:23 ` Farhan Ali
2019-02-04 10:48 ` Cornelia Huck
2019-02-12 12:32 ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2019-01-29 13:29 ` [Qemu-devel] [PATCH 07/15] s390-bios: Decouple channel i/o logic from virtio Jason J. Herne
2019-01-31 14:38 ` Farhan Ali
2019-01-31 14:45 ` Jason J. Herne
2019-02-04 10:57 ` Cornelia Huck
2019-02-13 14:40 ` Jason J. Herne
2019-01-29 13:29 ` [Qemu-devel] [PATCH 08/15] s390-bios: Map low core memory Jason J. Herne
2019-02-12 12:47 ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2019-02-18 15:40 ` Jason J. Herne
2019-02-18 15:49 ` Cornelia Huck
2019-02-18 16:52 ` Thomas Huth
2019-01-29 13:29 ` [Qemu-devel] [PATCH 09/15] s390-bios: ptr2u32 and u32toptr Jason J. Herne
2019-02-04 11:03 ` Cornelia Huck
2019-02-12 12:50 ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2019-01-29 13:29 ` [Qemu-devel] [PATCH 10/15] s390-bios: Support for running format-0/1 channel programs Jason J. Herne
2019-01-31 17:31 ` Farhan Ali
2019-02-04 11:13 ` Cornelia Huck
2019-02-04 19:29 ` Farhan Ali
2019-02-05 10:18 ` Cornelia Huck
2019-02-12 13:10 ` Halil Pasic
2019-02-27 13:35 ` Jason J. Herne
2019-02-27 14:07 ` Cornelia Huck
2019-02-27 13:32 ` Jason J. Herne
2019-02-27 14:06 ` Cornelia Huck
2019-02-04 11:24 ` Cornelia Huck
2019-02-21 18:01 ` Jason J. Herne
2019-02-22 8:35 ` Cornelia Huck [this message]
2019-01-29 13:29 ` [Qemu-devel] [PATCH 11/15] s390-bios: cio error handling Jason J. Herne
2019-02-04 11:41 ` Cornelia Huck
2019-02-28 15:59 ` Jason J. Herne
2019-02-28 16:11 ` Cornelia Huck
2019-01-29 13:29 ` [Qemu-devel] [PATCH 12/15] s390-bios: Refactor virtio to run channel programs via cio Jason J. Herne
2019-02-04 11:44 ` Cornelia Huck
2019-02-25 13:20 ` Jason J. Herne
2019-02-25 17:07 ` Cornelia Huck
2019-01-29 13:29 ` [Qemu-devel] [PATCH 13/15] s390-bios: Use control unit type to determine boot method Jason J. Herne
2019-02-04 11:46 ` Cornelia Huck
2019-01-29 13:29 ` [Qemu-devel] [PATCH 14/15] s390-bios: Add channel command codes/structs needed for dasd-ipl Jason J. Herne
2019-02-04 11:47 ` Cornelia Huck
2019-01-29 13:29 ` [Qemu-devel] [PATCH 15/15] s390-bios: Support booting from real dasd device Jason J. Herne
2019-01-31 18:23 ` Cornelia Huck
2019-02-04 12:02 ` Cornelia Huck
2019-02-19 14:57 ` Jason J. Herne
2019-02-21 2:52 ` [Qemu-devel] [qemu-s390x] " Eric Farman
2019-02-21 13:22 ` Jason J. Herne
2019-01-29 16:40 ` [Qemu-devel] [qemu-s390x] [PATCH 00/15] s390: vfio-ccw dasd ipl support Jason J. Herne
2019-01-31 18:10 ` [Qemu-devel] " no-reply
-- strict thread matches above, loose matches on Subject: below --
2018-12-12 14:11 Jason J. Herne
2018-12-12 14:11 ` [Qemu-devel] [PATCH 10/15] s390-bios: Support for running format-0/1 channel programs Jason J. Herne
2018-12-13 16:54 ` Farhan Ali
2018-12-13 17:21 ` Cornelia Huck
2019-01-07 19:02 ` Jason J. Herne
2019-01-08 11:07 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190222093559.5334886d.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=alifm@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=jjherne@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.