From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PATCH v2 00/16] KVM: PPC: Book3S HV: add XIVE native exploitation mode Date: Fri, 22 Feb 2019 12:28:24 +0100 Message-ID: <20190222112840.25000-1-clg@kaod.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: kvm@vger.kernel.org, Paul Mackerras , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , linuxppc-dev@lists.ozlabs.org, David Gibson To: kvm-ppc@vger.kernel.org Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" List-Id: kvm.vger.kernel.org Hello, On the POWER9 processor, the XIVE interrupt controller can control interrupt sources using MMIOs to trigger events, to EOI or to turn off the sources. Priority management and interrupt acknowledgment is also controlled by MMIO in the CPU presenter subengine. PowerNV/baremetal Linux runs natively under XIVE but sPAPR guests need special support from the hypervisor to do the same. This is called the XIVE native exploitation mode and today, it can be activated under the PowerPC Hypervisor, pHyp. However, Linux/KVM lacks XIVE native support and still offers the old interrupt mode interface using a KVM device implementing the XICS hcalls over XIVE. The following series is proposal to add the same support under KVM. A new KVM device is introduced for the XIVE native exploitation mode. It reuses most of the XICS-over-XIVE glue implementation structures which are internal to KVM but has a completely different interface. A set of KVM device ioctls provide support for the hypervisor calls, all handled in QEMU, to configure the sources and the event queues. From there, all interrupt control is transferred to the guest which can use MMIOs. These MMIO regions (ESB and TIMA) are exposed to guests in QEMU, similarly to VFIO, and the associated VMAs are populated dynamically with the appropriate pages using a fault handler. These are now implemented using mmap()s of the KVM device fd. Migration has its own specific needs regarding memory. The patchset provides a specific control to quiesce XIVE before capturing the memory. The save and restore of the internal state is based on the same ioctls used for the hcalls. On a POWER9 sPAPR machine, the Client Architecture Support (CAS) negotiation process determines whether the guest operates with a interrupt controller using the XICS legacy model, as found on POWER8, or in XIVE exploitation mode. Which means that the KVM interrupt device should be created at runtime, after the machine has started. This requires extra support from KVM to destroy KVM devices. It is introduced at the end of the patcshet as it still requires some attention and a XIVE-only VM would not need. This is 5.2 material. I expect a couple of respin for fixes, and the OPAL patches have not yet been merged. GitHub trees available here : QEMU sPAPR: https://github.com/legoater/qemu/commits/xive-next Linux/KVM: https://github.com/legoater/linux/commits/xive-5.0 OPAL: https://github.com/legoater/skiboot/commits/xive Thanks, C. Changes since v1: - Better documentation (was missing) - Nested support. XIVE not advertised on non PowerNV platforms. This is a good way to test the fallback on QEMU emulated devices. - ESB and TIMA special mapping done using the KVM device fd - All hcalls moved to QEMU. Dropped the patch moving the hcall flags. - Reworked of the KVM device ioctl controls to support hcalls and migration needs to capture/save states - Merged the control syncing XIVE and marking the EQ page dirty - Fixed passthrough support using the KVM device file address_space to clear the ESB pages from the mapping - Misc enhancements and fixes Cédric Le Goater (16): powerpc/xive: add OPAL extensions for the XIVE native exploitation support KVM: PPC: Book3S HV: add a new KVM device for the XIVE native exploitation mode KVM: PPC: Book3S HV: XIVE: introduce a new capability KVM_CAP_PPC_IRQ_XIVE KVM: PPC: Book3S HV: XIVE: add a control to initialize a source KVM: PPC: Book3S HV: XIVE: add a control to configure a source KVM: PPC: Book3S HV: XIVE: add controls for the EQ configuration KVM: PPC: Book3S HV: XIVE: add a global reset control KVM: PPC: Book3S HV: XIVE: add a control to sync the sources KVM: PPC: Book3S HV: XIVE: add a control to dirty the XIVE EQ pages KVM: PPC: Book3S HV: XIVE: add get/set accessors for the VP XIVE state KVM: introduce a 'mmap' method for KVM devices KVM: PPC: Book3S HV: XIVE: add a TIMA mapping KVM: PPC: Book3S HV: XIVE: add a mapping for the source ESB pages KVM: PPC: Book3S HV: XIVE: add passthrough support KVM: introduce a KVM_DESTROY_DEVICE ioctl KVM: PPC: Book3S HV: XIVE: clear the vCPU interrupt presenters arch/powerpc/include/asm/kvm_host.h | 2 + arch/powerpc/include/asm/kvm_ppc.h | 32 + arch/powerpc/include/asm/opal-api.h | 11 +- arch/powerpc/include/asm/opal.h | 7 + arch/powerpc/include/asm/xive.h | 17 + arch/powerpc/include/uapi/asm/kvm.h | 48 + arch/powerpc/kvm/book3s_xive.h | 31 + include/linux/kvm_host.h | 1 + include/uapi/linux/kvm.h | 10 + arch/powerpc/kvm/book3s.c | 31 +- arch/powerpc/kvm/book3s_xics.c | 19 + arch/powerpc/kvm/book3s_xive.c | 149 ++- arch/powerpc/kvm/book3s_xive_native.c | 1171 +++++++++++++++++ arch/powerpc/kvm/powerpc.c | 33 + arch/powerpc/sysdev/xive/native.c | 110 ++ virt/kvm/kvm_main.c | 49 + Documentation/virtual/kvm/api.txt | 28 + Documentation/virtual/kvm/devices/xive.txt | 190 +++ arch/powerpc/kvm/Makefile | 2 +- .../powerpc/platforms/powernv/opal-wrappers.S | 3 + 20 files changed, 1896 insertions(+), 48 deletions(-) create mode 100644 arch/powerpc/kvm/book3s_xive_native.c create mode 100644 Documentation/virtual/kvm/devices/xive.txt -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Date: Fri, 22 Feb 2019 11:28:24 +0000 Subject: [PATCH v2 00/16] KVM: PPC: Book3S HV: add XIVE native exploitation mode Message-Id: <20190222112840.25000-1-clg@kaod.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: kvm-ppc@vger.kernel.org Cc: kvm@vger.kernel.org, Paul Mackerras , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , linuxppc-dev@lists.ozlabs.org, David Gibson Hello, On the POWER9 processor, the XIVE interrupt controller can control interrupt sources using MMIOs to trigger events, to EOI or to turn off the sources. Priority management and interrupt acknowledgment is also controlled by MMIO in the CPU presenter subengine. PowerNV/baremetal Linux runs natively under XIVE but sPAPR guests need special support from the hypervisor to do the same. This is called the XIVE native exploitation mode and today, it can be activated under the PowerPC Hypervisor, pHyp. However, Linux/KVM lacks XIVE native support and still offers the old interrupt mode interface using a KVM device implementing the XICS hcalls over XIVE. The following series is proposal to add the same support under KVM. A new KVM device is introduced for the XIVE native exploitation mode. It reuses most of the XICS-over-XIVE glue implementation structures which are internal to KVM but has a completely different interface. A set of KVM device ioctls provide support for the hypervisor calls, all handled in QEMU, to configure the sources and the event queues. From there, all interrupt control is transferred to the guest which can use MMIOs. These MMIO regions (ESB and TIMA) are exposed to guests in QEMU, similarly to VFIO, and the associated VMAs are populated dynamically with the appropriate pages using a fault handler. These are now implemented using mmap()s of the KVM device fd. Migration has its own specific needs regarding memory. The patchset provides a specific control to quiesce XIVE before capturing the memory. The save and restore of the internal state is based on the same ioctls used for the hcalls. On a POWER9 sPAPR machine, the Client Architecture Support (CAS) negotiation process determines whether the guest operates with a interrupt controller using the XICS legacy model, as found on POWER8, or in XIVE exploitation mode. Which means that the KVM interrupt device should be created at runtime, after the machine has started. This requires extra support from KVM to destroy KVM devices. It is introduced at the end of the patcshet as it still requires some attention and a XIVE-only VM would not need. This is 5.2 material. I expect a couple of respin for fixes, and the OPAL patches have not yet been merged. GitHub trees available here : =20 QEMU sPAPR: https://github.com/legoater/qemu/commits/xive-next =20 Linux/KVM: https://github.com/legoater/linux/commits/xive-5.0 OPAL: https://github.com/legoater/skiboot/commits/xive Thanks, C. Changes since v1: - Better documentation (was missing) - Nested support. XIVE not advertised on non PowerNV platforms. This is a good way to test the fallback on QEMU emulated devices. - ESB and TIMA special mapping done using the KVM device fd - All hcalls moved to QEMU. Dropped the patch moving the hcall flags. - Reworked of the KVM device ioctl controls to support hcalls and migration needs to capture/save states - Merged the control syncing XIVE and marking the EQ page dirty - Fixed passthrough support using the KVM device file address_space to clear the ESB pages from the mapping - Misc enhancements and fixes=20 C=C3=A9dric Le Goater (16): powerpc/xive: add OPAL extensions for the XIVE native exploitation support KVM: PPC: Book3S HV: add a new KVM device for the XIVE native exploitation mode KVM: PPC: Book3S HV: XIVE: introduce a new capability KVM_CAP_PPC_IRQ_XIVE KVM: PPC: Book3S HV: XIVE: add a control to initialize a source KVM: PPC: Book3S HV: XIVE: add a control to configure a source KVM: PPC: Book3S HV: XIVE: add controls for the EQ configuration KVM: PPC: Book3S HV: XIVE: add a global reset control KVM: PPC: Book3S HV: XIVE: add a control to sync the sources KVM: PPC: Book3S HV: XIVE: add a control to dirty the XIVE EQ pages KVM: PPC: Book3S HV: XIVE: add get/set accessors for the VP XIVE state KVM: introduce a 'mmap' method for KVM devices KVM: PPC: Book3S HV: XIVE: add a TIMA mapping KVM: PPC: Book3S HV: XIVE: add a mapping for the source ESB pages KVM: PPC: Book3S HV: XIVE: add passthrough support KVM: introduce a KVM_DESTROY_DEVICE ioctl KVM: PPC: Book3S HV: XIVE: clear the vCPU interrupt presenters arch/powerpc/include/asm/kvm_host.h | 2 + arch/powerpc/include/asm/kvm_ppc.h | 32 + arch/powerpc/include/asm/opal-api.h | 11 +- arch/powerpc/include/asm/opal.h | 7 + arch/powerpc/include/asm/xive.h | 17 + arch/powerpc/include/uapi/asm/kvm.h | 48 + arch/powerpc/kvm/book3s_xive.h | 31 + include/linux/kvm_host.h | 1 + include/uapi/linux/kvm.h | 10 + arch/powerpc/kvm/book3s.c | 31 +- arch/powerpc/kvm/book3s_xics.c | 19 + arch/powerpc/kvm/book3s_xive.c | 149 ++- arch/powerpc/kvm/book3s_xive_native.c | 1171 +++++++++++++++++ arch/powerpc/kvm/powerpc.c | 33 + arch/powerpc/sysdev/xive/native.c | 110 ++ virt/kvm/kvm_main.c | 49 + Documentation/virtual/kvm/api.txt | 28 + Documentation/virtual/kvm/devices/xive.txt | 190 +++ arch/powerpc/kvm/Makefile | 2 +- .../powerpc/platforms/powernv/opal-wrappers.S | 3 + 20 files changed, 1896 insertions(+), 48 deletions(-) create mode 100644 arch/powerpc/kvm/book3s_xive_native.c create mode 100644 Documentation/virtual/kvm/devices/xive.txt --=20 2.20.1