Re: Reducing or removing direct map from xen (was Re: Ongoing/future speculative mitigation work)

From: Wei Liu <wei.liu2@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Martin Pohlack <mpohlack@amazon.de>,
	Julien Grall <julien.grall@arm.com>,
	Joao Martins <joao.m.martins@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Mihai Dontu <mdontu@bitdefender.com>,
	Marek Marczykowski <marmarek@invisiblethingslab.com>,
	Anthony Liguori <aliguori@amazon.com>,
	xen-devel <xen-devel@lists.xenproject.org>,
	uwed@amazon.de, Lars Kurth <lars.kurth@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Ross Philipson <ross.philipson@oracle.com>,
	Dario Faggioli <dfaggioli@suse.com>, Matt Wilson <msw@amazon.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Sergey Dyasli <sergey.dyasli@citrix.com>,
	Wei Liu <wei.liu2@citrix.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Daniel Kiper <daniel.kiper@oracle.com>,
	David Woodhouse <dwmw@amazon.co.uk>,
	Roger
Subject: Re: Reducing or removing direct map from xen (was Re: Ongoing/future speculative mitigation work)
Date: Fri, 22 Feb 2019 12:11:45 +0000	[thread overview]
Message-ID: <20190222121145.xkvchgp7yjckokri@zion.uk.xensource.com> (raw)
In-Reply-To: <5C6FE5AB02000078002191B0@prv1-mh.provo.novell.com>

On Fri, Feb 22, 2019 at 05:06:03AM -0700, Jan Beulich wrote:
> >>> On 22.02.19 at 12:50, <wei.liu2@citrix.com> wrote:
> > On Fri, Feb 22, 2019 at 04:48:09AM -0700, Jan Beulich wrote:
> >> >>> On 20.02.19 at 18:08, <wei.liu2@citrix.com> wrote:
> >> > On Wed, Feb 20, 2019 at 01:09:56PM +0000, Wei Liu wrote:
> >> > [...]
> >> >> I think under-allocate-then-map looks plausible. xmalloc will need
> >> >> to allocate pages, put them into an array and call __vmap on that array
> >> >> directly.
> >> > 
> >> > The biggest issue with this approach is that we now need an array of
> >> > 1UL<<MAX_ORDER to accommodate mfns. Back of envelope calculation: on x86
> >> > this is going to be (1UL<<20)*8 bytes long. This is not feasible.
> >> 
> >> Are we really calling xmalloc() with any number nearly this big?
> > 
> > In practice, I don't think so. What do you think is a sensible limit?
> 
> I'm afraid you won't like the answer: Whatever the biggest chunk is
> we currently allocate anywhere. Perhaps, e.g. if there's a single big
> "violator", changing some code to reduce the upper bound might be
> desirable.
> 
> In general there shouldn't be any going beyond one page once we've
> completed booting. Several years back I think I had managed to
> replace most (all?) higher order xmalloc()-s. So another option might
> be to allow up to MAX_ORDER by way of some init-only mechanism,
> and later allow only up to single page chunks.
> 

Think about it, if you have done the work to remove high order
allocations, removing this optimisation is the easiest thing to do and
wouldn't make things worse, isn't it?

Wei.

> Jan
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel