From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88008C43381 for ; Sat, 23 Feb 2019 21:32:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4695F20661 for ; Sat, 23 Feb 2019 21:32:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550957537; bh=Pp9K+JXdNblV0676UJJ+CBRYoOeW9fSnBRcUFrj8uxQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=XYsjwwbv/hV3mKt+/D9EROfvublblNn3HDSB17HsEDyb4z7/IbUNOohC2QagktJZX dYED/xzn6+eCwtWRPxaWtffWUHI9p/ln8NPJfGD9RhcU1w0nm1mIF2cel2ZGlvJV3A Upmy3OoWYX+Mp9JaDW8fDUtzr9DhrQUsuQ0biGJc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728881AbfBWVcQ (ORCPT ); Sat, 23 Feb 2019 16:32:16 -0500 Received: from mail.kernel.org ([198.145.29.99]:40556 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728330AbfBWVFZ (ORCPT ); Sat, 23 Feb 2019 16:05:25 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 187232085A; Sat, 23 Feb 2019 21:05:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550955924; bh=Pp9K+JXdNblV0676UJJ+CBRYoOeW9fSnBRcUFrj8uxQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GO5ZSl9LUOZzSLibnK765c6z+2IrUrRJ76F0rdzzlMzqWmL76CcuXUBJEqKn7OM+I /CJUG9L8zDZ8g3IzaODwU148RYsK2fHDdSMgVX+EnI1vZ0a5jClQ47p6RsTOkBlmWK rU+48IlYMtmA0tUoxenbNutbDq8GcvPQaPXCU+XU= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yonglong Liu , Peng Li , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.20 35/72] net: hns: Fix wrong read accesses via Clause 45 MDIO protocol Date: Sat, 23 Feb 2019 16:03:45 -0500 Message-Id: <20190223210422.199966-35-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190223210422.199966-1-sashal@kernel.org> References: <20190223210422.199966-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yonglong Liu [ Upstream commit cec8abba13e6a26729dfed41019720068eeeff2b ] When reading phy registers via Clause 45 MDIO protocol, after write address operation, the driver use another write address operation, so can not read the right value of any phy registers. This patch fixes it. Signed-off-by: Yonglong Liu Signed-off-by: Peng Li Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/hisilicon/hns_mdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns_mdio.c b/drivers/net/ethernet/hisilicon/hns_mdio.c index 017e08452d8c0..baf5cc251f329 100644 --- a/drivers/net/ethernet/hisilicon/hns_mdio.c +++ b/drivers/net/ethernet/hisilicon/hns_mdio.c @@ -321,7 +321,7 @@ static int hns_mdio_read(struct mii_bus *bus, int phy_id, int regnum) } hns_mdio_cmd_write(mdio_dev, is_c45, - MDIO_C45_WRITE_ADDR, phy_id, devad); + MDIO_C45_READ, phy_id, devad); } /* Step 5: waitting for MDIO_COMMAND_REG 's mdio_start==0,*/ -- 2.19.1