From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: No traffic with Marvell switch and latest linux-next
Date: Sun, 24 Feb 2019 15:15:55 +0000 [thread overview]
Message-ID: <20190224151555.xsopwkuicsop65rw@shell.armlinux.org.uk> (raw)
In-Reply-To: <20190224150403.GF26626@lunn.ch>
On Sun, Feb 24, 2019 at 04:04:03PM +0100, Andrew Lunn wrote:
> > I think what's not correct is that phydev->autoneg is set
> > (by phy_device_create) for a fixed link.
>
> Fixed-link tries to emulate auto-neg:
>
> bmsr |= BMSR_LSTATUS | BMSR_ANEGCOMPLETE;
>
> Maybe it needs better emulation of auto-neg?
Or maybe it needs to represent a fixed-speed PHY by clearing bit 1.3
(BMSR_ANEGCAPABLE). In any case, 0.12 (BMCR_ANENABLE) is not set,
so according to 802.3-2015, we should not be setting 1.5
(BMSR_ANEGCOMPLETE).
However, swphy does try to emulate autonegotiation - we do have cases
where swphy is used in situations where the speed and duplex are not
fixed. It returns an emulated link partner advertisement for the
current speed, which would suggest that we should set BMCR_ANENABLE.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
next prev parent reply other threads:[~2019-02-24 15:16 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-17 15:34 No traffic with Marvell switch and latest linux-next Heiner Kallweit
2019-02-17 15:40 ` Russell King - ARM Linux admin
2019-02-17 15:50 ` Heiner Kallweit
2019-02-17 16:40 ` Heiner Kallweit
2019-02-17 16:57 ` Andrew Lunn
2019-02-17 17:06 ` Heiner Kallweit
2019-02-17 17:10 ` Andrew Lunn
2019-02-18 18:16 ` Heiner Kallweit
2019-02-18 18:21 ` Andrew Lunn
2019-02-23 21:48 ` Heiner Kallweit
2019-02-23 23:42 ` Andrew Lunn
2019-02-24 9:10 ` Heiner Kallweit
2019-02-24 15:04 ` Andrew Lunn
2019-02-24 15:15 ` Russell King - ARM Linux admin [this message]
2019-02-24 15:28 ` Heiner Kallweit
2019-02-24 15:34 ` Russell King - ARM Linux admin
2019-02-24 15:39 ` Heiner Kallweit
2019-02-24 15:49 ` Russell King - ARM Linux admin
2019-02-24 16:32 ` Florian Fainelli
2019-02-24 17:04 ` Andrew Lunn
2019-02-24 21:26 ` Florian Fainelli
2019-02-24 21:42 ` Heiner Kallweit
2019-02-24 15:31 ` Russell King - ARM Linux admin
2019-02-24 17:28 ` Andrew Lunn
2019-02-24 19:41 ` Russell King - ARM Linux admin
2019-02-23 23:55 ` Florian Fainelli
2019-02-17 15:45 ` Andrew Lunn
2019-02-17 15:48 ` Heiner Kallweit
2019-02-17 15:57 ` Andrew Lunn
2019-02-17 16:01 ` Heiner Kallweit
2019-02-17 15:51 ` Andrew Lunn
2019-02-17 15:55 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190224151555.xsopwkuicsop65rw@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.