All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bharath Vedartham <linux.bhar@gmail.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] badblocks: Prefer unsigned int over unsigned
Date: Sun, 24 Feb 2019 21:07:12 +0530	[thread overview]
Message-ID: <20190224153712.GA11981@bharath12345-Inspiron-5559> (raw)
In-Reply-To: <b96f9ac8-639c-adfa-e0a4-5ff537bc9db4@kernel.dk>

On Sun, Feb 24, 2019 at 08:15:30AM -0700, Jens Axboe wrote:
> On 2/24/19 7:19 AM, Bharath Vedartham wrote:
> > Replace unsigned with unsigned int to improve readability.
> 
> Frivolous change, would make a lot more sense to get checkpatch
> to stop complaining about this.
> 
> -- 
> Jens Axboe
>
I understand. I am starting out kernel hacking. I have been working on
fixing checkpatch.pl warnings. If you have any tasks for me in the
kernel, it would be great.

I have also noticed a lot of warnings to replace printk with subsystem
specific warning functions. Is that a valuable change?

Bharath

  reply	other threads:[~2019-02-24 15:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-24 14:19 [PATCH] badblocks: Prefer unsigned int over unsigned Bharath Vedartham
2019-02-24 15:15 ` Jens Axboe
2019-02-24 15:37   ` Bharath Vedartham [this message]
2019-02-24 15:50     ` Richard Weinberger
2019-02-25 17:03       ` Bharath Vedartham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190224153712.GA11981@bharath12345-Inspiron-5559 \
    --to=linux.bhar@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.