From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31C04C43381 for ; Sun, 24 Feb 2019 16:47:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F3369205C9 for ; Sun, 24 Feb 2019 16:47:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="ZwWLG167" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728514AbfBXQrz (ORCPT ); Sun, 24 Feb 2019 11:47:55 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:36881 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728179AbfBXQrz (ORCPT ); Sun, 24 Feb 2019 11:47:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=FqLvvyhjrIB0IqahbEaAyEzVzkeb0T9uXGvnfQYspxU=; b=ZwWLG167pErnUaP1FfQH34kNr9 4iEP56zKVK/9Y381Wblh+7BBJEDTUaKa7aYC1P7Jpz1bcGbogZZN8v0E9+ZYqJQx/Zk00LY49pida vKGOqGVbERmaZN83Edb96sqMInt26V6SWD1hTnMZEHYV/RbM4Ty8RW1bz1DqUvc8tjVI=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1gxwwS-0004H5-0b; Sun, 24 Feb 2019 17:47:52 +0100 Date: Sun, 24 Feb 2019 17:47:51 +0100 From: Andrew Lunn To: Tariq Toukan Cc: "John W. Linville" , netdev@vger.kernel.org, Eran Ben Elisha , Aya Levin Subject: Re: [PATCH ethtool] ethtool: Add support for 200Gbps (50Gbps per lane) link mode Message-ID: <20190224164751.GG26626@lunn.ch> References: <1551020901-20257-1-git-send-email-tariqt@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1551020901-20257-1-git-send-email-tariqt@mellanox.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Feb 24, 2019 at 05:08:21PM +0200, Tariq Toukan wrote: > From: Aya Levin > index 5a26cff5fb33..64ce0711ad5f 100644 > --- a/ethtool.8.in > +++ b/ethtool.8.in > @@ -650,6 +650,11 @@ lB l lB. > 0x400000000 50000baseCR2 Full > 0x800000000 50000baseKR2 Full > 0x10000000000 50000baseSR2 Full > +0x10000000000000 50000baseKR Full > +0x20000000000000 50000baseSR Full > +0x40000000000000 50000baseCR Full > +0x80000000000000 50000baseLR_ER_FR Full > +0x100000000000000 50000baseDR Full > 0x8000000 56000baseKR4 Full > 0x10000000 56000baseCR4 Full > 0x20000000 56000baseSR4 Full > @@ -658,6 +663,16 @@ lB l lB. > 0x2000000000 100000baseSR4 Full > 0x4000000000 100000baseCR4 Full > 0x8000000000 100000baseLR4_ER4 Full > +0x200000000000000 100000baseKR2 Full > +0x400000000000000 100000baseSR2 Full > +0x800000000000000 100000baseCR2 Full > +0x1000000000000000 100000baseLR2_ER2_FR2 Full > +0x2000000000000000 100000baseDR2 Full > +0x4000000000000000 200000baseKR4 Full > +0x8000000000000000 200000baseSR4 Full > +0x10000000000000000 200000baseLR4_ER4_FR4 Full > +0x20000000000000000 200000baseDR4 Full > +0x40000000000000000 200000baseCR4 Full This is getting less friendly all the time, and it was never very friendly to start with. We have the strings which represent these link modes in the table used for dumping caps. How about allowing the user to list a comma separate list of modes. ethtool -s lan42 advertise 100000baseKR2/Full,100000baseSR2/Full,100000baseCR2/Full Andrew > + adv_bit = ETHTOOL_LINK_MODE_200000baseKR4_Full_BIT & > + ETHTOOL_LINK_MODE_200000baseSR4_Full_BIT & > + ETHTOOL_LINK_MODE_200000baseLR4_ER4_FR4_Full_BIT & > + ETHTOOL_LINK_MODE_200000baseDR4_Full_BIT & > + ETHTOOL_LINK_MODE_200000baseCR4_Full_BIT; Maybe i'm wrong, but this looks odd. enum ethtool_link_mode_bit_indices { ETHTOOL_LINK_MODE_10baseT_Half_BIT = 0, ETHTOOL_LINK_MODE_10baseT_Full_BIT = 1, ETHTOOL_LINK_MODE_100baseT_Half_BIT = 2, ETHTOOL_LINK_MODE_100baseT_Full_BIT = 3, ETHTOOL_LINK_MODE_1000baseT_Half_BIT = 4, ETHTOOL_LINK_MODE_1000baseT_Full_BIT = 5, These are numbers, not bitmasks, so & them together does not look correct. Andrew