From: Jiri Olsa <jolsa@kernel.org> To: Arnaldo Carvalho de Melo <acme@kernel.org> Cc: lkml <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>, Namhyung Kim <namhyung@kernel.org>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Peter Zijlstra <a.p.zijlstra@chello.nl>, Adrian Hunter <adrian.hunter@intel.com>, Andi Kleen <ak@linux.intel.com>, Stephane Eranian <eranian@google.com>, Alexey Budankov <alexey.budankov@linux.intel.com> Subject: [PATCH 16/20] perf session: Add __perf_session__process_dir_events function Date: Sun, 24 Feb 2019 20:06:52 +0100 [thread overview] Message-ID: <20190224190656.30163-17-jolsa@kernel.org> (raw) In-Reply-To: <20190224190656.30163-1-jolsa@kernel.org> Adding __perf_session__process_dir_events function to process events over the directory data. All directory events are pushed into sessions ordered data and flushed for processing. Link: http://lkml.kernel.org/n/tip-n3zl0wo3z18tatv5x7epmjrh@git.kernel.org Signed-off-by: Jiri Olsa <jolsa@kernel.org> --- tools/perf/util/session.c | 88 ++++++++++++++++++++++++++++++++++++++- 1 file changed, 86 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c index 90cec49903b9..1f183bd1a208 100644 --- a/tools/perf/util/session.c +++ b/tools/perf/util/session.c @@ -1878,8 +1878,6 @@ reader__process_events(struct reader *rd, struct perf_session *session, file_offset = page_offset; head = rd->data_offset - page_offset; - ui_progress__init_size(prog, data_size, "Processing events..."); - data_size += rd->data_offset; mmap_size = MMAP_SIZE; @@ -2008,6 +2006,89 @@ static int __perf_session__process_events(struct perf_session *session) return err; } +static s64 process_index(struct perf_session *session, + union perf_event *event, + u64 file_offset) +{ + struct perf_evlist *evlist = session->evlist; + u64 timestamp; + s64 ret; + + if (session->header.needs_swap) + event_swap(event, perf_evlist__sample_id_all(evlist)); + + if (event->header.type >= PERF_RECORD_HEADER_MAX) + return -EINVAL; + + events_stats__inc(&evlist->stats, event->header.type); + + if (event->header.type >= PERF_RECORD_USER_TYPE_START) + return perf_session__process_user_event(session, event, file_offset); + + ret = perf_evlist__parse_sample_timestamp(evlist, event, ×tamp); + if (ret) + return ret; + + return ordered_events__queue(&session->ordered_events, event, + timestamp, file_offset); +} + +static int __perf_session__process_dir_events(struct perf_session *session) +{ + struct perf_data *data = session->data; + struct perf_tool *tool = session->tool; + struct reader rd = { + .fd = perf_data__fd(session->data), + .data_size = session->header.data_size, + .data_offset = session->header.data_offset, + .process = process_simple, + }; + int i, ret = 0; + struct ui_progress prog; + u64 total_size = perf_data__size(session->data); + + perf_tool__fill_defaults(tool); + + ui_progress__init_size(&prog, total_size, "Processing events..."); + + /* Read data from the header file.. */ + ret = reader__process_events(&rd, session, &prog); + if (ret) + goto out_err; + + /* ... and continue with data files. */ + for (i = 0; i < data->dir.nr ; i++) { + struct perf_data_file *file = &data->dir.files[i]; + + if (file->size == 0) + continue; + + rd = (struct reader) { + .fd = file->fd, + .data_size = file->size, + .data_offset = 0, + .process = process_index, + }; + + ret = reader__process_events(&rd, session, &prog); + if (ret) + goto out_err; + } + + ret = ordered_events__flush(&session->ordered_events, OE_FLUSH__FINAL); + +out_err: + if (!tool->no_warn) + perf_session__warn_about_errors(session); + + /* + * We may switching perf.data output, make ordered_events + * reusable. + */ + ordered_events__reinit(&session->ordered_events); + return ret; +} + int perf_session__process_events(struct perf_session *session) { if (perf_session__register_idle_thread(session) < 0) @@ -2016,6 +2097,9 @@ int perf_session__process_events(struct perf_session *session) if (perf_data__is_pipe(session->data)) return __perf_session__process_pipe_events(session); + if (perf_data__is_dir(session->data)) + return __perf_session__process_dir_events(session); + return __perf_session__process_events(session); } -- 2.17.2
next prev parent reply other threads:[~2019-02-24 19:08 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-24 19:06 [PATCHv3 00/20] perf record: Add support to store data in directory Jiri Olsa 2019-02-24 19:06 ` [PATCH 01/20] perf tools: Add depth checking to rm_rf Jiri Olsa 2019-02-28 8:00 ` [tip:perf/core] " tip-bot for Jiri Olsa 2019-02-24 19:06 ` [PATCH 02/20] perf tools: Add pattern name " Jiri Olsa 2019-02-28 8:00 ` [tip:perf/core] " tip-bot for Jiri Olsa 2019-02-24 19:06 ` [PATCH 03/20] perf tools: Add rm_rf_perf_data function Jiri Olsa 2019-02-28 8:01 ` [tip:perf/core] " tip-bot for Jiri Olsa 2019-02-24 19:06 ` [PATCH 04/20] perf data: Move size to struct perf_data_file Jiri Olsa 2019-02-24 19:06 ` [PATCH 05/20] perf data: Add global path holder Jiri Olsa 2019-02-24 19:06 ` [PATCH 06/20] perf data: Make check_backup work over directories Jiri Olsa 2019-02-28 8:02 ` [tip:perf/core] " tip-bot for Jiri Olsa 2019-02-24 19:06 ` [PATCH 07/20] perf data: Fail check_backup in case of error Jiri Olsa 2019-02-28 8:02 ` [tip:perf/core] " tip-bot for Jiri Olsa 2019-02-24 19:06 ` [PATCH 08/20] perf data: Add perf_data__(create_dir|close_dir) functions Jiri Olsa 2019-02-28 8:03 ` [tip:perf/core] " tip-bot for Jiri Olsa 2019-02-24 19:06 ` [PATCH 09/20] perf data: Add perf_data__open_dir_data function Jiri Olsa 2019-02-28 8:04 ` [tip:perf/core] " tip-bot for Jiri Olsa 2019-02-24 19:06 ` [PATCH 10/20] perf data: Add directory support Jiri Olsa 2019-02-25 13:45 ` Arnaldo Carvalho de Melo 2019-02-25 13:56 ` Jiri Olsa 2019-02-25 15:07 ` Arnaldo Carvalho de Melo 2019-02-25 15:36 ` Jiri Olsa 2019-02-24 19:06 ` [PATCH 11/20] perf data: Don't store auxtrace index for directory data file Jiri Olsa 2019-02-24 19:06 ` [PATCH 12/20] perf data: Add perf_data__update_dir function Jiri Olsa 2019-02-24 19:06 ` [PATCH 13/20] perf data: Make perf_data__size to work over directory Jiri Olsa 2019-02-24 19:06 ` [PATCH 14/20] perf header: Add DIR_FORMAT feature to describe directory data Jiri Olsa 2019-02-24 19:06 ` [PATCH 15/20] perf session: Add process callback to reader object Jiri Olsa 2019-02-24 19:06 ` Jiri Olsa [this message] 2019-02-24 19:06 ` [PATCH 17/20] perf session: Add path " Jiri Olsa 2019-02-24 19:06 ` [PATCH 18/20] perf record: Add --dir option to store data in directory Jiri Olsa 2019-02-24 19:06 ` [PATCH 19/20] perf record: Add --output-dir " Jiri Olsa 2019-02-24 19:06 ` [PATCH 20/20] perf record: Describe perf.data directory format Jiri Olsa
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190224190656.30163-17-jolsa@kernel.org \ --to=jolsa@kernel.org \ --cc=a.p.zijlstra@chello.nl \ --cc=acme@kernel.org \ --cc=adrian.hunter@intel.com \ --cc=ak@linux.intel.com \ --cc=alexander.shishkin@linux.intel.com \ --cc=alexey.budankov@linux.intel.com \ --cc=eranian@google.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@kernel.org \ --cc=namhyung@kernel.org \ --subject='Re: [PATCH 16/20] perf session: Add __perf_session__process_dir_events function' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.