From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove_device() Date: Mon, 25 Feb 2019 08:07:15 +0300 Message-ID: <20190225080715.4965810a@dimatab> References: <20190224153622.8877-1-digetx@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Peter Chen Cc: Greg Kroah-Hartman , Thierry Reding , Jonathan Hunter , "linux-usb@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-Id: linux-tegra@vger.kernel.org =D0=92 Mon, 25 Feb 2019 02:27:19 +0000 Peter Chen =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > =20 > >=20 > > Fixes: dfebb5f43a78827a ("usb: chipidea: Add support for > > Tegra20/30/114/124") =20 >=20 > I suppose you need to apply at stable tree too, right? >=20 It is enough to have the "Fixes" tag to get patch backported into all relevant kernel versions. > > Signed-off-by: Dmitry Osipenko > > --- > > drivers/usb/chipidea/ci_hdrc_tegra.c | 1 + > > 1 file changed, 1 insertion(+) > >=20 > > diff --git a/drivers/usb/chipidea/ci_hdrc_tegra.c > > b/drivers/usb/chipidea/ci_hdrc_tegra.c > > index 772851bee99b..12025358bb3c 100644 > > --- a/drivers/usb/chipidea/ci_hdrc_tegra.c > > +++ b/drivers/usb/chipidea/ci_hdrc_tegra.c > > @@ -130,6 +130,7 @@ static int tegra_udc_remove(struct > > platform_device *pdev) { > > struct tegra_udc *udc =3D platform_get_drvdata(pdev); > >=20 > > + ci_hdrc_remove_device(udc->dev); > > usb_phy_set_suspend(udc->phy, 1); > > clk_disable_unprepare(udc->clk); > > =20 > =20 > Acked-by: Peter Chen >=20 > Hi Greg, would you still accept the bug-fix for this release (v5.0)? > Or I send you later? I just want to point out that the bug existed for a very long time and apparently didn't bother anybody, hence it's not an urgent fix. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove_device() From: Dmitry Osipenko Message-Id: <20190225080715.4965810a@dimatab> Date: Mon, 25 Feb 2019 08:07:15 +0300 To: Peter Chen Cc: Greg Kroah-Hartman , Thierry Reding , Jonathan Hunter , "linux-usb@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-ID: 0JIgTW9uLCAyNSBGZWIgMjAxOSAwMjoyNzoxOSArMDAwMApQZXRlciBDaGVuIDxwZXRlci5jaGVu QG54cC5jb20+INC/0LjRiNC10YI6Cgo+ICAKPiA+IAo+ID4gRml4ZXM6IGRmZWJiNWY0M2E3ODgy N2EgKCJ1c2I6IGNoaXBpZGVhOiBBZGQgc3VwcG9ydCBmb3IKPiA+IFRlZ3JhMjAvMzAvMTE0LzEy NCIpICAKPiAKPiBJIHN1cHBvc2UgeW91IG5lZWQgdG8gYXBwbHkgYXQgc3RhYmxlIHRyZWUgdG9v LCByaWdodD8KPiAKCkl0IGlzIGVub3VnaCB0byBoYXZlIHRoZSAiRml4ZXMiIHRhZyB0byBnZXQg cGF0Y2ggYmFja3BvcnRlZCBpbnRvIGFsbApyZWxldmFudCBrZXJuZWwgdmVyc2lvbnMuCgo+ID4g U2lnbmVkLW9mZi1ieTogRG1pdHJ5IE9zaXBlbmtvIDxkaWdldHhAZ21haWwuY29tPgo+ID4gLS0t Cj4gPiAgZHJpdmVycy91c2IvY2hpcGlkZWEvY2lfaGRyY190ZWdyYS5jIHwgMSArCj4gPiAgMSBm aWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJz L3VzYi9jaGlwaWRlYS9jaV9oZHJjX3RlZ3JhLmMKPiA+IGIvZHJpdmVycy91c2IvY2hpcGlkZWEv Y2lfaGRyY190ZWdyYS5jCj4gPiBpbmRleCA3NzI4NTFiZWU5OWIuLjEyMDI1MzU4YmIzYyAxMDA2 NDQKPiA+IC0tLSBhL2RyaXZlcnMvdXNiL2NoaXBpZGVhL2NpX2hkcmNfdGVncmEuYwo+ID4gKysr IGIvZHJpdmVycy91c2IvY2hpcGlkZWEvY2lfaGRyY190ZWdyYS5jCj4gPiBAQCAtMTMwLDYgKzEz MCw3IEBAIHN0YXRpYyBpbnQgdGVncmFfdWRjX3JlbW92ZShzdHJ1Y3QKPiA+IHBsYXRmb3JtX2Rl dmljZSAqcGRldikgewo+ID4gIAlzdHJ1Y3QgdGVncmFfdWRjICp1ZGMgPSBwbGF0Zm9ybV9nZXRf ZHJ2ZGF0YShwZGV2KTsKPiA+IAo+ID4gKwljaV9oZHJjX3JlbW92ZV9kZXZpY2UodWRjLT5kZXYp Owo+ID4gIAl1c2JfcGh5X3NldF9zdXNwZW5kKHVkYy0+cGh5LCAxKTsKPiA+ICAJY2xrX2Rpc2Fi bGVfdW5wcmVwYXJlKHVkYy0+Y2xrKTsKPiA+ICAgCj4gIAo+IEFja2VkLWJ5OiBQZXRlciBDaGVu IDxwZXRlci5jaGVuQG54cC5jb20+Cj4gCj4gSGkgR3JlZywgd291bGQgeW91IHN0aWxsIGFjY2Vw dCB0aGUgYnVnLWZpeCBmb3IgdGhpcyByZWxlYXNlICh2NS4wKT8KPiBPciBJIHNlbmQgeW91IGxh dGVyPwoKSSBqdXN0IHdhbnQgdG8gcG9pbnQgb3V0IHRoYXQgdGhlIGJ1ZyBleGlzdGVkIGZvciBh IHZlcnkgbG9uZyB0aW1lIGFuZAphcHBhcmVudGx5IGRpZG4ndCBib3RoZXIgYW55Ym9keSwgaGVu Y2UgaXQncyBub3QgYW4gdXJnZW50IGZpeC4K