From: LABBE Corentin <clabbe@baylibre.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Eugeniy.Paltsev@synopsys.com, vgupta@synopsys.com,
stable@vger.kernel.org, khilman@baylibre.com
Subject: Re: WTF: patch "[PATCH] ARC: enable uboot support unconditionally" was seriously submitted to be applied to the 4.20-stable tree?
Date: Mon, 25 Feb 2019 15:19:58 +0100 [thread overview]
Message-ID: <20190225141958.GB11694@Red> (raw)
In-Reply-To: <20190225135400.GA27690@kroah.com>
On Mon, Feb 25, 2019 at 02:54:00PM +0100, Greg KH wrote:
> On Mon, Feb 25, 2019 at 10:43:47AM +0100, LABBE Corentin wrote:
> > On Sun, Feb 24, 2019 at 02:54:28PM +0100, gregkh@linuxfoundation.org wrote:
> > > The patch below was submitted to be applied to the 4.20-stable tree.
> > >
> > > I fail to see how this patch meets the stable kernel rules as found at
> > > Documentation/process/stable-kernel-rules.rst.
> > >
> > > I could be totally wrong, and if so, please respond to
> > > <stable@vger.kernel.org> and let me know why this patch should be
> > > applied. Otherwise, it is now dropped from my patch queues, never to be
> > > seen again.
> > >
> > > thanks,
> > >
> > > greg k-h
> > >
> >
> > Hello
> >
> > Without this patch, we cannot boot a defconfig on ARC, and this is
> > critical for testing ARC devices in kernelCI.
>
> But this means you have never been able to boot a defconfig on ARC,
> right? So this is a new "feature" you are adding :)
No I was able to boot them, but by adding CONFIG_ARC_UBOOT_SUPPORT.
This patch remove the assertion that ARC devices will be booted by default for debugging purpose.
>
> If you wait one more week, all is good, you can do this for 5.0, and
> when I drop 4.20 in another few weeks, all is fine.
>
> > Why this patch is not a real stable patch, it is a strong requirement
> > for testing all future stable release on kernelCI.
>
> Only for 4.20.
>
> And normally kernelci uses a specific configuration for the board it is
> testing, not defconfig. Or am I mistaken?
No, kernelci only build defconfig without touching them.
>
> This is a fine patch to have upstream, it just really doesn't fit the
> stable rules.
>
> > Note that another patch (touching defconfig) for booting defconfig is
> > still missing and need to be also added to stable. (I will resend it
> > today)
>
> Again, looks like a new feature. Just wait a week and all will be fine
> for you :)
>
next prev parent reply other threads:[~2019-02-25 14:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-24 13:54 WTF: patch "[PATCH] ARC: enable uboot support unconditionally" was seriously submitted to be applied to the 4.20-stable tree? gregkh
2019-02-25 9:43 ` LABBE Corentin
2019-02-25 13:54 ` Greg KH
2019-02-25 14:19 ` LABBE Corentin [this message]
2019-02-25 23:11 ` Kevin Hilman
2019-02-26 8:08 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190225141958.GB11694@Red \
--to=clabbe@baylibre.com \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@baylibre.com \
--cc=stable@vger.kernel.org \
--cc=vgupta@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.