All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Noralf Trønnes" <noralf@tronnes.org>,
	dri-devel@lists.freedesktop.org,
	"David Airlie" <airlied@linux.ie>,
	"Daniel Vetter" <daniel@ffwll.ch>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v1] drm/tinydrm/ili9341: Support Adafruit 2.8" TFT display
Date: Mon, 25 Feb 2019 17:45:34 +0300	[thread overview]
Message-ID: <20190225144534.29859-1-andriy.shevchenko@linux.intel.com> (raw)

The Adafruit 2.8" TFT display [1] has different dimensions than 2.4" one.
Add support for it.

[1]: https://cdn-shop.adafruit.com/datasheets/MI0283QT-11+V1.1.PDF

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---

- based on top of drm-tip

 drivers/gpu/drm/tinydrm/ili9341.c | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/tinydrm/ili9341.c b/drivers/gpu/drm/tinydrm/ili9341.c
index 3b7565a6311e..7e20d7f1b25f 100644
--- a/drivers/gpu/drm/tinydrm/ili9341.c
+++ b/drivers/gpu/drm/tinydrm/ili9341.c
@@ -140,6 +140,10 @@ static const struct drm_display_mode yx240qv29_mode = {
 	DRM_SIMPLE_MODE(240, 320, 37, 49),
 };
 
+static const struct drm_display_mode dt280qv10_mode = {
+	DRM_SIMPLE_MODE(240, 320, 43, 58),
+};
+
 DEFINE_DRM_GEM_CMA_FOPS(ili9341_fops);
 
 static struct drm_driver ili9341_driver = {
@@ -155,25 +159,32 @@ static struct drm_driver ili9341_driver = {
 };
 
 static const struct of_device_id ili9341_of_match[] = {
-	{ .compatible = "adafruit,yx240qv29" },
+	{ .compatible = "adafruit,yx240qv29", .data = &yx240qv29_mode },
+	{ .compatible = "adafruit,dt280qv10", .data = &dt280qv10_mode },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, ili9341_of_match);
 
 static const struct spi_device_id ili9341_id[] = {
-	{ "yx240qv29", 0 },
+	{ "yx240qv29", (kernel_ulong_t)&yx240qv29_mode },
+	{ "dt280qv10", (kernel_ulong_t)&dt280qv10_mode },
 	{ }
 };
 MODULE_DEVICE_TABLE(spi, ili9341_id);
 
 static int ili9341_probe(struct spi_device *spi)
 {
+	const struct drm_display_mode *mode;
 	struct device *dev = &spi->dev;
 	struct mipi_dbi *mipi;
 	struct gpio_desc *dc;
 	u32 rotation = 0;
 	int ret;
 
+	mode = device_get_match_data(dev);
+	if (!mode)
+		return -ENODEV;
+
 	mipi = devm_kzalloc(dev, sizeof(*mipi), GFP_KERNEL);
 	if (!mipi)
 		return -ENOMEM;
@@ -201,7 +212,7 @@ static int ili9341_probe(struct spi_device *spi)
 		return ret;
 
 	ret = mipi_dbi_init(&spi->dev, mipi, &ili9341_pipe_funcs,
-			    &ili9341_driver, &yx240qv29_mode, rotation);
+			    &ili9341_driver, mode, rotation);
 	if (ret)
 		return ret;
 
-- 
2.20.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

             reply	other threads:[~2019-02-25 14:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-25 14:45 Andy Shevchenko [this message]
2019-02-25 15:07 ` [PATCH v1] drm/tinydrm/ili9341: Support Adafruit 2.8" TFT display Noralf Trønnes
2019-02-26  8:14   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190225144534.29859-1-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=noralf@tronnes.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.