From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: ehci: Cleanup itd/sidt_complete() From: Suwan Kim Message-Id: <20190225155144.17424-1-suwan.kim027@gmail.com> Date: Tue, 26 Feb 2019 00:51:44 +0900 To: stern@rowland.harvard.edu Cc: linux-usb@vger.kernel.org, gregkh@linuxfoundation.org List-ID: VGhpcyBwYXRjaCBtYWtlcyBpdGQvc2l0ZF9jb21wbGV0ZSgpIHVzZSAqYnVzIGluc3RlYWQgb2Yg cmVmZXJlbmluZwplaGNpX3RvX2hjZChlaGNpKS0+c2VsZi4gQW5kIHJlbW92ZSB1bm5lY2Vzc2Fy eSAidXJiID0gTlVMTCIgbGluZXMuCgpTaWduZWQtb2ZmLWJ5OiBTdXdhbiBLaW0gPHN1d2FuLmtp bTAyN0BnbWFpbC5jb20+Ci0tLQogZHJpdmVycy91c2IvaG9zdC9laGNpLXNjaGVkLmMgfCAxOCAr KysrKysrKy0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDEwIGRl bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNiL2hvc3QvZWhjaS1zY2hlZC5jIGIv ZHJpdmVycy91c2IvaG9zdC9laGNpLXNjaGVkLmMKaW5kZXggZGE3YjAwYTYxMTBiLi40MTg4MjVi ZDk0ZmQgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvdXNiL2hvc3QvZWhjaS1zY2hlZC5jCisrKyBiL2Ry aXZlcnMvdXNiL2hvc3QvZWhjaS1zY2hlZC5jCkBAIC0xODM2LDYgKzE4MzYsNyBAQCBzdGF0aWMg Ym9vbCBpdGRfY29tcGxldGUoc3RydWN0IGVoY2lfaGNkICplaGNpLCBzdHJ1Y3QgZWhjaV9pdGQg Kml0ZCkKIAlpbnQJCQkJCXVyYl9pbmRleCA9IC0xOwogCXN0cnVjdCBlaGNpX2lzb19zdHJlYW0J CQkqc3RyZWFtID0gaXRkLT5zdHJlYW07CiAJYm9vbAkJCQkJcmV0dmFsID0gZmFsc2U7CisJc3Ry dWN0IHVzYl9idXMJCQkqYnVzID0gJmVoY2lfdG9faGNkKGVoY2kpLT5zZWxmOwogCiAJLyogZm9y IGVhY2ggdWZyYW1lIHdpdGggYSBwYWNrZXQgKi8KIAlmb3IgKHVmcmFtZSA9IDA7IHVmcmFtZSA8 IDg7IHVmcmFtZSsrKSB7CkBAIC0xODg3LDIwICsxODg4LDE4IEBAIHN0YXRpYyBib29sIGl0ZF9j b21wbGV0ZShzdHJ1Y3QgZWhjaV9oY2QgKmVoY2ksIHN0cnVjdCBlaGNpX2l0ZCAqaXRkKQogCS8q IGdpdmUgdXJiIGJhY2sgdG8gdGhlIGRyaXZlcjsgY29tcGxldGlvbiBvZnRlbiAocmUpc3VibWl0 cyAqLwogCWVoY2lfdXJiX2RvbmUoZWhjaSwgdXJiLCAwKTsKIAlyZXR2YWwgPSB0cnVlOwotCXVy YiA9IE5VTEw7CiAKIAktLWVoY2ktPmlzb2NfY291bnQ7CiAJZGlzYWJsZV9wZXJpb2RpYyhlaGNp KTsKIAotCWVoY2lfdG9faGNkKGVoY2kpLT5zZWxmLmJhbmR3aWR0aF9pc29jX3JlcXMtLTsKLQlp ZiAoZWhjaV90b19oY2QoZWhjaSktPnNlbGYuYmFuZHdpZHRoX2lzb2NfcmVxcyA9PSAwKSB7CisJ YnVzLT5iYW5kd2lkdGhfaXNvY19yZXFzLS07CisJaWYgKGJ1cy0+YmFuZHdpZHRoX2lzb2NfcmVx cyA9PSAwKSB7CiAJCWlmIChlaGNpLT5hbWRfcGxsX2ZpeCA9PSAxKQogCQkJdXNiX2FtZF9xdWly a19wbGxfZW5hYmxlKCk7CiAJfQogCiAJaWYgKHVubGlrZWx5KGxpc3RfaXNfc2luZ3VsYXIoJnN0 cmVhbS0+dGRfbGlzdCkpKQotCQllaGNpX3RvX2hjZChlaGNpKS0+c2VsZi5iYW5kd2lkdGhfYWxs b2NhdGVkCi0JCQkJLT0gc3RyZWFtLT5iYW5kd2lkdGg7CisJCWJ1cy0+YmFuZHdpZHRoX2FsbG9j YXRlZCAtPSBzdHJlYW0tPmJhbmR3aWR0aDsKIAogZG9uZToKIAlpdGQtPnVyYiA9IE5VTEw7CkBA IC0yMjI5LDYgKzIyMjgsNyBAQCBzdGF0aWMgYm9vbCBzaXRkX2NvbXBsZXRlKHN0cnVjdCBlaGNp X2hjZCAqZWhjaSwgc3RydWN0IGVoY2lfc2l0ZCAqc2l0ZCkKIAlpbnQJCQkJCXVyYl9pbmRleDsK IAlzdHJ1Y3QgZWhjaV9pc29fc3RyZWFtCQkJKnN0cmVhbSA9IHNpdGQtPnN0cmVhbTsKIAlib29s CQkJCQlyZXR2YWwgPSBmYWxzZTsKKwlzdHJ1Y3QgdXNiX2J1cwkJCSpidXMgPSAmZWhjaV90b19o Y2QoZWhjaSktPnNlbGY7CiAKIAl1cmJfaW5kZXggPSBzaXRkLT5pbmRleDsKIAlkZXNjID0gJnVy Yi0+aXNvX2ZyYW1lX2Rlc2NbdXJiX2luZGV4XTsKQEAgLTIyNjcsMjAgKzIyNjcsMTggQEAgc3Rh dGljIGJvb2wgc2l0ZF9jb21wbGV0ZShzdHJ1Y3QgZWhjaV9oY2QgKmVoY2ksIHN0cnVjdCBlaGNp X3NpdGQgKnNpdGQpCiAJLyogZ2l2ZSB1cmIgYmFjayB0byB0aGUgZHJpdmVyOyBjb21wbGV0aW9u IG9mdGVuIChyZSlzdWJtaXRzICovCiAJZWhjaV91cmJfZG9uZShlaGNpLCB1cmIsIDApOwogCXJl dHZhbCA9IHRydWU7Ci0JdXJiID0gTlVMTDsKIAogCS0tZWhjaS0+aXNvY19jb3VudDsKIAlkaXNh YmxlX3BlcmlvZGljKGVoY2kpOwogCi0JZWhjaV90b19oY2QoZWhjaSktPnNlbGYuYmFuZHdpZHRo X2lzb2NfcmVxcy0tOwotCWlmIChlaGNpX3RvX2hjZChlaGNpKS0+c2VsZi5iYW5kd2lkdGhfaXNv Y19yZXFzID09IDApIHsKKwlidXMtPmJhbmR3aWR0aF9pc29jX3JlcXMtLTsKKwlpZiAoYnVzLT5i YW5kd2lkdGhfaXNvY19yZXFzID09IDApIHsKIAkJaWYgKGVoY2ktPmFtZF9wbGxfZml4ID09IDEp CiAJCQl1c2JfYW1kX3F1aXJrX3BsbF9lbmFibGUoKTsKIAl9CiAKIAlpZiAobGlzdF9pc19zaW5n dWxhcigmc3RyZWFtLT50ZF9saXN0KSkKLQkJZWhjaV90b19oY2QoZWhjaSktPnNlbGYuYmFuZHdp ZHRoX2FsbG9jYXRlZAotCQkJCS09IHN0cmVhbS0+YmFuZHdpZHRoOworCQlidXMtPmJhbmR3aWR0 aF9hbGxvY2F0ZWQgLT0gc3RyZWFtLT5iYW5kd2lkdGg7CiAKIGRvbmU6CiAJc2l0ZC0+dXJiID0g TlVMTDsK