All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Bhanusree Pola <bhanusreemahesh@gmail.com>,
	outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v2 2/2] Staging: mt7621_dma: Prefer unsigned int over just unsigned
Date: Mon, 25 Feb 2019 16:58:06 +0100	[thread overview]
Message-ID: <20190225155806.GA13948@kroah.com> (raw)
In-Reply-To: <2612cbd8-3632-a6f6-6b59-4b906326050e@gmail.com>

On Mon, Feb 25, 2019 at 04:02:00PM +0100, Matthias Brugger wrote:
> 
> 
> On 25/02/2019 15:49, Bhanusree Pola wrote:
> > Replace 'unsigned' with 'unsigned int' to be specific with data type.
> > Issue found with checkpatch.pl
> > 
> > Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
> > ---
> >  drivers/staging/mt7621-dma/mtk-hsdma.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
> > index 20c8879d4979..7b2cdd2829a5 100644
> > --- a/drivers/staging/mt7621-dma/mtk-hsdma.c
> > +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
> > @@ -191,7 +191,7 @@ static inline u32 mtk_hsdma_read(struct mtk_hsdam_engine *hsdma, u32 reg)
> >  }
> >  
> >  static inline void mtk_hsdma_write(struct mtk_hsdam_engine *hsdma,
> > -				   unsigned reg, u32 val)
> > +				   unsigned int reg, u32 val)
> 
> You could align to the open paranthesis as well?

No, please only one type of change per patch.

thanks,

greg k-h


      reply	other threads:[~2019-02-25 15:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-25 14:49 [PATCH v2 0/2] Staging: mt7621-dma: Fix checkpatch issues Bhanusree Pola
2019-02-25 14:49 ` [PATCH v2 1/2] Staging: mt761-dma: Alignment should match open paranthesis Bhanusree Pola
2019-02-25 15:00   ` Matthias Brugger
2019-02-25 14:49 ` [PATCH v2 2/2] Staging: mt7621_dma: Prefer unsigned int over just unsigned Bhanusree Pola
2019-02-25 15:02   ` Matthias Brugger
2019-02-25 15:58     ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190225155806.GA13948@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=bhanusreemahesh@gmail.com \
    --cc=matthias.bgg@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.