From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:34224) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyJP8-0003LI-Ke for qemu-devel@nongnu.org; Mon, 25 Feb 2019 11:47:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gyJP0-0007UM-02 for qemu-devel@nongnu.org; Mon, 25 Feb 2019 11:46:52 -0500 Date: Mon, 25 Feb 2019 16:46:31 +0000 From: Anthony PERARD Message-ID: <20190225164631.GE1349@perard.uk.xensource.com> References: <20190219163440.15702-1-paul.durrant@citrix.com> <9510cf48c9064c0fb1e6eb64b414a7ea@AMSPEX02CL03.citrite.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <9510cf48c9064c0fb1e6eb64b414a7ea@AMSPEX02CL03.citrite.net> Subject: Re: [Qemu-devel] [PATCH] xen-block: stop leaking memory in xen_block_drive_create() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Durrant Cc: "qemu-block@nongnu.org" , "xen-devel@lists.xenproject.org" , "qemu-devel@nongnu.org" , Peter Maydell , Stefano Stabellini , Kevin Wolf , Max Reitz On Tue, Feb 19, 2019 at 04:36:28PM +0000, Paul Durrant wrote: > > The locally allocated QDict-s need to be freed. ('file_layer' will be > > freed implicitly since it is added as an object to 'driver_layer'). > > > > Spotted by Coverity: CID 1398649 > > > > While in the neighbourhood free 'driver' and 'filename' as soon as they > > are > > added to the QDicts. Freeing after the 'done' label doesn't make that much > > sense as, if the error path jumps to that label, the values would be NULL > > anyway. > > > > This patch also makes that more obvious by taking the error path if > > 'params' is NULL and then asserting that both driver and filename are > > non-NULL in the normal path. > > > > Reported-by: Peter Maydell > > Signed-off-by: Paul Durrant Acked-by: Anthony PERARD Thanks, -- Anthony PERARD From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony PERARD Subject: Re: [PATCH] xen-block: stop leaking memory in xen_block_drive_create() Date: Mon, 25 Feb 2019 16:46:31 +0000 Message-ID: <20190225164631.GE1349@perard.uk.xensource.com> References: <20190219163440.15702-1-paul.durrant@citrix.com> <9510cf48c9064c0fb1e6eb64b414a7ea@AMSPEX02CL03.citrite.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gyJOp-0007ye-Ra for xen-devel@lists.xenproject.org; Mon, 25 Feb 2019 16:46:39 +0000 Content-Disposition: inline In-Reply-To: <9510cf48c9064c0fb1e6eb64b414a7ea@AMSPEX02CL03.citrite.net> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Paul Durrant Cc: Kevin Wolf , Peter Maydell , Stefano Stabellini , "qemu-block@nongnu.org" , "qemu-devel@nongnu.org" , Max Reitz , "xen-devel@lists.xenproject.org" List-Id: xen-devel@lists.xenproject.org T24gVHVlLCBGZWIgMTksIDIwMTkgYXQgMDQ6MzY6MjhQTSArMDAwMCwgUGF1bCBEdXJyYW50IHdy b3RlOgo+ID4gVGhlIGxvY2FsbHkgYWxsb2NhdGVkIFFEaWN0LXMgbmVlZCB0byBiZSBmcmVlZC4g KCdmaWxlX2xheWVyJyB3aWxsIGJlCj4gPiBmcmVlZCBpbXBsaWNpdGx5IHNpbmNlIGl0IGlzIGFk ZGVkIGFzIGFuIG9iamVjdCB0byAnZHJpdmVyX2xheWVyJykuCj4gPiAKPiA+IFNwb3R0ZWQgYnkg Q292ZXJpdHk6IENJRCAxMzk4NjQ5Cj4gPiAKPiA+IFdoaWxlIGluIHRoZSBuZWlnaGJvdXJob29k IGZyZWUgJ2RyaXZlcicgYW5kICdmaWxlbmFtZScgYXMgc29vbiBhcyB0aGV5Cj4gPiBhcmUKPiA+ IGFkZGVkIHRvIHRoZSBRRGljdHMuIEZyZWVpbmcgYWZ0ZXIgdGhlICdkb25lJyBsYWJlbCBkb2Vz bid0IG1ha2UgdGhhdCBtdWNoCj4gPiBzZW5zZSBhcywgaWYgdGhlIGVycm9yIHBhdGgganVtcHMg dG8gdGhhdCBsYWJlbCwgdGhlIHZhbHVlcyB3b3VsZCBiZSBOVUxMCj4gPiBhbnl3YXkuCj4gPiAK PiA+IFRoaXMgcGF0Y2ggYWxzbyBtYWtlcyB0aGF0IG1vcmUgb2J2aW91cyBieSB0YWtpbmcgdGhl IGVycm9yIHBhdGggaWYKPiA+ICdwYXJhbXMnIGlzIE5VTEwgYW5kIHRoZW4gYXNzZXJ0aW5nIHRo YXQgYm90aCBkcml2ZXIgYW5kIGZpbGVuYW1lIGFyZQo+ID4gbm9uLU5VTEwgaW4gdGhlIG5vcm1h bCBwYXRoLgo+ID4gCj4gPiBSZXBvcnRlZC1ieTogUGV0ZXIgTWF5ZGVsbCA8cGV0ZXIubWF5ZGVs bEBsaW5hcm8ub3JnPgo+ID4gU2lnbmVkLW9mZi1ieTogUGF1bCBEdXJyYW50IDxwYXVsLmR1cnJh bnRAY2l0cml4LmNvbT4KCkFja2VkLWJ5OiBBbnRob255IFBFUkFSRCA8YW50aG9ueS5wZXJhcmRA Y2l0cml4LmNvbT4KClRoYW5rcywKCi0tIApBbnRob255IFBFUkFSRAoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApY ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==