From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59F7AC43381 for ; Mon, 25 Feb 2019 18:04:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 23B7E2084D for ; Mon, 25 Feb 2019 18:04:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MMxv0Zwa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728764AbfBYSE1 (ORCPT ); Mon, 25 Feb 2019 13:04:27 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:36147 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726225AbfBYSE0 (ORCPT ); Mon, 25 Feb 2019 13:04:26 -0500 Received: by mail-pf1-f195.google.com with SMTP id n22so4857151pfa.3 for ; Mon, 25 Feb 2019 10:04:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=dcepraz+jDBfSU/RdV1+9Tq5y9c+olhXVqDsyrkdI/k=; b=MMxv0Zwa6FKocZ6+O0nKfMBTxNXNBZfNMbli19xyQAakEqovjbHIwrJZLfUDzMiaWQ HP5WdGycv+m5coVVfcwahPuv/z9a/vlpkq3AjU6JFTnE+JSRbHTtUvPvSfZoX7VkyZKJ TL+Vgd+QDiyDzWnuxCjEoRt6Z/xBQwkhmnMozGS4bJxLH+SWS85kNNDyIII6e4zmFEMD AKdAoTocTDmHmR6ivzf30TvfWv9TVmuEqtom/RCKhsZ7aV6RQLyB58fNe62VPsau8vCq GdINy/H/HS8cOvFvNZ2A82G1P9xR+Zd2dTnDjjqLVHDcOkansfsQeCr+OiegfFPLk+qj DpCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=dcepraz+jDBfSU/RdV1+9Tq5y9c+olhXVqDsyrkdI/k=; b=msncawjHtks/MwkCklXIgVHjoHM470VSUCVHJyOXff09hZQk/vjxcyP6qLGhDubCWs VucZ6V6hQIEa43GqZYf9CA4i6uT6kzj3g3iWdKcXYvblUIu3hMuWS78bgKK6Q0TSyE65 tlOjIwFMJvQYNV2i3oBSVP+2qbAhyC7/bYUTjX/yqgW9Qu5W5N1iWeMXRffSDDUs3Y2+ nD6Ve5AnbaXlbdS8oWJcN8Hy1g+JaQPQLtZ7845kqAt3kQhjO9ptPz+ObcG0UUw2wcSz E1NHQYxry7G5QUrJuqZbRKqqcvXA0gRpbg+WEfkD6zNoGvuviHkhJ7qIzMzrb1KbhjMX RTHQ== X-Gm-Message-State: AHQUAuY9yTTmDgtGXwXPWd8xO4jBlGUQNoY15LkgAw34zV/tKvXQ0q1s +4yVTDJUVito4ZmL15SzXrUKYhf4+UA= X-Google-Smtp-Source: AHgI3Iaj9ZNfCdGNHZgxx/e/ZUwoqIk6SVFXMZe39vW6uKjyKhpRoEeo61/T95igONBKloHJwi2HMQ== X-Received: by 2002:a63:1cd:: with SMTP id 196mr20463551pgb.58.1551117866084; Mon, 25 Feb 2019 10:04:26 -0800 (PST) Received: from Inspiron-3521 ([106.216.180.155]) by smtp.gmail.com with ESMTPSA id e6sm22055067pfe.59.2019.02.25.10.04.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 Feb 2019 10:04:25 -0800 (PST) Date: Mon, 25 Feb 2019 23:34:18 +0530 From: Leslie Monis To: David Miller Cc: netdev@vger.kernel.org Subject: Re: [PATCH net-next v2 5/7] net: sched: pie: add more cases to auto-tune alpha and beta Message-ID: <20190225180418.GA17596@Inspiron-3521> References: <20190225102051.12268-1-lesliemonis@gmail.com> <20190225102051.12268-6-lesliemonis@gmail.com> <20190225.094038.1156384775297802527.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190225.094038.1156384775297802527.davem@davemloft.net> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Feb 25, 2019 at 09:40:38AM -0800, David Miller wrote: > From: Leslie Monis > Date: Mon, 25 Feb 2019 15:50:49 +0530 > > > + power = 100; > > + while (q->vars.prob < MAX_PROB / (u64)power && > > You have to use div_u64() or similar when doing 64-bit divisons otherwise > you'll get build failures on 32-bit platforms. Alright. Thanks for the feedback.