From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 158CEC43381 for ; Mon, 25 Feb 2019 22:01:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C554D2146F for ; Mon, 25 Feb 2019 22:01:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551132118; bh=u2G7e/adIdwTpYmQkU8eI3u+Mp2iix7NP69Ri8HaS1M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=xS2SKzw2q4XPymF47Oo4XdwAxg3pn5l02ls7SG9fu2LMZK8VIUu3Ma5jEs/RPaYxh CfNSayWXdJFFdvq/GD3YhUpArnGVBYbv3dWiv3IQczJT64LzV3iTpdH563Up3JHx7C Wq9lts2kh4/oRRT/rEZybTwx56wGjgpMx7k01CFs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729711AbfBYVQX (ORCPT ); Mon, 25 Feb 2019 16:16:23 -0500 Received: from mail.kernel.org ([198.145.29.99]:47986 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729241AbfBYVQU (ORCPT ); Mon, 25 Feb 2019 16:16:20 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C18662147C; Mon, 25 Feb 2019 21:16:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551129380; bh=u2G7e/adIdwTpYmQkU8eI3u+Mp2iix7NP69Ri8HaS1M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NI1A05Sb91mPH5Kc4ou+O371Dv5K57L1XTkR9ZDa1w1Ao0gn9rJ024cKWvGypXbce pWvXtunZUtT5azKTTJ7sfo1Hu5aYWQkP/Wo09eBUqWafiX05E5VDSG7AoP40pMAPSI UvoEozHk/dDUm28Yp8zAu2mSpvLr9Ow7U5w7vuMo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nathan Chancellor , Lee Jones , Sasha Levin Subject: [PATCH 4.14 13/71] mfd: twl-core: Fix section annotations on {,un}protect_pm_master Date: Mon, 25 Feb 2019 22:11:15 +0100 Message-Id: <20190225195035.533226800@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190225195034.555044862@linuxfoundation.org> References: <20190225195034.555044862@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 8838555089f0345b87f4277fe5a8dd647dc65589 ] When building the kernel with Clang, the following section mismatch warning appears: WARNING: vmlinux.o(.text+0x3d84a3b): Section mismatch in reference from the function twl_probe() to the function .init.text:unprotect_pm_master() The function twl_probe() references the function __init unprotect_pm_master(). This is often because twl_probe lacks a __init annotation or the annotation of unprotect_pm_master is wrong. Remove the __init annotation on the *protect_pm_master functions so there is no more mismatch. Signed-off-by: Nathan Chancellor Signed-off-by: Lee Jones Signed-off-by: Sasha Levin --- drivers/mfd/twl-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c index d3133a371e277..8f993272901d5 100644 --- a/drivers/mfd/twl-core.c +++ b/drivers/mfd/twl-core.c @@ -979,7 +979,7 @@ add_children(struct twl4030_platform_data *pdata, unsigned irq_base, * letting it generate the right frequencies for USB, MADC, and * other purposes. */ -static inline int __init protect_pm_master(void) +static inline int protect_pm_master(void) { int e = 0; @@ -988,7 +988,7 @@ static inline int __init protect_pm_master(void) return e; } -static inline int __init unprotect_pm_master(void) +static inline int unprotect_pm_master(void) { int e = 0; -- 2.19.1