From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5E24C43381 for ; Mon, 25 Feb 2019 21:16:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 95EB72147C for ; Mon, 25 Feb 2019 21:16:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551129416; bh=1iCstFPUDggvk5a0cyo6/KlmoM/PkzwqqCGW9lBYF4w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=JSEwZJEPsBiO9gf5sfdAdyjMnWk4wjxFg8MuIHlCiFSNlYAh4QUp76cZy3esm5Lc+ L8Adh3MvWmCmN3bjkLh1AC54rOERab0ix87/U8pBCUmlcJMmi9+fneT+FiSCDS9Ilz T/0dFn9bH5uS5EVPWA6/La6ZiReyxPjFOE1uuNPw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729813AbfBYVQz (ORCPT ); Mon, 25 Feb 2019 16:16:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:48650 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729798AbfBYVQt (ORCPT ); Mon, 25 Feb 2019 16:16:49 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E6B212147C; Mon, 25 Feb 2019 21:16:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551129408; bh=1iCstFPUDggvk5a0cyo6/KlmoM/PkzwqqCGW9lBYF4w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nuIkwT8A4yupWhQtvYRk8HquJ280Zm762bOFHCeWD1HRHHqx4t6rPW77y83E5St9d 3VMkcWo3V9dPQOzvIbyHMq5sMvxTVCT0fJB7M4Ppj6TnytaDN/rwu5IUljfOefGHgR kCDQRJW5gh1mY6QmIlPUGCiw782sLh0/9rmpjnB8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kangjie Lu , Lee Jones , Sasha Levin Subject: [PATCH 4.14 21/71] mfd: mc13xxx: Fix a missing check of a register-read failure Date: Mon, 25 Feb 2019 22:11:23 +0100 Message-Id: <20190225195036.110282216@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190225195034.555044862@linuxfoundation.org> References: <20190225195034.555044862@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 9e28989d41c0eab57ec0bb156617a8757406ff8a ] When mc13xxx_reg_read() fails, "old_adc0" is uninitialized and will contain random value. Further execution uses "old_adc0" even when mc13xxx_reg_read() fails. The fix checks the return value of mc13xxx_reg_read(), and exits the execution when it fails. Signed-off-by: Kangjie Lu Signed-off-by: Lee Jones Signed-off-by: Sasha Levin --- drivers/mfd/mc13xxx-core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/mc13xxx-core.c b/drivers/mfd/mc13xxx-core.c index d7f54e492aa61..6c16f170529f5 100644 --- a/drivers/mfd/mc13xxx-core.c +++ b/drivers/mfd/mc13xxx-core.c @@ -274,7 +274,9 @@ int mc13xxx_adc_do_conversion(struct mc13xxx *mc13xxx, unsigned int mode, mc13xxx->adcflags |= MC13XXX_ADC_WORKING; - mc13xxx_reg_read(mc13xxx, MC13XXX_ADC0, &old_adc0); + ret = mc13xxx_reg_read(mc13xxx, MC13XXX_ADC0, &old_adc0); + if (ret) + goto out; adc0 = MC13XXX_ADC0_ADINC1 | MC13XXX_ADC0_ADINC2; adc1 = MC13XXX_ADC1_ADEN | MC13XXX_ADC1_ADTRIGIGN | MC13XXX_ADC1_ASC; -- 2.19.1