From: Suwan Kim <suwan.kim027@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: stern@rowland.harvard.edu, linux-usb@vger.kernel.org
Subject: usb: ehci: Cleanup itd/sidt_complete()
Date: Tue, 26 Feb 2019 12:17:38 +0900 [thread overview]
Message-ID: <20190226031737.GA3003@localhost.localdomain> (raw)
On Mon, Feb 25, 2019 at 05:41:45PM +0100, Greg KH wrote:
> On Tue, Feb 26, 2019 at 12:51:44AM +0900, Suwan Kim wrote:
> > This patch makes itd/sitd_complete() use *bus instead of referening
> > ehci_to_hcd(ehci)->self. And remove unnecessary "urb = NULL" lines.
>
> That is two different things to do in the same patch, please break this
> up into different patches.
Sorry. I will break it up and send separate patches.
> And when you do, say _why_ you are making these changes, not just a
> description of the change itself. We can read the patch to see what it
> does, but we do not know why you want to do this.
>
> thanks,
>
> greg k-h
Ok, you are right. My description is very short. I will rewrite the
description including why i do this and resend v2.
Regards
Suwan Kim
next reply other threads:[~2019-02-26 3:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 3:17 Suwan Kim [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-02-25 16:41 usb: ehci: Cleanup itd/sidt_complete() Greg Kroah-Hartman
2019-02-25 15:51 Suwan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190226031737.GA3003@localhost.localdomain \
--to=suwan.kim027@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.