* [PATCH] staging: wilc1000: fix incorrect type in initializer
@ 2019-02-26 6:00 Bo YU
[not found] ` <CAKq8=3L5tQNuB1EBjp4osZk83XBX48aWtPN7YiB0sbCg+j6q9g@mail.gmail.com>
0 siblings, 1 reply; 2+ messages in thread
From: Bo YU @ 2019-02-26 6:00 UTC (permalink / raw)
To: adham.abozaeid, ajay.kathat, gregkh, yuzibode; +Cc: Bo YU, devel, linux-kernel
Fix sparse warning following:
drivers/staging/wilc1000/host_interface.c:444:49: warning: incorrect type in initializer (different address spaces)
drivers/staging/wilc1000/host_interface.c:444:49: expected struct cfg80211_bss_ies const *ies
drivers/staging/wilc1000/host_interface.c:444:49: got struct cfg80211_bss_ies const [noderef] <asn:4> *ies
Signed-off-by: Bo YU <tsu.yubo@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index cdcb52aec779..89ae22d40f71 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -441,7 +441,7 @@ void *wilc_parse_join_bss_param(struct cfg80211_bss *bss,
const u8 *tim_elm, *ssid_elm, *rates_ie, *supp_rates_ie;
const u8 *ht_ie, *wpa_ie, *wmm_ie, *rsn_ie;
int ret;
- const struct cfg80211_bss_ies *ies = bss->ies;
+ const struct cfg80211_bss_ies *ies = rcu_dereference(bss->ies);
param = kzalloc(sizeof(*param), GFP_KERNEL);
if (!param)
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: wilc1000: fix incorrect type in initializer
[not found] ` <CAKq8=3L5tQNuB1EBjp4osZk83XBX48aWtPN7YiB0sbCg+j6q9g@mail.gmail.com>
@ 2019-02-26 11:59 ` Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Kroah-Hartman @ 2019-02-26 11:59 UTC (permalink / raw)
To: Bo YU
Cc: adham.abozaeid, ajay.kathat, 于波,
open list:STAGING SUBSYSTEM, open list
On Tue, Feb 26, 2019 at 07:29:56PM +0800, Bo YU wrote:
> On Tue, Feb 26, 2019 at 2:00 PM Bo YU <tsu.yubo@gmail.com> wrote:
>
> > Fix sparse warning following:
> >
> > drivers/staging/wilc1000/host_interface.c:444:49: warning: incorrect type
> > in initializer (different address spaces)
> > drivers/staging/wilc1000/host_interface.c:444:49: expected struct
> > cfg80211_bss_ies const *ies
> > drivers/staging/wilc1000/host_interface.c:444:49: got struct
> > cfg80211_bss_ies const [noderef] <asn:4> *ies
> >
> > Signed-off-by: Bo YU <tsu.yubo@gmail.com>
> > ---
> > drivers/staging/wilc1000/host_interface.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/wilc1000/host_interface.c
> > b/drivers/staging/wilc1000/host_interface.c
> > index cdcb52aec779..89ae22d40f71 100644
> > --- a/drivers/staging/wilc1000/host_interface.c
> > +++ b/drivers/staging/wilc1000/host_interface.c
> > @@ -441,7 +441,7 @@ void *wilc_parse_join_bss_param(struct cfg80211_bss
> > *bss,
> > const u8 *tim_elm, *ssid_elm, *rates_ie, *supp_rates_ie;
> > const u8 *ht_ie, *wpa_ie, *wmm_ie, *rsn_ie;
> > int ret;
> > - const struct cfg80211_bss_ies *ies = bss->ies;
> > + const struct cfg80211_bss_ies *ies = rcu_dereference(bss->ies);
> >
> > param = kzalloc(sizeof(*param), GFP_KERNEL);
> > if (!param)
> > --
> > 2.11.0
> >
> > Hi,
> I do not Ccing wireless-list, Does it matter?
It would be nice to do that in the future.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-26 11:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-26 6:00 [PATCH] staging: wilc1000: fix incorrect type in initializer Bo YU
[not found] ` <CAKq8=3L5tQNuB1EBjp4osZk83XBX48aWtPN7YiB0sbCg+j6q9g@mail.gmail.com>
2019-02-26 11:59 ` Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.