From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove_device() Date: Tue, 26 Feb 2019 11:56:15 +0100 Message-ID: <20190226105615.GA12397@kroah.com> References: <20190224153622.8877-1-digetx@gmail.com> <20190225080715.4965810a@dimatab> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20190225080715.4965810a@dimatab> Sender: linux-kernel-owner@vger.kernel.org To: Dmitry Osipenko Cc: Peter Chen , Thierry Reding , Jonathan Hunter , "linux-usb@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-Id: linux-tegra@vger.kernel.org On Mon, Feb 25, 2019 at 08:07:15AM +0300, Dmitry Osipenko wrote: > В Mon, 25 Feb 2019 02:27:19 +0000 > Peter Chen пишет: > > > > > > > > > Fixes: dfebb5f43a78827a ("usb: chipidea: Add support for > > > Tegra20/30/114/124") > > > > I suppose you need to apply at stable tree too, right? > > > > It is enough to have the "Fixes" tag to get patch backported into all > relevant kernel versions. No it is not. My scripts do NOT trigger off of the fixes: tag, please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly. > > > Signed-off-by: Dmitry Osipenko > > > --- > > > drivers/usb/chipidea/ci_hdrc_tegra.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/usb/chipidea/ci_hdrc_tegra.c > > > b/drivers/usb/chipidea/ci_hdrc_tegra.c > > > index 772851bee99b..12025358bb3c 100644 > > > --- a/drivers/usb/chipidea/ci_hdrc_tegra.c > > > +++ b/drivers/usb/chipidea/ci_hdrc_tegra.c > > > @@ -130,6 +130,7 @@ static int tegra_udc_remove(struct > > > platform_device *pdev) { > > > struct tegra_udc *udc = platform_get_drvdata(pdev); > > > > > > + ci_hdrc_remove_device(udc->dev); > > > usb_phy_set_suspend(udc->phy, 1); > > > clk_disable_unprepare(udc->clk); > > > > > > > Acked-by: Peter Chen > > > > Hi Greg, would you still accept the bug-fix for this release (v5.0)? > > Or I send you later? I can pick it up now, thanks. greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove_device() From: Greg Kroah-Hartman Message-Id: <20190226105615.GA12397@kroah.com> Date: Tue, 26 Feb 2019 11:56:15 +0100 To: Dmitry Osipenko Cc: Peter Chen , Thierry Reding , Jonathan Hunter , "linux-usb@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-ID: T24gTW9uLCBGZWIgMjUsIDIwMTkgYXQgMDg6MDc6MTVBTSArMDMwMCwgRG1pdHJ5IE9zaXBlbmtv IHdyb3RlOgo+INCSIE1vbiwgMjUgRmViIDIwMTkgMDI6Mjc6MTkgKzAwMDAKPiBQZXRlciBDaGVu IDxwZXRlci5jaGVuQG54cC5jb20+INC/0LjRiNC10YI6Cj4gCj4gPiAgCj4gPiA+IAo+ID4gPiBG aXhlczogZGZlYmI1ZjQzYTc4ODI3YSAoInVzYjogY2hpcGlkZWE6IEFkZCBzdXBwb3J0IGZvcgo+ ID4gPiBUZWdyYTIwLzMwLzExNC8xMjQiKSAgCj4gPiAKPiA+IEkgc3VwcG9zZSB5b3UgbmVlZCB0 byBhcHBseSBhdCBzdGFibGUgdHJlZSB0b28sIHJpZ2h0Pwo+ID4gCj4gCj4gSXQgaXMgZW5vdWdo IHRvIGhhdmUgdGhlICJGaXhlcyIgdGFnIHRvIGdldCBwYXRjaCBiYWNrcG9ydGVkIGludG8gYWxs Cj4gcmVsZXZhbnQga2VybmVsIHZlcnNpb25zLgoKTm8gaXQgaXMgbm90LiAgTXkgc2NyaXB0cyBk byBOT1QgdHJpZ2dlciBvZmYgb2YgdGhlIGZpeGVzOiB0YWcsIHBsZWFzZQpyZWFkOgogICAgaHR0 cHM6Ly93d3cua2VybmVsLm9yZy9kb2MvaHRtbC9sYXRlc3QvcHJvY2Vzcy9zdGFibGUta2VybmVs LXJ1bGVzLmh0bWwKZm9yIGhvdyB0byBkbyB0aGlzIHByb3Blcmx5LgoKCj4gPiA+IFNpZ25lZC1v ZmYtYnk6IERtaXRyeSBPc2lwZW5rbyA8ZGlnZXR4QGdtYWlsLmNvbT4KPiA+ID4gLS0tCj4gPiA+ ICBkcml2ZXJzL3VzYi9jaGlwaWRlYS9jaV9oZHJjX3RlZ3JhLmMgfCAxICsKPiA+ID4gIDEgZmls ZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKQo+ID4gPiAKPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvdXNiL2NoaXBpZGVhL2NpX2hkcmNfdGVncmEuYwo+ID4gPiBiL2RyaXZlcnMvdXNiL2NoaXBp ZGVhL2NpX2hkcmNfdGVncmEuYwo+ID4gPiBpbmRleCA3NzI4NTFiZWU5OWIuLjEyMDI1MzU4YmIz YyAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy91c2IvY2hpcGlkZWEvY2lfaGRyY190ZWdyYS5j Cj4gPiA+ICsrKyBiL2RyaXZlcnMvdXNiL2NoaXBpZGVhL2NpX2hkcmNfdGVncmEuYwo+ID4gPiBA QCAtMTMwLDYgKzEzMCw3IEBAIHN0YXRpYyBpbnQgdGVncmFfdWRjX3JlbW92ZShzdHJ1Y3QKPiA+ ID4gcGxhdGZvcm1fZGV2aWNlICpwZGV2KSB7Cj4gPiA+ICAJc3RydWN0IHRlZ3JhX3VkYyAqdWRj ID0gcGxhdGZvcm1fZ2V0X2RydmRhdGEocGRldik7Cj4gPiA+IAo+ID4gPiArCWNpX2hkcmNfcmVt b3ZlX2RldmljZSh1ZGMtPmRldik7Cj4gPiA+ICAJdXNiX3BoeV9zZXRfc3VzcGVuZCh1ZGMtPnBo eSwgMSk7Cj4gPiA+ICAJY2xrX2Rpc2FibGVfdW5wcmVwYXJlKHVkYy0+Y2xrKTsKPiA+ID4gICAK PiA+ICAKPiA+IEFja2VkLWJ5OiBQZXRlciBDaGVuIDxwZXRlci5jaGVuQG54cC5jb20+Cj4gPiAK PiA+IEhpIEdyZWcsIHdvdWxkIHlvdSBzdGlsbCBhY2NlcHQgdGhlIGJ1Zy1maXggZm9yIHRoaXMg cmVsZWFzZSAodjUuMCk/Cj4gPiBPciBJIHNlbmQgeW91IGxhdGVyPwoKSSBjYW4gcGljayBpdCB1 cCBub3csIHRoYW5rcy4KCmdyZWcgay1oCg==