* [PATCH v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove_device()
@ 2019-02-24 15:36 ` Dmitry Osipenko
0 siblings, 0 replies; 18+ messages in thread
From: Dmitry Osipenko @ 2019-02-24 15:36 UTC (permalink / raw)
To: Peter Chen, Greg Kroah-Hartman, Thierry Reding, Jonathan Hunter
Cc: linux-usb, linux-tegra, linux-kernel
The ChipIdea's platform device need to be unregistered on Tegra's driver
module removal.
Fixes: dfebb5f43a78827a ("usb: chipidea: Add support for Tegra20/30/114/124")
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
drivers/usb/chipidea/ci_hdrc_tegra.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/chipidea/ci_hdrc_tegra.c b/drivers/usb/chipidea/ci_hdrc_tegra.c
index 772851bee99b..12025358bb3c 100644
--- a/drivers/usb/chipidea/ci_hdrc_tegra.c
+++ b/drivers/usb/chipidea/ci_hdrc_tegra.c
@@ -130,6 +130,7 @@ static int tegra_udc_remove(struct platform_device *pdev)
{
struct tegra_udc *udc = platform_get_drvdata(pdev);
+ ci_hdrc_remove_device(udc->dev);
usb_phy_set_suspend(udc->phy, 1);
clk_disable_unprepare(udc->clk);
--
2.20.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* [v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove_device() @ 2019-02-24 15:36 ` Dmitry Osipenko 0 siblings, 0 replies; 18+ messages in thread From: Dmitry Osipenko @ 2019-02-24 15:36 UTC (permalink / raw) To: Peter Chen, Greg Kroah-Hartman, Thierry Reding, Jonathan Hunter Cc: linux-usb, linux-tegra, linux-kernel The ChipIdea's platform device need to be unregistered on Tegra's driver module removal. Fixes: dfebb5f43a78827a ("usb: chipidea: Add support for Tegra20/30/114/124") Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- drivers/usb/chipidea/ci_hdrc_tegra.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/chipidea/ci_hdrc_tegra.c b/drivers/usb/chipidea/ci_hdrc_tegra.c index 772851bee99b..12025358bb3c 100644 --- a/drivers/usb/chipidea/ci_hdrc_tegra.c +++ b/drivers/usb/chipidea/ci_hdrc_tegra.c @@ -130,6 +130,7 @@ static int tegra_udc_remove(struct platform_device *pdev) { struct tegra_udc *udc = platform_get_drvdata(pdev); + ci_hdrc_remove_device(udc->dev); usb_phy_set_suspend(udc->phy, 1); clk_disable_unprepare(udc->clk); ^ permalink raw reply related [flat|nested] 18+ messages in thread
* RE: [PATCH v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove_device() @ 2019-02-25 2:27 ` Peter Chen 0 siblings, 0 replies; 18+ messages in thread From: Peter Chen @ 2019-02-25 2:27 UTC (permalink / raw) To: Dmitry Osipenko, Greg Kroah-Hartman, Thierry Reding, Jonathan Hunter Cc: linux-usb, linux-tegra, linux-kernel > > Fixes: dfebb5f43a78827a ("usb: chipidea: Add support for Tegra20/30/114/124") I suppose you need to apply at stable tree too, right? > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > drivers/usb/chipidea/ci_hdrc_tegra.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/chipidea/ci_hdrc_tegra.c > b/drivers/usb/chipidea/ci_hdrc_tegra.c > index 772851bee99b..12025358bb3c 100644 > --- a/drivers/usb/chipidea/ci_hdrc_tegra.c > +++ b/drivers/usb/chipidea/ci_hdrc_tegra.c > @@ -130,6 +130,7 @@ static int tegra_udc_remove(struct platform_device *pdev) > { > struct tegra_udc *udc = platform_get_drvdata(pdev); > > + ci_hdrc_remove_device(udc->dev); > usb_phy_set_suspend(udc->phy, 1); > clk_disable_unprepare(udc->clk); > Acked-by: Peter Chen <peter.chen@nxp.com> Hi Greg, would you still accept the bug-fix for this release (v5.0)? Or I send you later? Peter ^ permalink raw reply [flat|nested] 18+ messages in thread
* [v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove_device() @ 2019-02-25 2:27 ` Peter Chen 0 siblings, 0 replies; 18+ messages in thread From: Peter Chen @ 2019-02-25 2:27 UTC (permalink / raw) To: Dmitry Osipenko, Greg Kroah-Hartman, Thierry Reding, Jonathan Hunter Cc: linux-usb, linux-tegra, linux-kernel > > Fixes: dfebb5f43a78827a ("usb: chipidea: Add support for Tegra20/30/114/124") I suppose you need to apply at stable tree too, right? > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > drivers/usb/chipidea/ci_hdrc_tegra.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/chipidea/ci_hdrc_tegra.c > b/drivers/usb/chipidea/ci_hdrc_tegra.c > index 772851bee99b..12025358bb3c 100644 > --- a/drivers/usb/chipidea/ci_hdrc_tegra.c > +++ b/drivers/usb/chipidea/ci_hdrc_tegra.c > @@ -130,6 +130,7 @@ static int tegra_udc_remove(struct platform_device *pdev) > { > struct tegra_udc *udc = platform_get_drvdata(pdev); > > + ci_hdrc_remove_device(udc->dev); > usb_phy_set_suspend(udc->phy, 1); > clk_disable_unprepare(udc->clk); > Acked-by: Peter Chen <peter.chen@nxp.com> Hi Greg, would you still accept the bug-fix for this release (v5.0)? Or I send you later? Peter ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove_device() @ 2019-02-25 5:07 ` Dmitry Osipenko 0 siblings, 0 replies; 18+ messages in thread From: Dmitry Osipenko @ 2019-02-25 5:07 UTC (permalink / raw) To: Peter Chen Cc: Greg Kroah-Hartman, Thierry Reding, Jonathan Hunter, linux-usb, linux-tegra, linux-kernel В Mon, 25 Feb 2019 02:27:19 +0000 Peter Chen <peter.chen@nxp.com> пишет: > > > > > Fixes: dfebb5f43a78827a ("usb: chipidea: Add support for > > Tegra20/30/114/124") > > I suppose you need to apply at stable tree too, right? > It is enough to have the "Fixes" tag to get patch backported into all relevant kernel versions. > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > > --- > > drivers/usb/chipidea/ci_hdrc_tegra.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/usb/chipidea/ci_hdrc_tegra.c > > b/drivers/usb/chipidea/ci_hdrc_tegra.c > > index 772851bee99b..12025358bb3c 100644 > > --- a/drivers/usb/chipidea/ci_hdrc_tegra.c > > +++ b/drivers/usb/chipidea/ci_hdrc_tegra.c > > @@ -130,6 +130,7 @@ static int tegra_udc_remove(struct > > platform_device *pdev) { > > struct tegra_udc *udc = platform_get_drvdata(pdev); > > > > + ci_hdrc_remove_device(udc->dev); > > usb_phy_set_suspend(udc->phy, 1); > > clk_disable_unprepare(udc->clk); > > > > Acked-by: Peter Chen <peter.chen@nxp.com> > > Hi Greg, would you still accept the bug-fix for this release (v5.0)? > Or I send you later? I just want to point out that the bug existed for a very long time and apparently didn't bother anybody, hence it's not an urgent fix. ^ permalink raw reply [flat|nested] 18+ messages in thread
* [v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove_device() @ 2019-02-25 5:07 ` Dmitry Osipenko 0 siblings, 0 replies; 18+ messages in thread From: Dmitry Osipenko @ 2019-02-25 5:07 UTC (permalink / raw) To: Peter Chen Cc: Greg Kroah-Hartman, Thierry Reding, Jonathan Hunter, linux-usb, linux-tegra, linux-kernel В Mon, 25 Feb 2019 02:27:19 +0000 Peter Chen <peter.chen@nxp.com> пишет: > > > > > Fixes: dfebb5f43a78827a ("usb: chipidea: Add support for > > Tegra20/30/114/124") > > I suppose you need to apply at stable tree too, right? > It is enough to have the "Fixes" tag to get patch backported into all relevant kernel versions. > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > > --- > > drivers/usb/chipidea/ci_hdrc_tegra.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/usb/chipidea/ci_hdrc_tegra.c > > b/drivers/usb/chipidea/ci_hdrc_tegra.c > > index 772851bee99b..12025358bb3c 100644 > > --- a/drivers/usb/chipidea/ci_hdrc_tegra.c > > +++ b/drivers/usb/chipidea/ci_hdrc_tegra.c > > @@ -130,6 +130,7 @@ static int tegra_udc_remove(struct > > platform_device *pdev) { > > struct tegra_udc *udc = platform_get_drvdata(pdev); > > > > + ci_hdrc_remove_device(udc->dev); > > usb_phy_set_suspend(udc->phy, 1); > > clk_disable_unprepare(udc->clk); > > > > Acked-by: Peter Chen <peter.chen@nxp.com> > > Hi Greg, would you still accept the bug-fix for this release (v5.0)? > Or I send you later? I just want to point out that the bug existed for a very long time and apparently didn't bother anybody, hence it's not an urgent fix. ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove_device() @ 2019-02-26 10:56 ` Greg Kroah-Hartman 0 siblings, 0 replies; 18+ messages in thread From: Greg Kroah-Hartman @ 2019-02-26 10:56 UTC (permalink / raw) To: Dmitry Osipenko Cc: Peter Chen, Thierry Reding, Jonathan Hunter, linux-usb, linux-tegra, linux-kernel On Mon, Feb 25, 2019 at 08:07:15AM +0300, Dmitry Osipenko wrote: > В Mon, 25 Feb 2019 02:27:19 +0000 > Peter Chen <peter.chen@nxp.com> пишет: > > > > > > > > > Fixes: dfebb5f43a78827a ("usb: chipidea: Add support for > > > Tegra20/30/114/124") > > > > I suppose you need to apply at stable tree too, right? > > > > It is enough to have the "Fixes" tag to get patch backported into all > relevant kernel versions. No it is not. My scripts do NOT trigger off of the fixes: tag, please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly. > > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > > > --- > > > drivers/usb/chipidea/ci_hdrc_tegra.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/usb/chipidea/ci_hdrc_tegra.c > > > b/drivers/usb/chipidea/ci_hdrc_tegra.c > > > index 772851bee99b..12025358bb3c 100644 > > > --- a/drivers/usb/chipidea/ci_hdrc_tegra.c > > > +++ b/drivers/usb/chipidea/ci_hdrc_tegra.c > > > @@ -130,6 +130,7 @@ static int tegra_udc_remove(struct > > > platform_device *pdev) { > > > struct tegra_udc *udc = platform_get_drvdata(pdev); > > > > > > + ci_hdrc_remove_device(udc->dev); > > > usb_phy_set_suspend(udc->phy, 1); > > > clk_disable_unprepare(udc->clk); > > > > > > > Acked-by: Peter Chen <peter.chen@nxp.com> > > > > Hi Greg, would you still accept the bug-fix for this release (v5.0)? > > Or I send you later? I can pick it up now, thanks. greg k-h ^ permalink raw reply [flat|nested] 18+ messages in thread
* [v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove_device() @ 2019-02-26 10:56 ` Greg Kroah-Hartman 0 siblings, 0 replies; 18+ messages in thread From: Greg Kroah-Hartman @ 2019-02-26 10:56 UTC (permalink / raw) To: Dmitry Osipenko Cc: Peter Chen, Thierry Reding, Jonathan Hunter, linux-usb, linux-tegra, linux-kernel On Mon, Feb 25, 2019 at 08:07:15AM +0300, Dmitry Osipenko wrote: > В Mon, 25 Feb 2019 02:27:19 +0000 > Peter Chen <peter.chen@nxp.com> пишет: > > > > > > > > > Fixes: dfebb5f43a78827a ("usb: chipidea: Add support for > > > Tegra20/30/114/124") > > > > I suppose you need to apply at stable tree too, right? > > > > It is enough to have the "Fixes" tag to get patch backported into all > relevant kernel versions. No it is not. My scripts do NOT trigger off of the fixes: tag, please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly. > > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > > > --- > > > drivers/usb/chipidea/ci_hdrc_tegra.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/usb/chipidea/ci_hdrc_tegra.c > > > b/drivers/usb/chipidea/ci_hdrc_tegra.c > > > index 772851bee99b..12025358bb3c 100644 > > > --- a/drivers/usb/chipidea/ci_hdrc_tegra.c > > > +++ b/drivers/usb/chipidea/ci_hdrc_tegra.c > > > @@ -130,6 +130,7 @@ static int tegra_udc_remove(struct > > > platform_device *pdev) { > > > struct tegra_udc *udc = platform_get_drvdata(pdev); > > > > > > + ci_hdrc_remove_device(udc->dev); > > > usb_phy_set_suspend(udc->phy, 1); > > > clk_disable_unprepare(udc->clk); > > > > > > > Acked-by: Peter Chen <peter.chen@nxp.com> > > > > Hi Greg, would you still accept the bug-fix for this release (v5.0)? > > Or I send you later? I can pick it up now, thanks. greg k-h ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove_device() @ 2019-02-26 14:33 ` Dmitry Osipenko 0 siblings, 0 replies; 18+ messages in thread From: Dmitry Osipenko @ 2019-02-26 14:33 UTC (permalink / raw) To: Greg Kroah-Hartman, Joe Perches, Andy Whitcroft Cc: Peter Chen, Thierry Reding, Jonathan Hunter, linux-usb, linux-tegra, linux-kernel 26.02.2019 13:56, Greg Kroah-Hartman пишет: > On Mon, Feb 25, 2019 at 08:07:15AM +0300, Dmitry Osipenko wrote: >> В Mon, 25 Feb 2019 02:27:19 +0000 >> Peter Chen <peter.chen@nxp.com> пишет: >> >>> >>>> >>>> Fixes: dfebb5f43a78827a ("usb: chipidea: Add support for >>>> Tegra20/30/114/124") >>> >>> I suppose you need to apply at stable tree too, right? >>> >> >> It is enough to have the "Fixes" tag to get patch backported into all >> relevant kernel versions. > > No it is not. My scripts do NOT trigger off of the fixes: tag, please > read: > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > for how to do this properly. Okay, my bad then. Maybe this is something that could warned by checkpatch.. adding Joe and Andy to the thread. ^ permalink raw reply [flat|nested] 18+ messages in thread
* [v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove_device() @ 2019-02-26 14:33 ` Dmitry Osipenko 0 siblings, 0 replies; 18+ messages in thread From: Dmitry Osipenko @ 2019-02-26 14:33 UTC (permalink / raw) To: Greg Kroah-Hartman, Joe Perches, Andy Whitcroft Cc: Peter Chen, Thierry Reding, Jonathan Hunter, linux-usb, linux-tegra, linux-kernel 26.02.2019 13:56, Greg Kroah-Hartman пишет: > On Mon, Feb 25, 2019 at 08:07:15AM +0300, Dmitry Osipenko wrote: >> В Mon, 25 Feb 2019 02:27:19 +0000 >> Peter Chen <peter.chen@nxp.com> пишет: >> >>> >>>> >>>> Fixes: dfebb5f43a78827a ("usb: chipidea: Add support for >>>> Tegra20/30/114/124") >>> >>> I suppose you need to apply at stable tree too, right? >>> >> >> It is enough to have the "Fixes" tag to get patch backported into all >> relevant kernel versions. > > No it is not. My scripts do NOT trigger off of the fixes: tag, please > read: > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > for how to do this properly. Okay, my bad then. Maybe this is something that could warned by checkpatch.. adding Joe and Andy to the thread. ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove_device() @ 2019-02-26 14:58 ` Greg Kroah-Hartman 0 siblings, 0 replies; 18+ messages in thread From: Greg Kroah-Hartman @ 2019-02-26 14:58 UTC (permalink / raw) To: Dmitry Osipenko Cc: Joe Perches, Andy Whitcroft, Peter Chen, Thierry Reding, Jonathan Hunter, linux-usb, linux-tegra, linux-kernel On Tue, Feb 26, 2019 at 05:33:05PM +0300, Dmitry Osipenko wrote: > 26.02.2019 13:56, Greg Kroah-Hartman пишет: > > On Mon, Feb 25, 2019 at 08:07:15AM +0300, Dmitry Osipenko wrote: > >> В Mon, 25 Feb 2019 02:27:19 +0000 > >> Peter Chen <peter.chen@nxp.com> пишет: > >> > >>> > >>>> > >>>> Fixes: dfebb5f43a78827a ("usb: chipidea: Add support for > >>>> Tegra20/30/114/124") > >>> > >>> I suppose you need to apply at stable tree too, right? > >>> > >> > >> It is enough to have the "Fixes" tag to get patch backported into all > >> relevant kernel versions. > > > > No it is not. My scripts do NOT trigger off of the fixes: tag, please > > read: > > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > > for how to do this properly. > > Okay, my bad then. Maybe this is something that could warned by checkpatch.. adding Joe and Andy to the thread. Why? It's allowed to put fixes: tags for a patch that does not belong in a stable tree. That happens all the time, and is encouraged. Look at some of the stuff in linux-next now, we have Fixes: for commits that are still in linux-next as well, because we do not rebase our trees. When they all merge into Linus's tree, all is good. So this is not something that checkpatch needs to do anything about. thanks, greg k-h ^ permalink raw reply [flat|nested] 18+ messages in thread
* [v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove_device() @ 2019-02-26 14:58 ` Greg Kroah-Hartman 0 siblings, 0 replies; 18+ messages in thread From: Greg Kroah-Hartman @ 2019-02-26 14:58 UTC (permalink / raw) To: Dmitry Osipenko Cc: Joe Perches, Andy Whitcroft, Peter Chen, Thierry Reding, Jonathan Hunter, linux-usb, linux-tegra, linux-kernel On Tue, Feb 26, 2019 at 05:33:05PM +0300, Dmitry Osipenko wrote: > 26.02.2019 13:56, Greg Kroah-Hartman пишет: > > On Mon, Feb 25, 2019 at 08:07:15AM +0300, Dmitry Osipenko wrote: > >> В Mon, 25 Feb 2019 02:27:19 +0000 > >> Peter Chen <peter.chen@nxp.com> пишет: > >> > >>> > >>>> > >>>> Fixes: dfebb5f43a78827a ("usb: chipidea: Add support for > >>>> Tegra20/30/114/124") > >>> > >>> I suppose you need to apply at stable tree too, right? > >>> > >> > >> It is enough to have the "Fixes" tag to get patch backported into all > >> relevant kernel versions. > > > > No it is not. My scripts do NOT trigger off of the fixes: tag, please > > read: > > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > > for how to do this properly. > > Okay, my bad then. Maybe this is something that could warned by checkpatch.. adding Joe and Andy to the thread. Why? It's allowed to put fixes: tags for a patch that does not belong in a stable tree. That happens all the time, and is encouraged. Look at some of the stuff in linux-next now, we have Fixes: for commits that are still in linux-next as well, because we do not rebase our trees. When they all merge into Linus's tree, all is good. So this is not something that checkpatch needs to do anything about. thanks, greg k-h ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove_device() @ 2019-02-26 15:08 ` Dmitry Osipenko 0 siblings, 0 replies; 18+ messages in thread From: Dmitry Osipenko @ 2019-02-26 15:08 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Joe Perches, Andy Whitcroft, Peter Chen, Thierry Reding, Jonathan Hunter, linux-usb, linux-tegra, linux-kernel 26.02.2019 17:58, Greg Kroah-Hartman пишет: > On Tue, Feb 26, 2019 at 05:33:05PM +0300, Dmitry Osipenko wrote: >> 26.02.2019 13:56, Greg Kroah-Hartman пишет: >>> On Mon, Feb 25, 2019 at 08:07:15AM +0300, Dmitry Osipenko wrote: >>>> В Mon, 25 Feb 2019 02:27:19 +0000 >>>> Peter Chen <peter.chen@nxp.com> пишет: >>>> >>>>> >>>>>> >>>>>> Fixes: dfebb5f43a78827a ("usb: chipidea: Add support for >>>>>> Tegra20/30/114/124") >>>>> >>>>> I suppose you need to apply at stable tree too, right? >>>>> >>>> >>>> It is enough to have the "Fixes" tag to get patch backported into all >>>> relevant kernel versions. >>> >>> No it is not. My scripts do NOT trigger off of the fixes: tag, please >>> read: >>> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html >>> for how to do this properly. >> >> Okay, my bad then. Maybe this is something that could warned by checkpatch.. adding Joe and Andy to the thread. > > Why? It's allowed to put fixes: tags for a patch that does not belong > in a stable tree. That happens all the time, and is encouraged. Look > at some of the stuff in linux-next now, we have Fixes: for commits that > are still in linux-next as well, because we do not rebase our trees. > When they all merge into Linus's tree, all is good. > > So this is not something that checkpatch needs to do anything about. At least that might help in cases like this if maintainer is also oblivious. I guess it wouldn't hurt at all to add a "green" warning if there is a "Fixes" tag and no "stable", something like this: WARNING: There is a "Fixes" tag and no "Cc: stable <stable@vger.kernel.org>", please add the stable tag if patch is intended to be backported to stable kernels. ^ permalink raw reply [flat|nested] 18+ messages in thread
* [v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove_device() @ 2019-02-26 15:08 ` Dmitry Osipenko 0 siblings, 0 replies; 18+ messages in thread From: Dmitry Osipenko @ 2019-02-26 15:08 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Joe Perches, Andy Whitcroft, Peter Chen, Thierry Reding, Jonathan Hunter, linux-usb, linux-tegra, linux-kernel 26.02.2019 17:58, Greg Kroah-Hartman пишет: > On Tue, Feb 26, 2019 at 05:33:05PM +0300, Dmitry Osipenko wrote: >> 26.02.2019 13:56, Greg Kroah-Hartman пишет: >>> On Mon, Feb 25, 2019 at 08:07:15AM +0300, Dmitry Osipenko wrote: >>>> В Mon, 25 Feb 2019 02:27:19 +0000 >>>> Peter Chen <peter.chen@nxp.com> пишет: >>>> >>>>> >>>>>> >>>>>> Fixes: dfebb5f43a78827a ("usb: chipidea: Add support for >>>>>> Tegra20/30/114/124") >>>>> >>>>> I suppose you need to apply at stable tree too, right? >>>>> >>>> >>>> It is enough to have the "Fixes" tag to get patch backported into all >>>> relevant kernel versions. >>> >>> No it is not. My scripts do NOT trigger off of the fixes: tag, please >>> read: >>> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html >>> for how to do this properly. >> >> Okay, my bad then. Maybe this is something that could warned by checkpatch.. adding Joe and Andy to the thread. > > Why? It's allowed to put fixes: tags for a patch that does not belong > in a stable tree. That happens all the time, and is encouraged. Look > at some of the stuff in linux-next now, we have Fixes: for commits that > are still in linux-next as well, because we do not rebase our trees. > When they all merge into Linus's tree, all is good. > > So this is not something that checkpatch needs to do anything about. At least that might help in cases like this if maintainer is also oblivious. I guess it wouldn't hurt at all to add a "green" warning if there is a "Fixes" tag and no "stable", something like this: WARNING: There is a "Fixes" tag and no "Cc: stable <stable@vger.kernel.org>", please add the stable tag if patch is intended to be backported to stable kernels. ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove_device() @ 2019-02-26 15:21 ` Greg Kroah-Hartman 0 siblings, 0 replies; 18+ messages in thread From: Greg Kroah-Hartman @ 2019-02-26 15:21 UTC (permalink / raw) To: Dmitry Osipenko Cc: Joe Perches, Andy Whitcroft, Peter Chen, Thierry Reding, Jonathan Hunter, linux-usb, linux-tegra, linux-kernel On Tue, Feb 26, 2019 at 06:08:17PM +0300, Dmitry Osipenko wrote: > 26.02.2019 17:58, Greg Kroah-Hartman пишет: > > On Tue, Feb 26, 2019 at 05:33:05PM +0300, Dmitry Osipenko wrote: > >> 26.02.2019 13:56, Greg Kroah-Hartman пишет: > >>> On Mon, Feb 25, 2019 at 08:07:15AM +0300, Dmitry Osipenko wrote: > >>>> В Mon, 25 Feb 2019 02:27:19 +0000 > >>>> Peter Chen <peter.chen@nxp.com> пишет: > >>>> > >>>>> > >>>>>> > >>>>>> Fixes: dfebb5f43a78827a ("usb: chipidea: Add support for > >>>>>> Tegra20/30/114/124") > >>>>> > >>>>> I suppose you need to apply at stable tree too, right? > >>>>> > >>>> > >>>> It is enough to have the "Fixes" tag to get patch backported into all > >>>> relevant kernel versions. > >>> > >>> No it is not. My scripts do NOT trigger off of the fixes: tag, please > >>> read: > >>> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > >>> for how to do this properly. > >> > >> Okay, my bad then. Maybe this is something that could warned by checkpatch.. adding Joe and Andy to the thread. > > > > Why? It's allowed to put fixes: tags for a patch that does not belong > > in a stable tree. That happens all the time, and is encouraged. Look > > at some of the stuff in linux-next now, we have Fixes: for commits that > > are still in linux-next as well, because we do not rebase our trees. > > When they all merge into Linus's tree, all is good. > > > > So this is not something that checkpatch needs to do anything about. > > At least that might help in cases like this if maintainer is also oblivious. If the maintainer is "oblivious", they are not going to be running checkpatch :) Remember, the "Fixes:" tag is a relatively new thing compared to the cc: stable tag, which has been a documented requirement for over a decade. Yes, some subsystems do not even do cc: stable, but that is because those subsystem maintainers do not want to do it, or do not care. Again, checkpatch is not going to help them. checkpatch is not a panacea, people still have to use their brains. greg k-h ^ permalink raw reply [flat|nested] 18+ messages in thread
* [v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove_device() @ 2019-02-26 15:21 ` Greg Kroah-Hartman 0 siblings, 0 replies; 18+ messages in thread From: Greg Kroah-Hartman @ 2019-02-26 15:21 UTC (permalink / raw) To: Dmitry Osipenko Cc: Joe Perches, Andy Whitcroft, Peter Chen, Thierry Reding, Jonathan Hunter, linux-usb, linux-tegra, linux-kernel On Tue, Feb 26, 2019 at 06:08:17PM +0300, Dmitry Osipenko wrote: > 26.02.2019 17:58, Greg Kroah-Hartman пишет: > > On Tue, Feb 26, 2019 at 05:33:05PM +0300, Dmitry Osipenko wrote: > >> 26.02.2019 13:56, Greg Kroah-Hartman пишет: > >>> On Mon, Feb 25, 2019 at 08:07:15AM +0300, Dmitry Osipenko wrote: > >>>> В Mon, 25 Feb 2019 02:27:19 +0000 > >>>> Peter Chen <peter.chen@nxp.com> пишет: > >>>> > >>>>> > >>>>>> > >>>>>> Fixes: dfebb5f43a78827a ("usb: chipidea: Add support for > >>>>>> Tegra20/30/114/124") > >>>>> > >>>>> I suppose you need to apply at stable tree too, right? > >>>>> > >>>> > >>>> It is enough to have the "Fixes" tag to get patch backported into all > >>>> relevant kernel versions. > >>> > >>> No it is not. My scripts do NOT trigger off of the fixes: tag, please > >>> read: > >>> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > >>> for how to do this properly. > >> > >> Okay, my bad then. Maybe this is something that could warned by checkpatch.. adding Joe and Andy to the thread. > > > > Why? It's allowed to put fixes: tags for a patch that does not belong > > in a stable tree. That happens all the time, and is encouraged. Look > > at some of the stuff in linux-next now, we have Fixes: for commits that > > are still in linux-next as well, because we do not rebase our trees. > > When they all merge into Linus's tree, all is good. > > > > So this is not something that checkpatch needs to do anything about. > > At least that might help in cases like this if maintainer is also oblivious. If the maintainer is "oblivious", they are not going to be running checkpatch :) Remember, the "Fixes:" tag is a relatively new thing compared to the cc: stable tag, which has been a documented requirement for over a decade. Yes, some subsystems do not even do cc: stable, but that is because those subsystem maintainers do not want to do it, or do not care. Again, checkpatch is not going to help them. checkpatch is not a panacea, people still have to use their brains. greg k-h ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove_device() @ 2019-02-26 15:40 ` Dmitry Osipenko 0 siblings, 0 replies; 18+ messages in thread From: Dmitry Osipenko @ 2019-02-26 15:40 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Joe Perches, Andy Whitcroft, Peter Chen, Thierry Reding, Jonathan Hunter, linux-usb, linux-tegra, linux-kernel 26.02.2019 18:21, Greg Kroah-Hartman пишет: > On Tue, Feb 26, 2019 at 06:08:17PM +0300, Dmitry Osipenko wrote: >> 26.02.2019 17:58, Greg Kroah-Hartman пишет: >>> On Tue, Feb 26, 2019 at 05:33:05PM +0300, Dmitry Osipenko wrote: >>>> 26.02.2019 13:56, Greg Kroah-Hartman пишет: >>>>> On Mon, Feb 25, 2019 at 08:07:15AM +0300, Dmitry Osipenko wrote: >>>>>> В Mon, 25 Feb 2019 02:27:19 +0000 >>>>>> Peter Chen <peter.chen@nxp.com> пишет: >>>>>> >>>>>>> >>>>>>>> >>>>>>>> Fixes: dfebb5f43a78827a ("usb: chipidea: Add support for >>>>>>>> Tegra20/30/114/124") >>>>>>> >>>>>>> I suppose you need to apply at stable tree too, right? >>>>>>> >>>>>> >>>>>> It is enough to have the "Fixes" tag to get patch backported into all >>>>>> relevant kernel versions. >>>>> >>>>> No it is not. My scripts do NOT trigger off of the fixes: tag, please >>>>> read: >>>>> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html >>>>> for how to do this properly. >>>> >>>> Okay, my bad then. Maybe this is something that could warned by checkpatch.. adding Joe and Andy to the thread. >>> >>> Why? It's allowed to put fixes: tags for a patch that does not belong >>> in a stable tree. That happens all the time, and is encouraged. Look >>> at some of the stuff in linux-next now, we have Fixes: for commits that >>> are still in linux-next as well, because we do not rebase our trees. >>> When they all merge into Linus's tree, all is good. >>> >>> So this is not something that checkpatch needs to do anything about. >> >> At least that might help in cases like this if maintainer is also oblivious. > > If the maintainer is "oblivious", they are not going to be running > checkpatch :) > > Remember, the "Fixes:" tag is a relatively new thing compared to the cc: > stable tag, which has been a documented requirement for over a decade. > Yes, some subsystems do not even do cc: stable, but that is because > those subsystem maintainers do not want to do it, or do not care. > Again, checkpatch is not going to help them. > > checkpatch is not a panacea, people still have to use their brains. My point that either submitter or maintainers may catch up the problem if at least there are means to report the problem. So I'm still thinking it's not a bad idea to add the warning message, maybe even for the "checkpatch --strict" option only. I'm not insisting that it is something super-necessary and it's up to you guys to decide in the end. ^ permalink raw reply [flat|nested] 18+ messages in thread
* [v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove_device() @ 2019-02-26 15:40 ` Dmitry Osipenko 0 siblings, 0 replies; 18+ messages in thread From: Dmitry Osipenko @ 2019-02-26 15:40 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Joe Perches, Andy Whitcroft, Peter Chen, Thierry Reding, Jonathan Hunter, linux-usb, linux-tegra, linux-kernel 26.02.2019 18:21, Greg Kroah-Hartman пишет: > On Tue, Feb 26, 2019 at 06:08:17PM +0300, Dmitry Osipenko wrote: >> 26.02.2019 17:58, Greg Kroah-Hartman пишет: >>> On Tue, Feb 26, 2019 at 05:33:05PM +0300, Dmitry Osipenko wrote: >>>> 26.02.2019 13:56, Greg Kroah-Hartman пишет: >>>>> On Mon, Feb 25, 2019 at 08:07:15AM +0300, Dmitry Osipenko wrote: >>>>>> В Mon, 25 Feb 2019 02:27:19 +0000 >>>>>> Peter Chen <peter.chen@nxp.com> пишет: >>>>>> >>>>>>> >>>>>>>> >>>>>>>> Fixes: dfebb5f43a78827a ("usb: chipidea: Add support for >>>>>>>> Tegra20/30/114/124") >>>>>>> >>>>>>> I suppose you need to apply at stable tree too, right? >>>>>>> >>>>>> >>>>>> It is enough to have the "Fixes" tag to get patch backported into all >>>>>> relevant kernel versions. >>>>> >>>>> No it is not. My scripts do NOT trigger off of the fixes: tag, please >>>>> read: >>>>> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html >>>>> for how to do this properly. >>>> >>>> Okay, my bad then. Maybe this is something that could warned by checkpatch.. adding Joe and Andy to the thread. >>> >>> Why? It's allowed to put fixes: tags for a patch that does not belong >>> in a stable tree. That happens all the time, and is encouraged. Look >>> at some of the stuff in linux-next now, we have Fixes: for commits that >>> are still in linux-next as well, because we do not rebase our trees. >>> When they all merge into Linus's tree, all is good. >>> >>> So this is not something that checkpatch needs to do anything about. >> >> At least that might help in cases like this if maintainer is also oblivious. > > If the maintainer is "oblivious", they are not going to be running > checkpatch :) > > Remember, the "Fixes:" tag is a relatively new thing compared to the cc: > stable tag, which has been a documented requirement for over a decade. > Yes, some subsystems do not even do cc: stable, but that is because > those subsystem maintainers do not want to do it, or do not care. > Again, checkpatch is not going to help them. > > checkpatch is not a panacea, people still have to use their brains. My point that either submitter or maintainers may catch up the problem if at least there are means to report the problem. So I'm still thinking it's not a bad idea to add the warning message, maybe even for the "checkpatch --strict" option only. I'm not insisting that it is something super-necessary and it's up to you guys to decide in the end. ^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2019-02-26 15:40 UTC | newest] Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-02-24 15:36 [PATCH v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove_device() Dmitry Osipenko 2019-02-24 15:36 ` [v1] " Dmitry Osipenko 2019-02-25 2:27 ` [PATCH v1] " Peter Chen 2019-02-25 2:27 ` [v1] " Peter Chen 2019-02-25 5:07 ` [PATCH v1] " Dmitry Osipenko 2019-02-25 5:07 ` [v1] " Dmitry Osipenko 2019-02-26 10:56 ` [PATCH v1] " Greg Kroah-Hartman 2019-02-26 10:56 ` [v1] " Greg Kroah-Hartman 2019-02-26 14:33 ` [PATCH v1] " Dmitry Osipenko 2019-02-26 14:33 ` [v1] " Dmitry Osipenko 2019-02-26 14:58 ` [PATCH v1] " Greg Kroah-Hartman 2019-02-26 14:58 ` [v1] " Greg Kroah-Hartman 2019-02-26 15:08 ` [PATCH v1] " Dmitry Osipenko 2019-02-26 15:08 ` [v1] " Dmitry Osipenko 2019-02-26 15:21 ` [PATCH v1] " Greg Kroah-Hartman 2019-02-26 15:21 ` [v1] " Greg Kroah-Hartman 2019-02-26 15:40 ` [PATCH v1] " Dmitry Osipenko 2019-02-26 15:40 ` [v1] " Dmitry Osipenko
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.