From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Martin Subject: Re: [PATCH v5 06/26] arm64/sve: Check SVE virtualisability Date: Tue, 26 Feb 2019 12:06:47 +0000 Message-ID: <20190226120647.GI3567@e103592.cambridge.arm.com> References: <1550519559-15915-1-git-send-email-Dave.Martin@arm.com> <1550519559-15915-7-git-send-email-Dave.Martin@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 418E04A36C for ; Tue, 26 Feb 2019 07:06:53 -0500 (EST) Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CKak5Mz1rkrT for ; Tue, 26 Feb 2019 07:06:52 -0500 (EST) Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 39F7A4A1DF for ; Tue, 26 Feb 2019 07:06:52 -0500 (EST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu To: Julien Grall Cc: Okamoto Takayuki , Christoffer Dall , Ard Biesheuvel , Marc Zyngier , Catalin Marinas , Will Deacon , Zhang Lei , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org List-Id: kvmarm@lists.cs.columbia.edu On Thu, Feb 21, 2019 at 01:36:26PM +0000, Julien Grall wrote: > Hi Dave, > > On 18/02/2019 19:52, Dave Martin wrote: > >+ /* > >+ * Mismatches above sve_max_virtualisable_vl are fine, since > >+ * no guest is allowed to configure ZCR_EL2.LEN to exceed this: > >+ */ > >+ if (sve_vl_from_vq(bit_to_vq(b)) <= sve_max_virtualisable_vl) { > >+ pr_warn("SVE: cpu%d: Unsupported vector length(s) present\n", > >+ smp_processor_id()); > > Would it be worth to print the unsupported vector length? Possibly not, but admittedly the intent is a bit unclear in this patch. See my reply to Julien Thierry (and respond on that subthread if you have comments, so that we don't end up with two subthreads discussing the same thing...) Thanks ---Dave From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56189C10F0B for ; Tue, 26 Feb 2019 12:07:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 20305218A1 for ; Tue, 26 Feb 2019 12:07:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="i1ZlYM7M" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20305218A1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5JRXKTHaivrbPZ3vUrL9CkL1tugKtl95bngryDS5DBk=; b=i1ZlYM7MKgnyTf a+aqc17/7N1BspOKJiexoiyl2sSDhOpTwDUwX9mOBdYfsQAgVniKH32t1EZF6thoUrYQjhhboMpt6 5g3npFsP7HWOZO9SRCEg1Xq+i3wIPQL5JrSP/tgrf4xA9XJE2ptCLSsEJ9Gh4VsUH0+hbFRZL7X9u IZFmPeBMNe1jRGAgKyrvoOq8SRTXO+IE3WnzBKNB/+FH1ZF97PfPSJx0FKZe1ndvudSsdOWYQwW7t cTPzeL87k9u0PPU5Muy3TJB8RuLZMtvjhFbrGB7LjhfQpsYHsV2fWALZJyB7AdpQbRwjywJqwohih 699EHj2icgl6O8ATeAfA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gybWF-0001IS-3M; Tue, 26 Feb 2019 12:07:31 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gybVc-0000hs-BB for linux-arm-kernel@lists.infradead.org; Tue, 26 Feb 2019 12:07:01 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C1A4280D; Tue, 26 Feb 2019 04:06:51 -0800 (PST) Received: from e103592.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F3F9C3F71D; Tue, 26 Feb 2019 04:06:49 -0800 (PST) Date: Tue, 26 Feb 2019 12:06:47 +0000 From: Dave Martin To: Julien Grall Subject: Re: [PATCH v5 06/26] arm64/sve: Check SVE virtualisability Message-ID: <20190226120647.GI3567@e103592.cambridge.arm.com> References: <1550519559-15915-1-git-send-email-Dave.Martin@arm.com> <1550519559-15915-7-git-send-email-Dave.Martin@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190226_040652_793645_4EC69C2A X-CRM114-Status: GOOD ( 11.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Okamoto Takayuki , Christoffer Dall , Ard Biesheuvel , Marc Zyngier , Catalin Marinas , Will Deacon , Zhang Lei , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 21, 2019 at 01:36:26PM +0000, Julien Grall wrote: > Hi Dave, > > On 18/02/2019 19:52, Dave Martin wrote: > >+ /* > >+ * Mismatches above sve_max_virtualisable_vl are fine, since > >+ * no guest is allowed to configure ZCR_EL2.LEN to exceed this: > >+ */ > >+ if (sve_vl_from_vq(bit_to_vq(b)) <= sve_max_virtualisable_vl) { > >+ pr_warn("SVE: cpu%d: Unsupported vector length(s) present\n", > >+ smp_processor_id()); > > Would it be worth to print the unsupported vector length? Possibly not, but admittedly the intent is a bit unclear in this patch. See my reply to Julien Thierry (and respond on that subthread if you have comments, so that we don't end up with two subthreads discussing the same thing...) Thanks ---Dave _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel