All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for drm/i915/perf: add OA interrupt support (rev4)
Date: Tue, 26 Feb 2019 14:55:17 -0000	[thread overview]
Message-ID: <20190226145517.22807.79278@emeril.freedesktop.org> (raw)
In-Reply-To: <20190226142911.9789-1-lionel.g.landwerlin@intel.com>

== Series Details ==

Series: drm/i915/perf: add OA interrupt support (rev4)
URL   : https://patchwork.freedesktop.org/series/54280/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
1cdda900a014 drm/i915/perf: rework aging tail workaround
-:241: CHECK:SPACING: No space is necessary after a cast
#241: FILE: drivers/gpu/drm/i915/i915_perf.c:500:
+			u32 *report32 = (void *) report;

-:319: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#319: FILE: drivers/gpu/drm/i915/i915_perf.c:795:
+		report32[0] = report32[1] = 0;

-:363: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#363: FILE: drivers/gpu/drm/i915/i915_perf.c:998:
+		report32[0] = report32[1] = 0;

total: 0 errors, 0 warnings, 3 checks, 354 lines checked
01ae7ed1bd49 drm/i915/perf: move pollin setup to non hw specific code
30f143c5ed22 drm/i915/perf: only append status when data is available
68722d5b65d6 drm/i915/perf: introduce a versioning of the i915-perf uapi
b2e1e260205b drm/i915/perf: add new open param to configure polling of OA buffer
1c4d948d1927 drm/i915: handle interrupts from the OA unit
4f1ddad50b51 drm/i915/perf: add interrupt enabling parameter
-:7: WARNING:TYPO_SPELLING: 'conjuction' may be misspelled - perhaps 'conjunction'?
#7: 
mechanism of the HW. In conjuction with long periods for checks for

-:32: CHECK:LINE_SPACING: Please don't use multiple blank lines
#32: FILE: drivers/gpu/drm/i915/i915_perf.c:421:
 
+

-:124: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'dev_priv->perf.oa.half_full_count_last !=
 	     atomic64_read(&dev_priv->perf.oa.half_full_count)'
#124: FILE: drivers/gpu/drm/i915/i915_perf.c:2342:
+	if (stream->oa_interrupt_monitor &&
+	    (dev_priv->perf.oa.half_full_count_last !=
+	     atomic64_read(&dev_priv->perf.oa.half_full_count))) {

-:172: WARNING:TYPO_SPELLING: 'conjuction' may be misspelled - perhaps 'conjunction'?
#172: FILE: include/uapi/drm/i915_drm.h:1662:
+	 * buffer in i915. This option in conjuction with a long polling delay

total: 0 errors, 2 warnings, 2 checks, 147 lines checked
eaf300781632 drm/i915/perf: add flushing ioctl
6f8b7eacba57 drm/i915/perf: bump i915-perf revision

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-02-26 14:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-26 14:29 [PATCH v3 0/9] drm/i915/perf: add OA interrupt support Lionel Landwerlin
2019-02-26 14:29 ` [PATCH v3 1/9] drm/i915/perf: rework aging tail workaround Lionel Landwerlin
2019-02-26 14:29 ` [PATCH v3 2/9] drm/i915/perf: move pollin setup to non hw specific code Lionel Landwerlin
2019-02-26 14:29 ` [PATCH v3 3/9] drm/i915/perf: only append status when data is available Lionel Landwerlin
2019-02-26 14:29 ` [PATCH v3 4/9] drm/i915/perf: introduce a versioning of the i915-perf uapi Lionel Landwerlin
2019-02-26 14:29 ` [PATCH v3 5/9] drm/i915/perf: add new open param to configure polling of OA buffer Lionel Landwerlin
2019-02-26 14:29 ` [PATCH v3 6/9] drm/i915: handle interrupts from the OA unit Lionel Landwerlin
2019-02-26 14:29 ` [PATCH v3 7/9] drm/i915/perf: add interrupt enabling parameter Lionel Landwerlin
2019-02-26 14:29 ` [PATCH v3 8/9] drm/i915/perf: add flushing ioctl Lionel Landwerlin
2019-02-26 14:29 ` [PATCH v3 9/9] drm/i915/perf: bump i915-perf revision Lionel Landwerlin
2019-02-26 14:55 ` Patchwork [this message]
2019-02-26 14:59 ` ✗ Fi.CI.SPARSE: warning for drm/i915/perf: add OA interrupt support (rev4) Patchwork
2019-02-26 15:20 ` ✓ Fi.CI.BAT: success " Patchwork
2019-02-26 18:04 ` ✓ Fi.CI.IGT: " Patchwork
2019-03-25 10:34 ` [PATCH v3 0/9] drm/i915/perf: add OA interrupt support Lionel Landwerlin
2019-04-02 11:49   ` Joonas Lahtinen
2019-04-02 16:36     ` Lionel Landwerlin
2019-04-26  8:20       ` Lionel Landwerlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190226145517.22807.79278@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.