From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove_device() Date: Tue, 26 Feb 2019 15:58:57 +0100 Message-ID: <20190226145857.GB26080@kroah.com> References: <20190224153622.8877-1-digetx@gmail.com> <20190225080715.4965810a@dimatab> <20190226105615.GA12397@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Dmitry Osipenko Cc: Joe Perches , Andy Whitcroft , Peter Chen , Thierry Reding , Jonathan Hunter , "linux-usb@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-Id: linux-tegra@vger.kernel.org On Tue, Feb 26, 2019 at 05:33:05PM +0300, Dmitry Osipenko wrote: > 26.02.2019 13:56, Greg Kroah-Hartman пишет: > > On Mon, Feb 25, 2019 at 08:07:15AM +0300, Dmitry Osipenko wrote: > >> В Mon, 25 Feb 2019 02:27:19 +0000 > >> Peter Chen пишет: > >> > >>> > >>>> > >>>> Fixes: dfebb5f43a78827a ("usb: chipidea: Add support for > >>>> Tegra20/30/114/124") > >>> > >>> I suppose you need to apply at stable tree too, right? > >>> > >> > >> It is enough to have the "Fixes" tag to get patch backported into all > >> relevant kernel versions. > > > > No it is not. My scripts do NOT trigger off of the fixes: tag, please > > read: > > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > > for how to do this properly. > > Okay, my bad then. Maybe this is something that could warned by checkpatch.. adding Joe and Andy to the thread. Why? It's allowed to put fixes: tags for a patch that does not belong in a stable tree. That happens all the time, and is encouraged. Look at some of the stuff in linux-next now, we have Fixes: for commits that are still in linux-next as well, because we do not rebase our trees. When they all merge into Linus's tree, all is good. So this is not something that checkpatch needs to do anything about. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove_device() From: Greg Kroah-Hartman Message-Id: <20190226145857.GB26080@kroah.com> Date: Tue, 26 Feb 2019 15:58:57 +0100 To: Dmitry Osipenko Cc: Joe Perches , Andy Whitcroft , Peter Chen , Thierry Reding , Jonathan Hunter , "linux-usb@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-ID: T24gVHVlLCBGZWIgMjYsIDIwMTkgYXQgMDU6MzM6MDVQTSArMDMwMCwgRG1pdHJ5IE9zaXBlbmtv IHdyb3RlOgo+IDI2LjAyLjIwMTkgMTM6NTYsIEdyZWcgS3JvYWgtSGFydG1hbiDQv9C40YjQtdGC Ogo+ID4gT24gTW9uLCBGZWIgMjUsIDIwMTkgYXQgMDg6MDc6MTVBTSArMDMwMCwgRG1pdHJ5IE9z aXBlbmtvIHdyb3RlOgo+ID4+INCSIE1vbiwgMjUgRmViIDIwMTkgMDI6Mjc6MTkgKzAwMDAKPiA+ PiBQZXRlciBDaGVuIDxwZXRlci5jaGVuQG54cC5jb20+INC/0LjRiNC10YI6Cj4gPj4KPiA+Pj4g IAo+ID4+Pj4KPiA+Pj4+IEZpeGVzOiBkZmViYjVmNDNhNzg4MjdhICgidXNiOiBjaGlwaWRlYTog QWRkIHN1cHBvcnQgZm9yCj4gPj4+PiBUZWdyYTIwLzMwLzExNC8xMjQiKSAgCj4gPj4+Cj4gPj4+ IEkgc3VwcG9zZSB5b3UgbmVlZCB0byBhcHBseSBhdCBzdGFibGUgdHJlZSB0b28sIHJpZ2h0Pwo+ ID4+Pgo+ID4+Cj4gPj4gSXQgaXMgZW5vdWdoIHRvIGhhdmUgdGhlICJGaXhlcyIgdGFnIHRvIGdl dCBwYXRjaCBiYWNrcG9ydGVkIGludG8gYWxsCj4gPj4gcmVsZXZhbnQga2VybmVsIHZlcnNpb25z Lgo+ID4gCj4gPiBObyBpdCBpcyBub3QuICBNeSBzY3JpcHRzIGRvIE5PVCB0cmlnZ2VyIG9mZiBv ZiB0aGUgZml4ZXM6IHRhZywgcGxlYXNlCj4gPiByZWFkOgo+ID4gICAgIGh0dHBzOi8vd3d3Lmtl cm5lbC5vcmcvZG9jL2h0bWwvbGF0ZXN0L3Byb2Nlc3Mvc3RhYmxlLWtlcm5lbC1ydWxlcy5odG1s Cj4gPiBmb3IgaG93IHRvIGRvIHRoaXMgcHJvcGVybHkuCj4gCj4gT2theSwgbXkgYmFkIHRoZW4u IE1heWJlIHRoaXMgaXMgc29tZXRoaW5nIHRoYXQgY291bGQgd2FybmVkIGJ5IGNoZWNrcGF0Y2gu LiBhZGRpbmcgSm9lIGFuZCBBbmR5IHRvIHRoZSB0aHJlYWQuCgpXaHk/ICBJdCdzIGFsbG93ZWQg dG8gcHV0IGZpeGVzOiB0YWdzIGZvciBhIHBhdGNoIHRoYXQgZG9lcyBub3QgYmVsb25nCmluIGEg c3RhYmxlIHRyZWUuICBUaGF0IGhhcHBlbnMgYWxsIHRoZSB0aW1lLCBhbmQgaXMgZW5jb3VyYWdl ZC4gIExvb2sKYXQgc29tZSBvZiB0aGUgc3R1ZmYgaW4gbGludXgtbmV4dCBub3csIHdlIGhhdmUg Rml4ZXM6IGZvciBjb21taXRzIHRoYXQKYXJlIHN0aWxsIGluIGxpbnV4LW5leHQgYXMgd2VsbCwg YmVjYXVzZSB3ZSBkbyBub3QgcmViYXNlIG91ciB0cmVlcy4KV2hlbiB0aGV5IGFsbCBtZXJnZSBp bnRvIExpbnVzJ3MgdHJlZSwgYWxsIGlzIGdvb2QuCgpTbyB0aGlzIGlzIG5vdCBzb21ldGhpbmcg dGhhdCBjaGVja3BhdGNoIG5lZWRzIHRvIGRvIGFueXRoaW5nIGFib3V0LgoKdGhhbmtzLAoKZ3Jl ZyBrLWgK