From: Adrian Bunk <bunk@stusta.de>
To: changqing.li@windriver.com
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH 0/4] Add PACKAGECONFIG
Date: Wed, 27 Feb 2019 11:11:53 +0200 [thread overview]
Message-ID: <20190227091153.GA10723@localhost> (raw)
In-Reply-To: <1551256910-119653-1-git-send-email-changqing.li@windriver.com>
On Wed, Feb 27, 2019 at 04:41:46PM +0800, changqing.li@windriver.com wrote:
> From: Changqing Li <changqing.li@windriver.com>
>
> Add PACKAGECONFIG for 4 recipes
>
> Changqing Li (4):
> net-snmp: add PACKAGECONFIG disable-des
> krb5: add PACKAGECONFIG disable-pkinit
> openhpi: add PACKAGECONFIG disable-snmpbc
> freeradius: add PACKAGECONFIGs
>...
It would be better having all variables consistently as enable-options,
instead of having some as disable/no negative options.
Keeping options enabled by default can instead be done with the
PACKAGECONFIG default.
In other words, instead of
PACKAGECONFIG ??= "libgcrypt non32bit"
...
PACKAGECONFIG[disable-snmp-bc] = "--disable-snmp_bc,--enable-snmp_bc"
to do
PACKAGECONFIG ??= "libgcrypt non32bit snmp-bc"
...
PACKAGECONFIG[snmp-bc] = "--enable-snmp_bc,--disable-snmp_bc"
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2019-02-27 9:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 8:41 [PATCH 0/4] Add PACKAGECONFIG changqing.li
2019-02-27 8:41 ` [meta-networking][PATCH 1/4] net-snmp: add PACKAGECONFIG disable-des changqing.li
2019-02-27 8:41 ` [meta-oe][PATCH 2/4] krb5: add PACKAGECONFIG disable-pkinit changqing.li
2019-02-27 8:41 ` [meta-networking][PATCH 3/4] openhpi: add PACKAGECONFIG disable-snmpbc changqing.li
2019-02-27 8:41 ` [meta-networking][PATCH 4/4] freeradius: add PACKAGECONFIGs changqing.li
2019-02-27 16:35 ` Tom Rini
2019-02-28 2:57 ` Changqing Li
2019-02-28 3:51 ` Changqing Li
2019-02-28 4:47 ` Khem Raj
2019-02-28 5:42 ` [PATCH 0/4 V2] Add PACKAGECONFIGs changqing.li
2019-02-28 5:42 ` [meta-networking][PATCH 1/4 V2] freeradius: Add PACKAGECONFIG openssl/rlm-eap-fast/rlm-eap-pwd changqing.li
2019-02-28 17:15 ` Tom Rini
2019-02-28 5:42 ` [meta-networking][PATCH 2/4 V2] openhpi: Add PACKAGECONFIG snmp-bc changqing.li
2019-02-28 5:42 ` [meta-networking][PATCH 3/4 V2] net-snmp: Add PACKAGECONFIG des changqing.li
2019-02-28 5:42 ` [meta-oe][PATCH 4/4 V2] krb5: Add PACKAGECONFIG pkinit changqing.li
2019-02-28 8:17 ` [meta-networking][PATCH 3/4 V2] net-snmp: Add PACKAGECONFIG des changqing.li
2019-02-28 12:53 ` Khem Raj
2019-03-01 1:28 ` [meta-networking][PATCH V3] " changqing.li
2019-02-27 9:11 ` Adrian Bunk [this message]
2019-02-27 16:36 ` [PATCH 0/4] Add PACKAGECONFIG Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190227091153.GA10723@localhost \
--to=bunk@stusta.de \
--cc=changqing.li@windriver.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.