From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF274C43381 for ; Wed, 27 Feb 2019 23:55:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 87EF02171F for ; Wed, 27 Feb 2019 23:55:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551311702; bh=470P0LyzcUsOcAmdiOvsS2DZ2zLBHxBaH5W9jzH71gM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=nFz65AalFEqspjF2Ptksy041P7r6SMTJR6G2lvGp94bGzxuCBzxVA16X53ECOApwV F6OBGmUk1HF7SpntUJg11uNvk09cVuAO0dJ5qQvyCZFRBkr8LgEFNhnE9WJ1+xa3D3 QX5pmQJbNn77j/QNaUApiufVoDmYoPKhjrqdNQVo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730590AbfB0XzB (ORCPT ); Wed, 27 Feb 2019 18:55:01 -0500 Received: from mail-oi1-f193.google.com ([209.85.167.193]:40160 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728397AbfB0Xy6 (ORCPT ); Wed, 27 Feb 2019 18:54:58 -0500 Received: by mail-oi1-f193.google.com with SMTP id x187so15026493oia.7; Wed, 27 Feb 2019 15:54:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=dRnsnvc++2BSVesveEuIM74VIJT7QPyOQhMUfCmmHZY=; b=T8stCLHwdkgEYKVqddDS9BUFCfBuL8679hfyvAeMcLJI1UYH4tgHycz4ubtVWkFpuw W9oUBlgu+ALt2H1z8O4If78WUbT32+VwnkcPjhfXyo1i9oGJ2O2n76Zd5+iT8Q044/xJ RP2JHs+ohxJ4C0gAS0/B78g5uOvJ46CqgUHmnfxfoRbteA6MwnUe+l+I88Gi4jn7o1lQ OHXjKuaomYi/e84rm1GFEgxll9wEwbqtcUDC4yG5iht27vDCj7RE/TzCsiMQFhn5KuZj FGaaz+WDZrflCEDtAt6CPcLVXlcGGzX3e9lYhZk5OUQiOR7ZlKpXtQYvk4pgM1gvoO1r 1cpg== X-Gm-Message-State: AHQUAubwARNEB3hs5w8oZZcihQfK/1+/EfViRxVIgVuOqfPtJDRrSKKX ismei8ie1EJzfFd2VxqraQ== X-Google-Smtp-Source: AHgI3IYrRgjOuoVpR9oqaxXEGpn240Nus78kidoUe/69C7ZUJ2UIoyAbqGKGHDKPxKNVMMbsUw4qAg== X-Received: by 2002:aca:4d53:: with SMTP id a80mr1279553oib.154.1551311696690; Wed, 27 Feb 2019 15:54:56 -0800 (PST) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id m65sm2043571oia.15.2019.02.27.15.54.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Feb 2019 15:54:55 -0800 (PST) Date: Wed, 27 Feb 2019 17:54:55 -0600 From: Rob Herring To: Anson Huang Cc: "mark.rutland@arm.com" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , "catalin.marinas@arm.com" , "will.deacon@arm.com" , "rui.zhang@intel.com" , "edubezval@gmail.com" , "daniel.lezcano@linaro.org" , Aisheng Dong , "ulf.hansson@linaro.org" , "sboyd@kernel.org" , Daniel Baluta , Andy Gross , "horms+renesas@verge.net.au" , "heiko@sntech.de" , "arnd@arndb.de" , "maxime.ripard@bootlin.com" , "bjorn.andersson@linaro.org" , "jagan@amarulasolutions.com" , "enric.balletbo@collabora.com" , "marc.w.gonzalez@free.fr" , "olof@lixom.net" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-pm@vger.kernel.org" , dl-linux-imx Subject: Re: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal binding Message-ID: <20190227235455.GA15211@bogus> References: <1551256894-21954-1-git-send-email-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1551256894-21954-1-git-send-email-Anson.Huang@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 27, 2019 at 08:46:21AM +0000, Anson Huang wrote: > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as > system controller, the system controller is in charge of system > power, clock and thermal sensors etc. management, Linux kernel > has to communicate with system controller via MU (message unit) > IPC to get temperature from thermal sensors, this patch adds > binding doc for i.MX system controller thermal driver. > > Signed-off-by: Anson Huang > --- > Changes since V9: > - change #thermal-sensor-cells value in example to 1, since there are other > thermal sensors inside system controller, it is just because there are still > some issue, so system controller does NOT expose them for now, they could > be exposed later, so it should be 1 from HW perspective. > --- > .../devicetree/bindings/arm/freescale/fsl,scu.txt | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > index 72d481c..855270b 100644 > --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > @@ -122,6 +122,21 @@ RTC bindings based on SCU Message Protocol > Required properties: > - compatible: should be "fsl,imx8qxp-sc-rtc"; > > +Thermal bindings based on SCU Message Protocol > +------------------------------------------------------------ > + > +Required properties: > +- compatible: Should be : > + "fsl,imx8qxp-sc-thermal" > + followed by "fsl,imx-sc-thermal"; > + > +- #thermal-sensor-cells: See Documentation/devicetree/bindings/thermal/thermal.txt > + for a description. > + > +- imx,sensor-resource-id: A single integer for single thermal zone's resource ID or > + an array of integers to specify each thermal zone's sensor > + resource ID. Can't you put the resource ids in the thermal-sensor cells? Why do you need to list them here? Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal binding Date: Wed, 27 Feb 2019 17:54:55 -0600 Message-ID: <20190227235455.GA15211@bogus> References: <1551256894-21954-1-git-send-email-Anson.Huang@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1551256894-21954-1-git-send-email-Anson.Huang@nxp.com> Sender: linux-kernel-owner@vger.kernel.org To: Anson Huang Cc: "mark.rutland@arm.com" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , "catalin.marinas@arm.com" , "will.deacon@arm.com" , "rui.zhang@intel.com" , "edubezval@gmail.com" , "daniel.lezcano@linaro.org" , Aisheng Dong , "ulf.hansson@linaro.org" , "sboyd@kernel.org" , Daniel Baluta , Andy Gross , "horms+renesas@verge.net.au" , "heiko@sntech.de" List-Id: devicetree@vger.kernel.org On Wed, Feb 27, 2019 at 08:46:21AM +0000, Anson Huang wrote: > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as > system controller, the system controller is in charge of system > power, clock and thermal sensors etc. management, Linux kernel > has to communicate with system controller via MU (message unit) > IPC to get temperature from thermal sensors, this patch adds > binding doc for i.MX system controller thermal driver. > > Signed-off-by: Anson Huang > --- > Changes since V9: > - change #thermal-sensor-cells value in example to 1, since there are other > thermal sensors inside system controller, it is just because there are still > some issue, so system controller does NOT expose them for now, they could > be exposed later, so it should be 1 from HW perspective. > --- > .../devicetree/bindings/arm/freescale/fsl,scu.txt | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > index 72d481c..855270b 100644 > --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > @@ -122,6 +122,21 @@ RTC bindings based on SCU Message Protocol > Required properties: > - compatible: should be "fsl,imx8qxp-sc-rtc"; > > +Thermal bindings based on SCU Message Protocol > +------------------------------------------------------------ > + > +Required properties: > +- compatible: Should be : > + "fsl,imx8qxp-sc-thermal" > + followed by "fsl,imx-sc-thermal"; > + > +- #thermal-sensor-cells: See Documentation/devicetree/bindings/thermal/thermal.txt > + for a description. > + > +- imx,sensor-resource-id: A single integer for single thermal zone's resource ID or > + an array of integers to specify each thermal zone's sensor > + resource ID. Can't you put the resource ids in the thermal-sensor cells? Why do you need to list them here? Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DBF1C43381 for ; Wed, 27 Feb 2019 23:55:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 49842214D8 for ; Wed, 27 Feb 2019 23:55:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CJMKSYbV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 49842214D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z1jO6OznhzfgprJZc1MM5AY1TtDVcIzNlLudK7ZNSDs=; b=CJMKSYbVaoCRTo 17OQgHKXoWnKyA4O4HebjtU331VdAUcL41ZKpJtJ36nT13QJl7YEGK6gOAELqKJaVviWVrq+CynNw TBQsjE/tema+J0gRF3uqojhvDv/yih8TadymAVTYNl5Zlqj8MPCnIKqyLoQvFblJjXdMRNgfku9p6 cfVzdi1CVNB4v6iOElIxCRgUhZ6ALJIOtgMLUTL09Zs0lmk5NtNwTOtlOe+XnjzcaFwmdh5ZitYSa D3+XR2LxwxU4KdJDIdp774SJbZ8AsNnHyZieYU1cztIu/c1PvVBFLa/Udyf5IROgkJjfSq3frPE56 Xqhl3FAOJ+C0ooyPWhtA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gz92U-0001mf-QE; Wed, 27 Feb 2019 23:55:02 +0000 Received: from mail-oi1-f194.google.com ([209.85.167.194]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gz92R-0001fO-Cz for linux-arm-kernel@lists.infradead.org; Wed, 27 Feb 2019 23:55:00 +0000 Received: by mail-oi1-f194.google.com with SMTP id e7so15037174oia.8 for ; Wed, 27 Feb 2019 15:54:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=dRnsnvc++2BSVesveEuIM74VIJT7QPyOQhMUfCmmHZY=; b=Jgo0Nq3LqQAUmK5hT3XeIO5tHI/N6ks56V+GwrwkCKkobhmvUD0YQq+Zla6jNRjzHM qr4+qoQfSYD4qlHdEzcE+dl+11rXGQdtC8ZPFAZFJ4QeqqB0pvev5O2gk1Z9802RtIgP m0iGQw6toFsYNtFAwbEAM0UcIni9f4HKKMV8dkeSEuA5jjjbI+yo8twFtzG7H1uUGnjG McTtzIYu1Cun662VcLgki2q6PNDtpUpfeq9E+2d+sdN2svk/0J7DeKvBUMayoJoRdnY2 6ZvUggNSmIFf8JGAtvQniHzpPcMDeO4OmtQ5q/rrC2s58f6ksFOfEdiN9+6pHxSsx9/n 5XAQ== X-Gm-Message-State: AHQUAuafzuREEQ7A8ck7MmUEv/Ux1U86pKfpFI6Aptd1MgjlHff6iC/o t7doTPoBOP7efHBDsLhm8w== X-Google-Smtp-Source: AHgI3IYrRgjOuoVpR9oqaxXEGpn240Nus78kidoUe/69C7ZUJ2UIoyAbqGKGHDKPxKNVMMbsUw4qAg== X-Received: by 2002:aca:4d53:: with SMTP id a80mr1279553oib.154.1551311696690; Wed, 27 Feb 2019 15:54:56 -0800 (PST) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id m65sm2043571oia.15.2019.02.27.15.54.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Feb 2019 15:54:55 -0800 (PST) Date: Wed, 27 Feb 2019 17:54:55 -0600 From: Rob Herring To: Anson Huang Subject: Re: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal binding Message-ID: <20190227235455.GA15211@bogus> References: <1551256894-21954-1-git-send-email-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1551256894-21954-1-git-send-email-Anson.Huang@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190227_155459_447005_8E1A2F86 X-CRM114-Status: GOOD ( 20.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "ulf.hansson@linaro.org" , "heiko@sntech.de" , "maxime.ripard@bootlin.com" , "catalin.marinas@arm.com" , "will.deacon@arm.com" , "bjorn.andersson@linaro.org" , "festevam@gmail.com" , "daniel.lezcano@linaro.org" , "jagan@amarulasolutions.com" , Andy Gross , "rui.zhang@intel.com" , dl-linux-imx , "devicetree@vger.kernel.org" , "arnd@arndb.de" , "marc.w.gonzalez@free.fr" , "s.hauer@pengutronix.de" , "edubezval@gmail.com" , "olof@lixom.net" , "horms+renesas@verge.net.au" , Daniel Baluta , "linux-arm-kernel@lists.infradead.org" , Aisheng Dong , "sboyd@kernel.org" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kernel@pengutronix.de" , "enric.balletbo@collabora.com" , "shawnguo@kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 27, 2019 at 08:46:21AM +0000, Anson Huang wrote: > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as > system controller, the system controller is in charge of system > power, clock and thermal sensors etc. management, Linux kernel > has to communicate with system controller via MU (message unit) > IPC to get temperature from thermal sensors, this patch adds > binding doc for i.MX system controller thermal driver. > > Signed-off-by: Anson Huang > --- > Changes since V9: > - change #thermal-sensor-cells value in example to 1, since there are other > thermal sensors inside system controller, it is just because there are still > some issue, so system controller does NOT expose them for now, they could > be exposed later, so it should be 1 from HW perspective. > --- > .../devicetree/bindings/arm/freescale/fsl,scu.txt | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > index 72d481c..855270b 100644 > --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > @@ -122,6 +122,21 @@ RTC bindings based on SCU Message Protocol > Required properties: > - compatible: should be "fsl,imx8qxp-sc-rtc"; > > +Thermal bindings based on SCU Message Protocol > +------------------------------------------------------------ > + > +Required properties: > +- compatible: Should be : > + "fsl,imx8qxp-sc-thermal" > + followed by "fsl,imx-sc-thermal"; > + > +- #thermal-sensor-cells: See Documentation/devicetree/bindings/thermal/thermal.txt > + for a description. > + > +- imx,sensor-resource-id: A single integer for single thermal zone's resource ID or > + an array of integers to specify each thermal zone's sensor > + resource ID. Can't you put the resource ids in the thermal-sensor cells? Why do you need to list them here? Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel