From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "José Roberto de Souza" <jose.souza@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Don't manually add connectors and planes state
Date: Thu, 28 Feb 2019 13:37:05 +0200 [thread overview]
Message-ID: <20190228113705.GE20097@intel.com> (raw)
In-Reply-To: <20190227230408.31390-2-jose.souza@intel.com>
On Wed, Feb 27, 2019 at 03:04:08PM -0800, José Roberto de Souza wrote:
> drm_atomic_commit() call chain already takes care of adding
> connectors and planes, so lets no add then manually if not changing
> their states.
The specific callgraph would make review easier.
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Lyude Paul <lyude@redhat.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index 34dd5823398a..c22ddde2dfc1 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -3975,14 +3975,6 @@ static int modeset_pipe(struct drm_crtc *crtc,
>
> crtc_state->mode_changed = true;
>
> - ret = drm_atomic_add_affected_connectors(state, crtc);
> - if (ret)
> - goto out;
> -
> - ret = drm_atomic_add_affected_planes(state, crtc);
> - if (ret)
> - goto out;
> -
> ret = drm_atomic_commit(state);
> out:
> drm_atomic_state_put(state);
> --
> 2.21.0
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-02-28 11:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 23:04 [PATCH 1/2] drm/i915: Fix atomic state leak when resetting HDMI link José Roberto de Souza
2019-02-27 23:04 ` [PATCH 2/2] drm/i915: Don't manually add connectors and planes state José Roberto de Souza
2019-02-28 11:37 ` Ville Syrjälä [this message]
2019-02-28 21:27 ` Souza, Jose
2019-03-01 13:43 ` Ville Syrjälä
2019-03-02 0:25 ` Souza, Jose
2019-02-28 0:19 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Fix atomic state leak when resetting HDMI link Patchwork
2019-02-28 0:40 ` Souza, Jose
2019-02-28 11:35 ` [PATCH 1/2] " Ville Syrjälä
2019-03-02 0:47 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Fix atomic state leak when resetting HDMI link (rev2) Patchwork
2019-03-02 8:25 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190228113705.GE20097@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jose.souza@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.