From: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] meson: Make doc building dependent on gtk-doc
Date: Thu, 28 Feb 2019 13:44:17 +0200 [thread overview]
Message-ID: <20190228114417.x6lizlng6rpukkb2@ahiler-desk1.fi.intel.com> (raw)
In-Reply-To: <20190228105955.GF4038@platvala-desk.ger.corp.intel.com>
On Thu, Feb 28, 2019 at 12:59:55PM +0200, Petri Latvala wrote:
> On Wed, Feb 27, 2019 at 08:06:43PM +0200, Arkadiusz Hiler wrote:
> > Currently, when gtk-doc is not installed 'ninja' succeeds but
> > 'ninja install' fails with the following error:
> >
> > FileNotFoundError: [Errno 2] No such file or directory: 'gtkdoc-scan': 'gtkdoc-scan'
> >
> > With this patch 'meson build' will log that documentations would not
> > build and 'ninja install' will succeed.
> >
> > When forcing building docs with 'meson -Dbuild_docs=true build' the
> > following error will occur instead:
> >
> > meson.build:323:0: ERROR: Dependency "gtk-doc" not found, tried pkgconfig and cmake
> >
> > Cc: Petri Latvala <petri.latvala@intel.com>
> > Reported-by: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> > Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
>
> Reviewed-by: Petri Latvala <petri.latvala@intel.com>
>
> The gtk_doc dependency object is left unused, doc building uses
> import('gnome') instead for it, but hey.
Yeah, I am surprised thta gnome.gtkdoc() is not clever enough, doesn't
do any dependency checks and lacks 'required' flag.
They have an issue on that since 0.45.1 in Meson.
Anyway, thanks for the review. Pushing in a moment.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2019-02-28 11:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 18:06 [igt-dev] [PATCH i-g-t] meson: Make doc building dependent on gtk-doc Arkadiusz Hiler
2019-02-27 19:19 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-02-27 20:19 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2019-02-28 7:41 ` Arkadiusz Hiler
2019-02-28 10:59 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
2019-02-28 11:44 ` Arkadiusz Hiler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190228114417.x6lizlng6rpukkb2@ahiler-desk1.fi.intel.com \
--to=arkadiusz.hiler@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.