From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E96B8C4360F for ; Thu, 28 Feb 2019 15:26:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AED9920C01 for ; Thu, 28 Feb 2019 15:26:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551367597; bh=2Rv7brahYN8Uz9rnNkGYlc8II7kelXFK7zP2hogbRlA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=MXDCKi9qO2Hu1rrRe0nowf2oO7vhD/xOKROwj27VOpcFN6H9x2BGs4A9L4v2Xo+qp /nEwLINrgAtFmFHwRxmoy7OsU4LsqDbz3ScMnmSyUTb4x8bnyrxZQiIpXfXH+OjymV e9yrFSe+MN/3rH+v63Qm9UwEpLOh5SBPNU+gnQqY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388037AbfB1PLo (ORCPT ); Thu, 28 Feb 2019 10:11:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:44854 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732726AbfB1PLh (ORCPT ); Thu, 28 Feb 2019 10:11:37 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3F819218D8; Thu, 28 Feb 2019 15:11:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551366696; bh=2Rv7brahYN8Uz9rnNkGYlc8II7kelXFK7zP2hogbRlA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WZFxQeCMedfQwHCEl4xD77KvQ7pxGCyBeHCJD2iX4WfvjLZu9SmpBV+y1VsBSBQfO rvvwYg8PJukHK1BnMoP2I6+Ip1Hv6aLim/IE4YSl1mSMFEFK8snXWZRV/KVOF3LoFU PaQSial0BvQBnxBfXqyTxjmyVBPLvC2jNMyKd6AE= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Peng Hao , Robert Jarzmik , Sasha Levin Subject: [PATCH AUTOSEL 4.19 16/64] ARM: pxa: ssp: unneeded to free devm_ allocated data Date: Thu, 28 Feb 2019 10:10:17 -0500 Message-Id: <20190228151105.11277-16-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190228151105.11277-1-sashal@kernel.org> References: <20190228151105.11277-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peng Hao [ Upstream commit ba16adeb346387eb2d1ada69003588be96f098fa ] devm_ allocated data will be automatically freed. The free of devm_ allocated data is invalid. Fixes: 1c459de1e645 ("ARM: pxa: ssp: use devm_ functions") Signed-off-by: Peng Hao [title's prefix changed] Signed-off-by: Robert Jarzmik Signed-off-by: Sasha Levin --- arch/arm/plat-pxa/ssp.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm/plat-pxa/ssp.c b/arch/arm/plat-pxa/ssp.c index ed36dcab80f1e..f519199741837 100644 --- a/arch/arm/plat-pxa/ssp.c +++ b/arch/arm/plat-pxa/ssp.c @@ -190,8 +190,6 @@ static int pxa_ssp_remove(struct platform_device *pdev) if (ssp == NULL) return -ENODEV; - iounmap(ssp->mmio_base); - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); release_mem_region(res->start, resource_size(res)); @@ -201,7 +199,6 @@ static int pxa_ssp_remove(struct platform_device *pdev) list_del(&ssp->node); mutex_unlock(&ssp_lock); - kfree(ssp); return 0; } -- 2.19.1