From: Stephen Hemminger <stephen@networkplumber.org>
To: Qiming Yang <qiming.yang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH 2/2] net/ice: disable advanced features in safe mode
Date: Fri, 1 Mar 2019 10:38:47 -0800 [thread overview]
Message-ID: <20190301103847.64010d3f@shemminger-XPS-13-9360> (raw)
In-Reply-To: <20190301124613.66527-2-qiming.yang@intel.com>
On Fri, 1 Mar 2019 20:46:13 +0800
Qiming Yang <qiming.yang@intel.com> wrote:
> + PMD_INIT_LOG(WARNING, "Initialize in safe mode,"
> + "some features are disabled.\n");
Don't split a message string, it makes it harder to search.
Also, most drivers define PMD_INIT_LOG to always add a newline and do
not add the newline in the macro call.
next prev parent reply other threads:[~2019-03-01 18:38 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 12:46 [PATCH 1/2] net/ice: suppport package download Qiming Yang
2019-03-01 12:46 ` [PATCH 2/2] net/ice: disable advanced features in safe mode Qiming Yang
2019-03-01 18:38 ` Stephen Hemminger [this message]
2019-03-01 20:41 ` Stillwell Jr, Paul M
2019-03-01 13:40 ` [PATCH 1/2] net/ice: suppport package download Thomas Monjalon
2019-03-06 2:36 ` Yang, Qiming
2019-03-01 18:39 ` Stephen Hemminger
2019-03-01 18:40 ` Stephen Hemminger
2019-03-04 17:54 ` Stillwell Jr, Paul M
2019-03-20 15:50 ` [PATCH v2 0/4] enable package download in ice driver Qiming Yang
2019-03-20 15:50 ` [PATCH v2 1/4] net/ice: load OS default package Qiming Yang
2019-03-20 15:50 ` [PATCH v2 2/4] net/ice: add safe mode Qiming Yang
2019-03-20 15:50 ` [PATCH v2 3/4] net/ice: enable RSS when device init Qiming Yang
2019-03-20 15:50 ` [PATCH v2 4/4] doc: add document update for package download Qiming Yang
2019-03-20 17:59 ` [PATCH v3 0/3] enable package download in ice driver Qiming Yang
2019-03-20 17:59 ` [PATCH v3 1/3] net/ice: load OS default package Qiming Yang
2019-03-20 17:59 ` [PATCH v3 2/3] net/ice: add safe mode Qiming Yang
2019-03-20 17:59 ` [PATCH v3 3/3] net/ice: enable RSS when device init Qiming Yang
2019-03-21 15:02 ` [PATCH v4 0/3] enable package download in ice driver Qiming Yang
2019-03-21 15:02 ` [PATCH v4 1/3] net/ice: load OS default package Qiming Yang
2019-03-25 2:29 ` [PATCH v5 0/3] enable package download in ice driver Qiming Yang
2019-03-25 2:29 ` [PATCH v5 1/3] net/ice: load OS default package Qiming Yang
2019-03-25 2:29 ` [PATCH v5 2/3] net/ice: add safe mode Qiming Yang
2019-03-25 2:29 ` [PATCH v5 3/3] net/ice: enable RSS when device init Qiming Yang
2019-03-25 4:25 ` [PATCH v5 0/3] enable package download in ice driver Stillwell Jr, Paul M
2019-03-25 9:00 ` [PATCH v6 " Qiming Yang
2019-03-25 9:01 ` [PATCH v6 1/3] net/ice: load OS default package Qiming Yang
2019-03-25 13:56 ` Zhang, Qi Z
2019-03-25 9:01 ` [PATCH v6 2/3] net/ice: add safe mode Qiming Yang
2019-03-25 9:01 ` [PATCH v6 3/3] net/ice: enable RSS when device init Qiming Yang
2019-03-25 14:00 ` [PATCH v6 0/3] enable package download in ice driver Zhang, Qi Z
2019-03-21 15:02 ` [PATCH v4 2/3] net/ice: add safe mode Qiming Yang
2019-03-21 15:02 ` [PATCH v4 3/3] net/ice: enable RSS when device init Qiming Yang
2019-03-21 15:02 ` [PATCH v4 0/3] enable package download in ice driver Qiming Yang
2019-03-21 15:02 ` [PATCH v4 1/3] net/ice: load OS default package Qiming Yang
2019-03-21 15:02 ` [PATCH v4 2/3] net/ice: add safe mode Qiming Yang
2019-03-21 15:02 ` [PATCH v4 3/3] net/ice: enable RSS when device init Qiming Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190301103847.64010d3f@shemminger-XPS-13-9360 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=qiming.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.