From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9528CC43381 for ; Fri, 1 Mar 2019 13:50:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 65A8820838 for ; Fri, 1 Mar 2019 13:50:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dfRs/tw9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 65A8820838 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W5zaOcMW3ZMfJfRKownTJmzSYrwXeQk0+NWh9N2ZLAg=; b=dfRs/tw9l9qMlX 8KUXL7+amP4k6omRWTY5DquxS7a0AjdJyIs5IcwJex2ssTxrBI4EeKQ4kkhjKEDC1yKWYuhQj48Ol yGf947Voj1plCzUhYtEiuTD5oTdJe948h5M212sOgPvmPay8vfMlBnr3iIEQZW5WD55aEgLBkeWAf iqtLoNuiLhCV2iRb+0HDid6CE4aD7pCKYO2g3bP4lM9mdyAdpeRoNQfmQyo/yDOTMGljPrs74FqjE 89ENYjw0DlxGjh5qbLrKD8Ov2nwpPw/Gikc4okXhU/dPG/6hZyLMugQSMlVmQhJz7lTpXxHobCR/y yuk1W61cQUFu1t/fPvoA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gziYB-0001hZ-Df; Fri, 01 Mar 2019 13:50:07 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gziY7-00011i-33 for linux-arm-kernel@lists.infradead.org; Fri, 01 Mar 2019 13:50:05 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 859D5A78; Fri, 1 Mar 2019 05:50:02 -0800 (PST) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BD14E3F5C1; Fri, 1 Mar 2019 05:50:01 -0800 (PST) Date: Fri, 1 Mar 2019 13:49:59 +0000 From: Mark Rutland To: Will Deacon Subject: Re: [PATCH 04/10] arm64: debug: Rename addr parameter for non-watchpoint exception hooks Message-ID: <20190301134959.GE15517@lakrids.cambridge.arm.com> References: <20190301132809.24653-1-will.deacon@arm.com> <20190301132809.24653-5-will.deacon@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190301132809.24653-5-will.deacon@arm.com> User-Agent: Mutt/1.11.1+11 (2f07cb52) (2018-12-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190301_055003_144888_CD52CBBA X-CRM114-Status: GOOD ( 17.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 01, 2019 at 01:28:03PM +0000, Will Deacon wrote: > Since the 'addr' parameter contains an UNKNOWN value for non-watchpoint > debug exceptions, rename it to 'unused' for those hooks so we don't get > tempted to use it in the future. > > Signed-off-by: Will Deacon Reviewed-by: Mark Rutland Mark. > --- > arch/arm64/kernel/debug-monitors.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/kernel/debug-monitors.c b/arch/arm64/kernel/debug-monitors.c > index d7bb6aefae0a..c4c263d0cf0f 100644 > --- a/arch/arm64/kernel/debug-monitors.c > +++ b/arch/arm64/kernel/debug-monitors.c > @@ -222,7 +222,7 @@ static void send_user_sigtrap(int si_code) > "User debug trap"); > } > > -static int single_step_handler(unsigned long addr, unsigned int esr, > +static int single_step_handler(unsigned long unused, unsigned int esr, > struct pt_regs *regs) > { > bool handler_found = false; > @@ -302,7 +302,7 @@ static int call_break_hook(struct pt_regs *regs, unsigned int esr) > } > NOKPROBE_SYMBOL(call_break_hook); > > -static int brk_handler(unsigned long addr, unsigned int esr, > +static int brk_handler(unsigned long unused, unsigned int esr, > struct pt_regs *regs) > { > bool handler_found = false; > -- > 2.11.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel