From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=WBgJ=RE=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 3C939C43381
	for <netdev@archiver.kernel.org>; Fri,  1 Mar 2019 14:28:10 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 1226D2084F
	for <netdev@archiver.kernel.org>; Fri,  1 Mar 2019 14:28:10 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2388502AbfCAO2I (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Fri, 1 Mar 2019 09:28:08 -0500
Received: from mx2.suse.de ([195.135.220.15]:34162 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1728229AbfCAO2I (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 1 Mar 2019 09:28:08 -0500
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
Received: from relay2.suse.de (unknown [195.135.220.254])
        by mx1.suse.de (Postfix) with ESMTP id 68D2EB0B3;
        Fri,  1 Mar 2019 14:28:07 +0000 (UTC)
Received: by unicorn.suse.cz (Postfix, from userid 1000)
        id 1D133E00AD; Fri,  1 Mar 2019 15:28:07 +0100 (CET)
Date:   Fri, 1 Mar 2019 15:28:07 +0100
From:   Michal Kubecek <mkubecek@suse.cz>
To:     Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc:     linville@tuxdriver.com,
        Nicholas Nunley <nicholas.d.nunley@intel.com>,
        netdev@vger.kernel.org
Subject: Re: [PATCH v3 5/6] ethtool: support per-queue sub command --coalesce
Message-ID: <20190301142807.GK29992@unicorn.suse.cz>
References: <20190301081532.11771-1-jeffrey.t.kirsher@intel.com>
 <20190301081532.11771-5-jeffrey.t.kirsher@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190301081532.11771-5-jeffrey.t.kirsher@intel.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Fri, Mar 01, 2019 at 12:15:31AM -0800, Jeff Kirsher wrote:
> From: Nicholas Nunley <nicholas.d.nunley@intel.com>
> 
> This patch adds the ability to configure the coalesce settings from
> do_scoalesce on a per-queue basis.
> 
> For each masked queue the current settings are read, modified, and written
> back to the kernel.
> 
> Example:
> 
>  $ sudo ./ethtool --per-queue eth5 queue_mask 0x1 --coalesce
>  rx-usecs 10 tx-usecs 5
>  $ sudo ./ethtool --per-queue eth5 queue_mask 0x1 --show-coalesce
> 
>  Queue: 0
>  Adaptive RX: on  TX: on
>  stats-block-usecs: 0
>  sample-interval: 0
>  pkt-rate-low: 0
>  pkt-rate-high: 0
> 
>  rx-usecs: 10
>  rx-frames: 0
>  rx-usecs-irq: 0
>  rx-frames-irq: 256
> 
>  tx-usecs: 5
>  tx-frames: 0
>  tx-usecs-irq: 0
>  tx-frames-irq: 256
> 
>  rx-usecs-low: 0
>  rx-frame-low: 0
>  tx-usecs-low: 0
>  tx-frame-low: 0
> 
>  rx-usecs-high: 0
>  rx-frame-high: 0
>  tx-usecs-high: 0
>  tx-frame-high: 0
> 
> Based on patch by Kan Liang <kan.liang@intel.com>
> 
> Signed-off-by: Nicholas Nunley <nicholas.d.nunley@intel.com>

Reviewed-by: Michal Kubecek <mkubecek@suse.cz>