From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E114C43381 for ; Fri, 1 Mar 2019 14:36:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D9B7B2084F for ; Fri, 1 Mar 2019 14:36:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388337AbfCAOgg (ORCPT ); Fri, 1 Mar 2019 09:36:36 -0500 Received: from relay10.mail.gandi.net ([217.70.178.230]:55741 "EHLO relay10.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387965AbfCAOgg (ORCPT ); Fri, 1 Mar 2019 09:36:36 -0500 Received: from localhost (aaubervilliers-681-1-27-150.w90-88.abo.wanadoo.fr [90.88.147.150]) (Authenticated sender: maxime.ripard@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id E2EBF240014; Fri, 1 Mar 2019 14:36:32 +0000 (UTC) Date: Fri, 1 Mar 2019 15:36:32 +0100 From: Maxime Ripard To: Andreas Kemnade Cc: robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: sun8i: h3: bluetooth for Banana Pi M2 Zero board Message-ID: <20190301143632.kzlr4jphq3rceos6@flea> References: <20190228212840.24964-1-andreas@kemnade.info> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ib4bul6sb7rzbemi" Content-Disposition: inline In-Reply-To: <20190228212840.24964-1-andreas@kemnade.info> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ib4bul6sb7rzbemi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, Thanks for your patch On Thu, Feb 28, 2019 at 10:28:40PM +0100, Andreas Kemnade wrote: > The Banana Pi M2 Zero board has an AP6212 BT+Wifi combo chip > with broadcom internals attached to UART1 and some gpios. > This addition is in line with similar boards >=20 > Signed-off-by: Andreas Kemnade > --- > .../boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts | 29 ++++++++++++++++= ++++++ > 1 file changed, 29 insertions(+) >=20 > diff --git a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts b/arch/= arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts > index 1db2541135a7..39e206fac4e3 100644 > --- a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts > +++ b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts > @@ -69,6 +69,8 @@ > compatible =3D "mmc-pwrseq-simple"; > pinctrl-names =3D "default"; > reset-gpios =3D <&r_pio 0 7 GPIO_ACTIVE_LOW>; /* PL7 */ > + clocks =3D <&rtc 1>; > + clock-names =3D "ext_clock"; > }; > }; > =20 > @@ -122,7 +124,34 @@ > &uart1 { > pinctrl-names =3D "default"; > pinctrl-0 =3D <&uart1_pins>, <&uart1_rts_cts_pins>; > + uart-has-rtscts; > status =3D "okay"; > + > + bluetooth { > + compatible =3D "brcm,bcm43438-bt"; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&bt_pins_out>, <&bt_pins_in>; > + clocks =3D <&rtc 1>; > + clock-names =3D "lpo"; > + vbat-supply =3D <®_vcc3v3>; > + vddio-supply =3D <®_vcc3v3>; > + device-wakeup-gpios =3D <&pio 6 13 GPIO_ACTIVE_HIGH>; /* PG13 */ > + host-wakeup-gpios =3D <&pio 6 11 GPIO_ACTIVE_HIGH>; /* PG11 */ > + shutdown-gpios =3D <&pio 6 12 GPIO_ACTIVE_HIGH>; /* PG12 */ > + }; > + > +}; > + > +&pio { > + bt_pins_out: bt_out { > + pins =3D "PG12", "PG13"; > + function =3D "gpio_out"; > + }; > + > + bt_pins_in: bt_in { > + pins =3D "PG11"; > + function =3D "gpio_in"; > + }; You don't need any of those pinctrl nodes, GPIOs work fine without. Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --ib4bul6sb7rzbemi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXHlDcAAKCRDj7w1vZxhR xWn6AP0cj7wtgn87Bf2OYGSm3A4wakfamsXePzKGD2jOfh+OUQD+PQr/iYkj+OYv 6IvLK6H+eNF9wjDGYohNflqd7siYuwo= =Wkrh -----END PGP SIGNATURE----- --ib4bul6sb7rzbemi-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45884C43381 for ; Fri, 1 Mar 2019 14:36:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1310E2084F for ; Fri, 1 Mar 2019 14:36:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Hf0mOmfV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1310E2084F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=e1JSkSYw3Ac4OSFvQ+Zq0uBwi75caEW29eWpX580D2Y=; b=Hf0mOmfVQOi/HeAMkRItwJjKT wogQ+ZCVR560LWop0Cwl7jLY6aK0m1LfQaa/vOE8KmGhKmp5JVPZOE5XmfeIZi1wvUVXOd6S6osk+ MgzmFqPszd/Vk841Jbkr1Yi2i7xPWR2zpQXjvv5gGDZOpPqiCxTpG1GKbzv/QEzU3OqxfwkSaWTBJ wHMX9vPy+yGs5V6a5O0zJslWDpz4wl/XpV6SePWCdEn1MyReco5hpp6ke6IM40k25iqi43CAEYKKl D/C3lM65zD3MuiBF3r3t5GVdbVmbuJqyJb3d/wQEacgV7782TxDnLhJe1IzAYI1ORszOqdHqhX1R4 ylLOLTXAA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzjHN-0004A1-EN; Fri, 01 Mar 2019 14:36:49 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzjHK-00049F-6f for linux-arm-kernel@lists.infradead.org; Fri, 01 Mar 2019 14:36:48 +0000 Received: from localhost (aaubervilliers-681-1-27-150.w90-88.abo.wanadoo.fr [90.88.147.150]) (Authenticated sender: maxime.ripard@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id E2EBF240014; Fri, 1 Mar 2019 14:36:32 +0000 (UTC) Date: Fri, 1 Mar 2019 15:36:32 +0100 From: Maxime Ripard To: Andreas Kemnade Subject: Re: [PATCH] ARM: sun8i: h3: bluetooth for Banana Pi M2 Zero board Message-ID: <20190301143632.kzlr4jphq3rceos6@flea> References: <20190228212840.24964-1-andreas@kemnade.info> MIME-Version: 1.0 In-Reply-To: <20190228212840.24964-1-andreas@kemnade.info> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190301_063646_393874_731A93DB X-CRM114-Status: GOOD ( 15.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, wens@csie.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============9021373710351440342==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============9021373710351440342== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ib4bul6sb7rzbemi" Content-Disposition: inline --ib4bul6sb7rzbemi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, Thanks for your patch On Thu, Feb 28, 2019 at 10:28:40PM +0100, Andreas Kemnade wrote: > The Banana Pi M2 Zero board has an AP6212 BT+Wifi combo chip > with broadcom internals attached to UART1 and some gpios. > This addition is in line with similar boards >=20 > Signed-off-by: Andreas Kemnade > --- > .../boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts | 29 ++++++++++++++++= ++++++ > 1 file changed, 29 insertions(+) >=20 > diff --git a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts b/arch/= arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts > index 1db2541135a7..39e206fac4e3 100644 > --- a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts > +++ b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts > @@ -69,6 +69,8 @@ > compatible =3D "mmc-pwrseq-simple"; > pinctrl-names =3D "default"; > reset-gpios =3D <&r_pio 0 7 GPIO_ACTIVE_LOW>; /* PL7 */ > + clocks =3D <&rtc 1>; > + clock-names =3D "ext_clock"; > }; > }; > =20 > @@ -122,7 +124,34 @@ > &uart1 { > pinctrl-names =3D "default"; > pinctrl-0 =3D <&uart1_pins>, <&uart1_rts_cts_pins>; > + uart-has-rtscts; > status =3D "okay"; > + > + bluetooth { > + compatible =3D "brcm,bcm43438-bt"; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&bt_pins_out>, <&bt_pins_in>; > + clocks =3D <&rtc 1>; > + clock-names =3D "lpo"; > + vbat-supply =3D <®_vcc3v3>; > + vddio-supply =3D <®_vcc3v3>; > + device-wakeup-gpios =3D <&pio 6 13 GPIO_ACTIVE_HIGH>; /* PG13 */ > + host-wakeup-gpios =3D <&pio 6 11 GPIO_ACTIVE_HIGH>; /* PG11 */ > + shutdown-gpios =3D <&pio 6 12 GPIO_ACTIVE_HIGH>; /* PG12 */ > + }; > + > +}; > + > +&pio { > + bt_pins_out: bt_out { > + pins =3D "PG12", "PG13"; > + function =3D "gpio_out"; > + }; > + > + bt_pins_in: bt_in { > + pins =3D "PG11"; > + function =3D "gpio_in"; > + }; You don't need any of those pinctrl nodes, GPIOs work fine without. Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --ib4bul6sb7rzbemi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXHlDcAAKCRDj7w1vZxhR xWn6AP0cj7wtgn87Bf2OYGSm3A4wakfamsXePzKGD2jOfh+OUQD+PQr/iYkj+OYv 6IvLK6H+eNF9wjDGYohNflqd7siYuwo= =Wkrh -----END PGP SIGNATURE----- --ib4bul6sb7rzbemi-- --===============9021373710351440342== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============9021373710351440342==--