From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9268CC4360F for ; Fri, 1 Mar 2019 14:38:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6FA852087E for ; Fri, 1 Mar 2019 14:38:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388707AbfCAOiD (ORCPT ); Fri, 1 Mar 2019 09:38:03 -0500 Received: from mx2.suse.de ([195.135.220.15]:36158 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387965AbfCAOiC (ORCPT ); Fri, 1 Mar 2019 09:38:02 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 81416AC17; Fri, 1 Mar 2019 14:38:01 +0000 (UTC) Received: by unicorn.suse.cz (Postfix, from userid 1000) id 1764DE00AD; Fri, 1 Mar 2019 15:38:01 +0100 (CET) Date: Fri, 1 Mar 2019 15:38:01 +0100 From: Michal Kubecek To: Jeff Kirsher Cc: linville@tuxdriver.com, Nicholas Nunley , netdev@vger.kernel.org Subject: Re: [PATCH v3 6/6] ethtool: fix up dump_coalesce output to match actual option names Message-ID: <20190301143801.GL29992@unicorn.suse.cz> References: <20190301081532.11771-1-jeffrey.t.kirsher@intel.com> <20190301081532.11771-6-jeffrey.t.kirsher@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190301081532.11771-6-jeffrey.t.kirsher@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Mar 01, 2019 at 12:15:32AM -0800, Jeff Kirsher wrote: > From: Nicholas Nunley > > When the coalesce settings are printed with --show-coalesce a few of the > option names lack the pluralization that is present in the man page and > usage info, but are otherwise identical. > > This inconsistency could lead to some confusion if a user attempts to set > the coalesce settings by matching the output they see from --show-coalesce, > so fix this. > > Signed-off-by: Nicholas Nunley Reviewed-by: Michal Kubecek