From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CB1FC43381 for ; Fri, 1 Mar 2019 14:47:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 33DF92085A for ; Fri, 1 Mar 2019 14:47:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388802AbfCAOrI (ORCPT ); Fri, 1 Mar 2019 09:47:08 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:35623 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728395AbfCAOrI (ORCPT ); Fri, 1 Mar 2019 09:47:08 -0500 X-Originating-IP: 90.88.147.150 Received: from localhost (aaubervilliers-681-1-27-150.w90-88.abo.wanadoo.fr [90.88.147.150]) (Authenticated sender: maxime.ripard@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 33857E0002; Fri, 1 Mar 2019 14:47:03 +0000 (UTC) Date: Fri, 1 Mar 2019 15:47:03 +0100 From: Maxime Ripard To: Samuel Holland Cc: Jassi Brar , Chen-Yu Tsai , Michael Turquette , Stephen Boyd , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v2 00/10] Allwinner sunxi message box support Message-ID: <20190301144703.kyqyajysfsdvg3td@flea> References: <20190301052947.32032-1-samuel@sholland.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ghobjd6npcdkzhom" Content-Disposition: inline In-Reply-To: <20190301052947.32032-1-samuel@sholland.org> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ghobjd6npcdkzhom Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi On Thu, Feb 28, 2019 at 11:29:37PM -0600, Samuel Holland wrote: > This series adds support for the "hardware message box" in sun8i, sun9i, > and sun50i SoCs, used for communication with the ARISC management > processor (the platform's equivalent of the ARM SCP). The end goal is to > use the arm_scpi driver as a client, communicating with firmware running > on the ARISC CPU, or to use the mailbox to forward NMIs that the > firmware picks up from R_INTC. >=20 > Changes from v1: > - Marked message box clocks as critical instead of hacks in the driver > - 8 unidirectional channels instead of 4 bidirectional pairs > - Use per-SoC compatible strings and an A31 fallback compatible > - Dropped the mailbox framework patch > - Include DT patches for SoCs that document the message box > > Samuel Holland (10): > clk: sunxi-ng: sun8i: Mark the msgbox clock as critical > clk: sunxi-ng: sun9i: Mark the msgbox clock as critical > clk: sunxi-ng: sun50i: Mark the msgbox clock as critical > dt-bindings: mailbox: Add a sunxi message box binding > mailbox: sunxi-msgbox: Add a new mailbox driver > ARM: dts: sunxi: a80: Add msgbox node > ARM: dts: sunxi: a83t: Add msgbox node > ARM: dts: sunxi: h3/h5: Add msgbox node > arm64: dts: allwinner: a64: Add msgbox node > arm64: dts: allwinner: h6: Add msgbox node It looks good to me but a few things: - There's no reason to split the first three patches, so they should all be merged - You might consider using a YAML schemas for your DT bindings documentation. That will bring a more formal descriptiion and DT validation. Thanks! Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --ghobjd6npcdkzhom Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXHlF5wAKCRDj7w1vZxhR xSZNAQDg4A34dO9psJhWuKf/Wp3ytO0V7HBWnLGd7ABC26v6KQD/b/+fngiCFXHC iEpvES4rw5pW+xkjiTfH1/ANXt3brQQ= =nWPd -----END PGP SIGNATURE----- --ghobjd6npcdkzhom-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v2 00/10] Allwinner sunxi message box support Date: Fri, 1 Mar 2019 15:47:03 +0100 Message-ID: <20190301144703.kyqyajysfsdvg3td@flea> References: <20190301052947.32032-1-samuel@sholland.org> Reply-To: maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ghobjd6npcdkzhom" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <20190301052947.32032-1-samuel-RkNLwX/CsU9g9hUCZPvPmw@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Samuel Holland Cc: Jassi Brar , Chen-Yu Tsai , Michael Turquette , Stephen Boyd , Rob Herring , Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org --ghobjd6npcdkzhom Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Hi On Thu, Feb 28, 2019 at 11:29:37PM -0600, Samuel Holland wrote: > This series adds support for the "hardware message box" in sun8i, sun9i, > and sun50i SoCs, used for communication with the ARISC management > processor (the platform's equivalent of the ARM SCP). The end goal is to > use the arm_scpi driver as a client, communicating with firmware running > on the ARISC CPU, or to use the mailbox to forward NMIs that the > firmware picks up from R_INTC. > > Changes from v1: > - Marked message box clocks as critical instead of hacks in the driver > - 8 unidirectional channels instead of 4 bidirectional pairs > - Use per-SoC compatible strings and an A31 fallback compatible > - Dropped the mailbox framework patch > - Include DT patches for SoCs that document the message box > > Samuel Holland (10): > clk: sunxi-ng: sun8i: Mark the msgbox clock as critical > clk: sunxi-ng: sun9i: Mark the msgbox clock as critical > clk: sunxi-ng: sun50i: Mark the msgbox clock as critical > dt-bindings: mailbox: Add a sunxi message box binding > mailbox: sunxi-msgbox: Add a new mailbox driver > ARM: dts: sunxi: a80: Add msgbox node > ARM: dts: sunxi: a83t: Add msgbox node > ARM: dts: sunxi: h3/h5: Add msgbox node > arm64: dts: allwinner: a64: Add msgbox node > arm64: dts: allwinner: h6: Add msgbox node It looks good to me but a few things: - There's no reason to split the first three patches, so they should all be merged - You might consider using a YAML schemas for your DT bindings documentation. That will bring a more formal descriptiion and DT validation. Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --ghobjd6npcdkzhom-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E809C10F03 for ; Fri, 1 Mar 2019 14:47:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1DF6E2085A for ; Fri, 1 Mar 2019 14:47:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ly0fOoTh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1DF6E2085A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mzIOBInwZmdNOFzZpa47YJWDHQV7/ZwKg+u04JMM+hc=; b=Ly0fOoThGqgDnR/kggEqqNm0p /8E0IjAN9NEY4PYnE1FT7JI6sQ9hRDtRZ9m9FPH1uisLznemm4oFe3LOCBlDT6dK8F31iD1Itrxzt W+lBiii2rpznua7Bp9OyMo5QLSkvbOHLFiKZY0zymQnoJD5nJcm8bM66jmT7oapasKZA2ooN8YsLa sB8zezKsU94H65mGSFfpCFl+fiBM/T1F9sBOTAN3HE8AaReD4EOJvIUGoWaSAXtAAwBJydm58RRdk o6Mi2g0U1hKi5pFvghl9nBW4nmV37ASw7ALt7Wiz4D8Qkf/u19bt4YvwwfBOQQswDJqDIHcR+/gHZ WB0XaeSrw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzjRR-0001Nt-7L; Fri, 01 Mar 2019 14:47:13 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzjRN-0001Mv-01 for linux-arm-kernel@lists.infradead.org; Fri, 01 Mar 2019 14:47:10 +0000 X-Originating-IP: 90.88.147.150 Received: from localhost (aaubervilliers-681-1-27-150.w90-88.abo.wanadoo.fr [90.88.147.150]) (Authenticated sender: maxime.ripard@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 33857E0002; Fri, 1 Mar 2019 14:47:03 +0000 (UTC) Date: Fri, 1 Mar 2019 15:47:03 +0100 From: Maxime Ripard To: Samuel Holland Subject: Re: [PATCH v2 00/10] Allwinner sunxi message box support Message-ID: <20190301144703.kyqyajysfsdvg3td@flea> References: <20190301052947.32032-1-samuel@sholland.org> MIME-Version: 1.0 In-Reply-To: <20190301052947.32032-1-samuel@sholland.org> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190301_064709_186137_B31AC8F7 X-CRM114-Status: GOOD ( 14.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, linux-sunxi@googlegroups.com, Stephen Boyd , Michael Turquette , Jassi Brar , linux-kernel@vger.kernel.org, Chen-Yu Tsai , Rob Herring , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============5704896338230992011==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5704896338230992011== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ghobjd6npcdkzhom" Content-Disposition: inline --ghobjd6npcdkzhom Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi On Thu, Feb 28, 2019 at 11:29:37PM -0600, Samuel Holland wrote: > This series adds support for the "hardware message box" in sun8i, sun9i, > and sun50i SoCs, used for communication with the ARISC management > processor (the platform's equivalent of the ARM SCP). The end goal is to > use the arm_scpi driver as a client, communicating with firmware running > on the ARISC CPU, or to use the mailbox to forward NMIs that the > firmware picks up from R_INTC. >=20 > Changes from v1: > - Marked message box clocks as critical instead of hacks in the driver > - 8 unidirectional channels instead of 4 bidirectional pairs > - Use per-SoC compatible strings and an A31 fallback compatible > - Dropped the mailbox framework patch > - Include DT patches for SoCs that document the message box > > Samuel Holland (10): > clk: sunxi-ng: sun8i: Mark the msgbox clock as critical > clk: sunxi-ng: sun9i: Mark the msgbox clock as critical > clk: sunxi-ng: sun50i: Mark the msgbox clock as critical > dt-bindings: mailbox: Add a sunxi message box binding > mailbox: sunxi-msgbox: Add a new mailbox driver > ARM: dts: sunxi: a80: Add msgbox node > ARM: dts: sunxi: a83t: Add msgbox node > ARM: dts: sunxi: h3/h5: Add msgbox node > arm64: dts: allwinner: a64: Add msgbox node > arm64: dts: allwinner: h6: Add msgbox node It looks good to me but a few things: - There's no reason to split the first three patches, so they should all be merged - You might consider using a YAML schemas for your DT bindings documentation. That will bring a more formal descriptiion and DT validation. Thanks! Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --ghobjd6npcdkzhom Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXHlF5wAKCRDj7w1vZxhR xSZNAQDg4A34dO9psJhWuKf/Wp3ytO0V7HBWnLGd7ABC26v6KQD/b/+fngiCFXHC iEpvES4rw5pW+xkjiTfH1/ANXt3brQQ= =nWPd -----END PGP SIGNATURE----- --ghobjd6npcdkzhom-- --===============5704896338230992011== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5704896338230992011==--