From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linutronix.de (146.0.238.70:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 01 Mar 2019 15:11:27 -0000 Received: from mx1.redhat.com ([209.132.183.28]) by Galois.linutronix.de with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1gzjor-00065q-AY for speck@linutronix.de; Fri, 01 Mar 2019 16:11:26 +0100 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 35C6730B2379 for ; Fri, 1 Mar 2019 15:11:18 +0000 (UTC) Received: from treble (ovpn-122-204.rdu2.redhat.com [10.10.122.204]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D1ABC5B09E for ; Fri, 1 Mar 2019 15:11:17 +0000 (UTC) Date: Fri, 1 Mar 2019 09:11:14 -0600 From: Josh Poimboeuf Subject: [MODERATED] Re: qemu patch for mb_clear Message-ID: <20190301151114.sqo6kb5dbsp3ilxh@treble> References: <20181221003101.GA32181@tassilo.jf.intel.com> <20190301143729.r3onrecxplx3pvly@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190301143729.r3onrecxplx3pvly@treble> To: speck@linutronix.de List-ID: On Fri, Mar 01, 2019 at 08:37:29AM -0600, Josh Poimboeuf wrote: > On Thu, Dec 20, 2018 at 04:31:01PM -0800, speck for Andi Kleen wrote: > > > > For reference here is the qemu patch needed for using MB_CLEAR in a KVM > > guest. > > > > -Andi > > > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > > index 677a3bd5fb25..77a1149e4bb3 100644 > > --- a/target/i386/cpu.c > > +++ b/target/i386/cpu.c > > @@ -1038,7 +1038,7 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS] = { > > .feat_names = { > > NULL, NULL, "avx512-4vnniw", "avx512-4fmaps", > > NULL, NULL, NULL, NULL, > > - NULL, NULL, NULL, NULL, > > + NULL, NULL, "mbclear", NULL, > > NULL, NULL, NULL, NULL, > > NULL, NULL, "pconfig", NULL, > > NULL, NULL, NULL, NULL, > > Is this still the latest version of the qemu patch? I assume this needs > to be updated to MD_CLEAR. Also: - A patch title and description would be helpful. - Calling it "md-clear" (with the dash) would be preferable, as people constantly get confused when the names differ (and apparently qemu uses dashes instead of underscores). -- Josh