From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E130CC43381 for ; Fri, 1 Mar 2019 16:23:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B19452084D for ; Fri, 1 Mar 2019 16:23:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551457426; bh=AzRPADFjlRyBOXMelWzI2+owh4AnrH4aaUT6pCqOKqg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Oxjg13lRMj5q1cdjmnfBubL4inOYrDQS9nynXRZicj0qN+arDCIbbTPQvHnCIY5RU hGnltU2H6qZunxdx0GOc220H/ZiDzwQzx3KOE5kvfdWo5GcMT/MZEOqbIsSdJLJ+TA CHqA6R2iY+ycVjFBvlJiI4p9/Ag2AWgaTyA0JxZU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389103AbfCAQXp (ORCPT ); Fri, 1 Mar 2019 11:23:45 -0500 Received: from mail.kernel.org ([198.145.29.99]:53682 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388860AbfCAQXo (ORCPT ); Fri, 1 Mar 2019 11:23:44 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 349AC2083D; Fri, 1 Mar 2019 16:23:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551457423; bh=AzRPADFjlRyBOXMelWzI2+owh4AnrH4aaUT6pCqOKqg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UkgUJ7gO1GTQvTAPCk9w5VyK6/xGoR0HE0mT1msBh0gJ6aGsGo3ZxPVB5lry0UALP F3pxoF8+SbZg4hTP/72fYa5fnctedDjKisSBQ6DZyARaM9rv9RHtn83hf/358M4+kk cc6pyAX1/i1jgkW6mCidNk/MofclXaqR+w79Jtwk= Date: Fri, 1 Mar 2019 17:23:41 +0100 From: Greg Kroah-Hartman To: Mans Rullgard Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: core: make default autosuspend delay configurable Message-ID: <20190301162341.GC19937@kroah.com> References: <20190301142646.30831-1-mans@mansr.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190301142646.30831-1-mans@mansr.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 01, 2019 at 02:26:46PM +0000, Mans Rullgard wrote: > Make the default autosuspend delay configurable at build time. > This is useful for systems that require a non-standard value as > it avoids relying on the command line being properly set. > > Signed-off-by: Mans Rullgard > --- > drivers/usb/core/Kconfig | 8 ++++++++ > drivers/usb/core/usb.c | 4 ++-- > 2 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig > index 4d75d9a80001..38ed837538c4 100644 > --- a/drivers/usb/core/Kconfig > +++ b/drivers/usb/core/Kconfig > @@ -90,3 +90,11 @@ config USB_LEDS_TRIGGER_USBPORT > This driver allows LEDs to be controlled by USB events. Enabling this > trigger allows specifying list of USB ports that should turn on LED > when some USB device gets connected. > + > +config USB_AUTOSUSPEND_DELAY > + int "Default autosuspend delay" > + depends on USB > + default 2 > + help > + The default autosuspend delay in seconds. Can be overridden > + with the usbcore.autosuspend command line or module parameter. As everyone is suddenly going to be hit with this for a new kernel upate, you might want to put something in here that says: The default value Linux has always had is 2 seconds. Change this value if you want a different delay timeframe and can not modify the command line or module parameter option. to make people a lot more comfortable with this change. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: core: make default autosuspend delay configurable From: Greg Kroah-Hartman Message-Id: <20190301162341.GC19937@kroah.com> Date: Fri, 1 Mar 2019 17:23:41 +0100 To: Mans Rullgard Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gRnJpLCBNYXIgMDEsIDIwMTkgYXQgMDI6MjY6NDZQTSArMDAwMCwgTWFucyBSdWxsZ2FyZCB3 cm90ZToKPiBNYWtlIHRoZSBkZWZhdWx0IGF1dG9zdXNwZW5kIGRlbGF5IGNvbmZpZ3VyYWJsZSBh dCBidWlsZCB0aW1lLgo+IFRoaXMgaXMgdXNlZnVsIGZvciBzeXN0ZW1zIHRoYXQgcmVxdWlyZSBh IG5vbi1zdGFuZGFyZCB2YWx1ZSBhcwo+IGl0IGF2b2lkcyByZWx5aW5nIG9uIHRoZSBjb21tYW5k IGxpbmUgYmVpbmcgcHJvcGVybHkgc2V0Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IE1hbnMgUnVsbGdh cmQgPG1hbnNAbWFuc3IuY29tPgo+IC0tLQo+ICBkcml2ZXJzL3VzYi9jb3JlL0tjb25maWcgfCA4 ICsrKysrKysrCj4gIGRyaXZlcnMvdXNiL2NvcmUvdXNiLmMgICB8IDQgKystLQo+ICAyIGZpbGVz IGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvdXNiL2NvcmUvS2NvbmZpZyBiL2RyaXZlcnMvdXNiL2NvcmUvS2NvbmZpZwo+ IGluZGV4IDRkNzVkOWE4MDAwMS4uMzhlZDgzNzUzOGM0IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv dXNiL2NvcmUvS2NvbmZpZwo+ICsrKyBiL2RyaXZlcnMvdXNiL2NvcmUvS2NvbmZpZwo+IEBAIC05 MCwzICs5MCwxMSBAQCBjb25maWcgVVNCX0xFRFNfVFJJR0dFUl9VU0JQT1JUCj4gIAkgIFRoaXMg ZHJpdmVyIGFsbG93cyBMRURzIHRvIGJlIGNvbnRyb2xsZWQgYnkgVVNCIGV2ZW50cy4gRW5hYmxp bmcgdGhpcwo+ICAJICB0cmlnZ2VyIGFsbG93cyBzcGVjaWZ5aW5nIGxpc3Qgb2YgVVNCIHBvcnRz IHRoYXQgc2hvdWxkIHR1cm4gb24gTEVECj4gIAkgIHdoZW4gc29tZSBVU0IgZGV2aWNlIGdldHMg Y29ubmVjdGVkLgo+ICsKPiArY29uZmlnIFVTQl9BVVRPU1VTUEVORF9ERUxBWQo+ICsJaW50ICJE ZWZhdWx0IGF1dG9zdXNwZW5kIGRlbGF5Igo+ICsJZGVwZW5kcyBvbiBVU0IKPiArCWRlZmF1bHQg Mgo+ICsJaGVscAo+ICsJICBUaGUgZGVmYXVsdCBhdXRvc3VzcGVuZCBkZWxheSBpbiBzZWNvbmRz LiAgQ2FuIGJlIG92ZXJyaWRkZW4KPiArCSAgd2l0aCB0aGUgdXNiY29yZS5hdXRvc3VzcGVuZCBj b21tYW5kIGxpbmUgb3IgbW9kdWxlIHBhcmFtZXRlci4KCkFzIGV2ZXJ5b25lIGlzIHN1ZGRlbmx5 IGdvaW5nIHRvIGJlIGhpdCB3aXRoIHRoaXMgZm9yIGEgbmV3IGtlcm5lbAp1cGF0ZSwgeW91IG1p Z2h0IHdhbnQgdG8gcHV0IHNvbWV0aGluZyBpbiBoZXJlIHRoYXQgc2F5czoKCVRoZSBkZWZhdWx0 IHZhbHVlIExpbnV4IGhhcyBhbHdheXMgaGFkIGlzIDIgc2Vjb25kcy4gIENoYW5nZQoJdGhpcyB2 YWx1ZSBpZiB5b3Ugd2FudCBhIGRpZmZlcmVudCBkZWxheSB0aW1lZnJhbWUgYW5kIGNhbiBub3QK CW1vZGlmeSB0aGUgY29tbWFuZCBsaW5lIG9yIG1vZHVsZSBwYXJhbWV0ZXIgb3B0aW9uLgoKdG8g bWFrZSBwZW9wbGUgYSBsb3QgbW9yZSBjb21mb3J0YWJsZSB3aXRoIHRoaXMgY2hhbmdlLgoKdGhh bmtzLAoKZ3JlZyBrLWgK