From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linutronix.de (146.0.238.70:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 02 Mar 2019 00:34:41 -0000 Received: from mail.kernel.org ([198.145.29.99]) by Galois.linutronix.de with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1gzsbv-0000Fx-G7 for speck@linutronix.de; Sat, 02 Mar 2019 01:34:39 +0100 Received: from localhost (lfbn-1-18527-45.w90-101.abo.wanadoo.fr [90.101.69.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 38181206DD for ; Sat, 2 Mar 2019 00:34:32 +0000 (UTC) Date: Sat, 2 Mar 2019 01:34:30 +0100 From: Frederic Weisbecker Subject: [MODERATED] Re: [patch V6 02/14] MDS basics 2 Message-ID: <20190302003428.GB22355@lenoir> References: <20190301214738.281554861@linutronix.de> <20190301214847.342680091@linutronix.de> MIME-Version: 1.0 In-Reply-To: <20190301214847.342680091@linutronix.de> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: speck@linutronix.de List-ID: On Fri, Mar 01, 2019 at 10:47:40PM +0100, speck for Thomas Gleixner wrote: > static void __init cpu_set_bug_bits(struct cpuinfo_x86 *c) > { > u64 ia32_cap = 0; > > - if (x86_match_cpu(cpu_no_speculation)) > + if (cpu_matches(NO_SPECULATION)) > return; > > setup_force_cpu_bug(X86_BUG_SPECTRE_V1); > @@ -1011,15 +1022,14 @@ static void __init cpu_set_bug_bits(stru > if (cpu_has(c, X86_FEATURE_ARCH_CAPABILITIES)) > rdmsrl(MSR_IA32_ARCH_CAPABILITIES, ia32_cap); > > - if (!x86_match_cpu(cpu_no_spec_store_bypass) && > - !(ia32_cap & ARCH_CAP_SSB_NO) && > + if (!cpu_matches(NO_SSB) && !(ia32_cap & ARCH_CAP_SSB_NO) && Much clearer and well unified. Reviewed-by: Frederic Weisbecker