From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ye Xiaolong <xiaolong.ye@intel.com>
Subject: Re: [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD
	driver
Date: Sat, 2 Mar 2019 16:08:08 +0800
Message-ID: <20190302080808.GC100586@intel.com>
References: <20190301080947.91086-1-xiaolong.ye@intel.com>
 <20190301080947.91086-2-xiaolong.ye@intel.com>
 <20190301103125.7f6f6b7e@shemminger-XPS-13-9360>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id CA7082C38
 for <dev@dpdk.org>; Sat,  2 Mar 2019 09:10:59 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20190301103125.7f6f6b7e@shemminger-XPS-13-9360>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

On 03/01, Stephen Hemminger wrote:
>On Fri,  1 Mar 2019 16:09:42 +0800
>Xiaolong Ye <xiaolong.ye@intel.com> wrote:
>
>> +	if (umem->buffer)
>> +		free(umem->buffer);
>
>Minor nit: you don't need to check for NULL free() already handles this.

Thanks for the suggestion, will change accordingly.