From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19A14C43381 for ; Sat, 2 Mar 2019 19:48:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CBF22205C9 for ; Sat, 2 Mar 2019 19:48:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="lCgsZO8a" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726654AbfCBTsw (ORCPT ); Sat, 2 Mar 2019 14:48:52 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:34140 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726529AbfCBTsw (ORCPT ); Sat, 2 Mar 2019 14:48:52 -0500 Received: by mail-pf1-f193.google.com with SMTP id u9so557729pfn.1 for ; Sat, 02 Mar 2019 11:48:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=mmT4edBs2JUWYgfOtOXis1GKz6sNVSvODRGHr5BuK8w=; b=lCgsZO8a12qkW0H4IVmpL82jGGdPp7NW+xfjVrl7QKmj7GNnFl92EKwCHSh6eiTy9g 75RBl3aXWrWDjh4jP6ldQPkykv2T66ZXvNEFipL43DNbkypjTUhYWh5bxD7u1FyU5zVG 9B9eTRJrKaUXycONdV0s+CP+qcQirGQnmq21zCWDERMBz3B89EXvxNVUcycs+kUF1Ojf pDFhrVuZby25EL1N9eEFjvD6AXv2r0fxA/ba7v2Hy26+ODj/i6EoS/btLilpJZBS3dp6 I0YVSzcRZj3pE6fcMOCUUUQgOgtkIZh+K6LFiCI1Xnc5u5vC9hXsl22fWIh1gGSov7mv yaeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=mmT4edBs2JUWYgfOtOXis1GKz6sNVSvODRGHr5BuK8w=; b=q8mjRTfIGAhDTE+IW6DdC2JUx03vGWlBqbniARMYc+anTLmLaqc3ij9vj3LKEFe6fo 2gns72eATE2Qf86iei3ji/fvZnYgj9b7TgBvuXugS4TfKnoVxzVFIOYV8AxRt2VMtMVr nu5MiS0wZOC1pKstGYHcyQvH1NMljfXfC0j3aE05Vt1RqHyDNsMD82nH8lMT9WQRrL7u IIkoViYo3j6QQJQLoyLAkgzg9BLxU8ptxFzd6ncK52pVMgk+PfH6n36HG5/E4zbiQV36 gINQ9u10gFD3avi72ZZq5kKtliLxRu7ZEPHNughwSsYhlixHD5JmQTloFjxgIoQ4aejd 5y9w== X-Gm-Message-State: APjAAAVJ3buPwtGH55/Y9ZDmC/3a2qbRvNgCdk5d7K+ZIq4tDtDAWwvH GEk30S+m0fOkw612ptKfaSToLA== X-Google-Smtp-Source: APXvYqybrZuys9YeFyI1aEz2PoTE4b5M0kAWKppgTjZRumF0NbUrKcLHu7zqtUY+m0wLLmYkIEZYrA== X-Received: by 2002:a65:664d:: with SMTP id z13mr10955849pgv.389.1551556131186; Sat, 02 Mar 2019 11:48:51 -0800 (PST) Received: from cakuba.netronome.com ([2601:646:8e00:1b7a::2]) by smtp.gmail.com with ESMTPSA id c127sm2767542pfg.133.2019.03.02.11.48.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 02 Mar 2019 11:48:51 -0800 (PST) Date: Sat, 2 Mar 2019 11:48:47 -0800 From: Jakub Kicinski To: Jiri Pirko Cc: davem@davemloft.net, netdev@vger.kernel.org, oss-drivers@netronome.com Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports Message-ID: <20190302114847.733759a1@cakuba.netronome.com> In-Reply-To: <20190302094116.GQ2314@nanopsycho> References: <20190301180453.17778-1-jakub.kicinski@netronome.com> <20190301180453.17778-5-jakub.kicinski@netronome.com> <20190302094116.GQ2314@nanopsycho> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, 2 Mar 2019 10:41:16 +0100, Jiri Pirko wrote: > Fri, Mar 01, 2019 at 07:04:50PM CET, jakub.kicinski@netronome.com wrote: > >PCI endpoint corresponds to a PCI device, but such device > >can have one more more logical device ports associated with it. > >We need a way to distinguish those. Add a PCI subport in the > >dumps and print the info in phys_port_name appropriately. > > > >This is not equivalent to port splitting, there is no split > >group. It's just a way of representing multiple netdevs on > >a single PCI function. > > > >Note that the quality of being multiport pertains only to > >the PCI function itself. A PF having multiple netdevs does > >not mean that its VFs will also have multiple, or that VFs > >are associated with any particular port of a multiport VF. > > > >Example (bus 05 device has subports, bus 82 has only one port per > >function): > > > >$ devlink port > >pci/0000:05:00.0/0: type eth netdev enp5s0np0 flavour physical > >pci/0000:05:00.0/10000: type eth netdev enp5s0npf0s0 flavour pci_pf pf 0 subport 0 > >pci/0000:05:00.0/4: type eth netdev enp5s0np1 flavour physical > >pci/0000:05:00.0/11000: type eth netdev enp5s0npf0s1 flavour pci_pf pf 0 subport 1 > > So these subport devlink ports are eswitch ports for subports, right? > > Please see the following drawing: > > +---+ +---+ +---+ > pfsub| 5 | vf| 6 | | 7 |pfsub > +-+-+ +-+-+ +-+-+ > physical link <---------+ | | | > | | | | > | | | | > | | | | > +-+-+ +-+-+ +-+-+ +-+-+ > | 1 | | 2 | | 3 | | 4 | > +--+---+------+---+------+---+------+---+--+ > | physical pfsub vf pfsub | > | port port port port | > | | > | eswitch | > | | > | | > +------------------------------------------+ > > 1) pci/0000:05:00.0/0: type eth netdev enp5s0np0 flavour physical switch_id 00154d130d2f > 2) pci/0000:05:00.0/10000: type eth netdev enp5s0npf0s0 flavour pci_pf pf 0 subport 0 switch_id 00154d130d2f > 3) pci/0000:05:00.0/10001: type eth netdev enp5s0npf0vf0 flavour pci_vf pf 0 vf 0 switch_id 00154d130d2f > 4) pci/0000:05:00.0/10001: type eth netdev enp5s0npf0s1 flavour pci_pf pf 0 subport 1 switch_id 00154d130d2f > > This is basically what you have and I think we are in sync with that. > But what about 5,6,7? Should they have devlink port instances too? > > 5) pci/0000:05:00.0/1: type eth netdev enp5s0f0?? flavour ???? pf 0 subport 0 > 6) pci/0000:05:10.1/0: type eth netdev enp5s10f0 flavour ???? pf 0 vf 0 > 7) pci/0000:05:00.0/1: type eth netdev enp5s0f0?? flavour ???? pf 0 subport 1 > > These are the "peers". > I think that there could be flavours "pci_pf" and "pci_vf". Then the > "representors" (switch ports) could have flavours "pci_pf_port" and > "pci_vf_port" or something like that. User can see right away > that is not "PF" of "VF" but rather something "on the other end". > Note there is no "switch_id" for these devlink ports that tells the user > these devlink ports are not part of any switch. > What do you think? Hmmm.. Hm. Hm. To me its neat if the devlink instance matches an ASIC. I think it's kind of clear for people to understand what it stands for then. So if we wanted to do the above we'd have to make the switch_id the first class identifier for devlink instances, rather than the bus? But then VF instances don't have a switch ID so that doesn't work... I need to think about it. It's also kind of strange that we have to add the noun *port* to the flavour of... a port... So I would prefer not to have those showing up as ports. Can we invent a new command (say "partition"?) that'd take the bus info where the partition is to be spawned? My next goal is to find a way of grouping multiple bus devices under one "ASIC" (which is a devlink instance to me) so it can be understood easily how things are laid out when there is more than one PF connected to one host.