All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rohit Ashiwal <rohit.ashiwal265@gmail.com>
To: t.gummerer@gmail.com
Cc: Johannes.Schindelin@gmx.de, git@matthieu-moy.fr,
	git@vger.kernel.org, gitster@pobox.com, martin.agren@gmail.com,
	pclouds@gmail.com, peff@peff.net, rohit.ashiwal265@gmail.com,
	szeder.dev@gmail.com
Subject: [GSoC] Thanking
Date: Sat,  2 Mar 2019 21:51:09 +0530	[thread overview]
Message-ID: <20190302162109.11172-1-rohit.ashiwal265@gmail.com> (raw)
In-Reply-To: <20190302144647.GT6085@hank.intra.tgummerer.com>

Hey! Thomas

Thank you for replying over my woes.

>
> It is up to you how far you would like to go with this.  If you want
> to add the helper, to make further cleanups in t3600, I think that
> would be a good thing to do (after double checking that it would be
> useful in other test files as well), and should be done in a separate
> patch.  Then you can use it in the same patch as using the helpers for
> "test -f" etc.
>

I guess I should work on this one first. I checked and around 18 test
files use `test -s`, it will be useful nonetheless.

>
> Yes, I think it would be good to make those changes, to try and get
> this merged.  Having the microproject merged is not a requirement (its
> main purpose is to see how students communicate on the mailing list,
> and to get them familiar with the workflow ahead of GSoC), but it can
> be a nice achievement in itself.
>

Yes, it is a nice experience to interact with people who "run" git over
which most of the open source community depends for code sharing and
collaboration.

>
> That said, I would also encourage you to start thinking about a
> project proposal, as that is another important part that should be
> done for the application.
>

That is really encouraging, I'll try to finish my work as soon as
possible and work on the proposal side by side!

Thanks
Rohit


      reply	other threads:[~2019-03-02 16:21 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-26 13:42 [PATCH 0/1] [GSoC][PATCH] tests: replace test -(d|f) with test_path_is_(dir|file) Rohit Ashiwal via GitGitGadget
2019-02-26 13:42 ` [PATCH 1/1] tests: replace `test -(d|f)` " Rohit Ashiwal via GitGitGadget
2019-02-26 14:04   ` Duy Nguyen
2019-02-26 16:10     ` Do test-path_is_{file,dir,exists} make sense anymore with -x? Ævar Arnfjörð Bjarmason
2019-02-26 17:04       ` SZEDER Gábor
2019-02-26 17:43         ` Jeff King
2019-02-26 19:39           ` SZEDER Gábor
2019-02-26 21:01             ` Jeff King
2019-03-03 16:04               ` SZEDER Gábor
2019-03-05  4:55                 ` Jeff King
2019-03-04 14:36               ` SZEDER Gábor
2019-03-05  4:58                 ` Jeff King
2019-02-26 17:48         ` Matthieu Moy
2019-02-26 18:24           ` Jeff King
2019-02-26 17:35       ` Jeff King
2019-02-26 19:58         ` Johannes Schindelin
2019-02-26 21:02           ` Jeff King
2019-02-27 10:01       ` Duy Nguyen
2019-03-01  2:52       ` Junio C Hamano
2019-02-26 16:01   ` [PATCH 1/1] tests: replace `test -(d|f)` with test_path_is_(dir|file) Johannes Schindelin
2019-02-26 16:30   ` Martin Ågren
2019-02-26 18:29     ` Rohit Ashiwal
2019-02-26 19:52       ` Johannes Schindelin
2019-02-26 20:01         ` Rohit Ashiwal
2019-02-27  5:49           ` Martin Ågren
2019-02-26 14:26 ` [PATCH v2 0/1] [GSoC][PATCH] t3600: use test_path_is_dir and test_path_is_file Rohit Ashiwal via GitGitGadget
2019-02-26 14:26   ` [PATCH v2 1/1] " Rohit Ashiwal via GitGitGadget
2019-02-26 16:37     ` SZEDER Gábor
2019-02-26 18:40       ` Rohit Ashiwal
2019-02-26 20:02         ` Johannes Schindelin
2019-02-26 20:05           ` Rohit Ashiwal
2019-02-26 22:48   ` [PATCH v3 0/1] [GSoC][PATCH] t3600: use test_path_is_* helper functions Rohit Ashiwal via GitGitGadget
2019-02-26 22:48     ` [PATCH v3 1/1] t3600: use test_path_is_* functions Rohit Ashiwal via GitGitGadget
2019-02-27 10:12       ` Duy Nguyen
2019-02-28 10:26     ` [PATCH v4 0/1] [GSoC][PATCH] t3600: use test_path_is_* helper functions Rohit Ashiwal via GitGitGadget
2019-02-28 10:26       ` [PATCH v4 1/1] t3600: use test_path_is_* functions Rohit Ashiwal via GitGitGadget
2019-02-28 19:02         ` [GSoC] acknowledging mistakes Rohit Ashiwal
2019-03-01  2:51           ` Junio C Hamano
2019-03-01 13:13             ` Feeling confused a little bit Rohit Ashiwal
2019-03-02  4:24               ` Rafael Ascensão
2019-03-02 14:46               ` Thomas Gummerer
2019-03-02 16:21                 ` Rohit Ashiwal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190302162109.11172-1-rohit.ashiwal265@gmail.com \
    --to=rohit.ashiwal265@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@matthieu-moy.fr \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=martin.agren@gmail.com \
    --cc=pclouds@gmail.com \
    --cc=peff@peff.net \
    --cc=szeder.dev@gmail.com \
    --cc=t.gummerer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.