From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Marczykowski Subject: Re: [PATCH v4 5/6] xen/x86: add PHYSDEVOP_msi_set_enable Date: Sun, 3 Mar 2019 02:10:24 +0100 Message-ID: <20190303011024.GP19265@mail-itl> References: <5C767771020000780021AB12@prv1-mh.provo.novell.com> <20190227150508.GE19265@mail-itl> <5C77BEDD020000780021B030@prv1-mh.provo.novell.com> <20190228122546.GN5348@mail-itl> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4245175918429951801==" Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1h0FeC-00083r-CQ for xen-devel@lists.xenproject.org; Sun, 03 Mar 2019 01:10:32 +0000 In-Reply-To: <20190228122546.GN5348@mail-itl> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Jan Beulich Cc: Stefano Stabellini , Wei Liu , Konrad Rzeszutek Wilk , George Dunlap , Andrew Cooper , Ian Jackson , Tim Deegan , Julien Grall , xen-devel , Daniel de Graaf , Roger Pau Monne List-Id: xen-devel@lists.xenproject.org --===============4245175918429951801== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eAnxKwVhzStH6fSc" Content-Disposition: inline --eAnxKwVhzStH6fSc Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v4 5/6] xen/x86: add PHYSDEVOP_msi_set_enable On Thu, Feb 28, 2019 at 01:25:50PM +0100, Marek Marczykowski wrote: > On Thu, Feb 28, 2019 at 03:58:37AM -0700, Jan Beulich wrote: > > Another thing: You're also bypassing the MSI{,-X}-already-enabled > > checks that __pci_enable_msi{,x}() do, yet allowing to enable both > > on a device would be a security issue. >=20 > Ok. Hmm, could you explain more? Is that only the case when interrupt remapping is missing? --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? --eAnxKwVhzStH6fSc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAlx7KYEACgkQ24/THMrX 1yzGngf+KvgKaNtC0bzoV9zfSCGoQ7kYoYh/ZbPSEKbEgtF/q9Kl1lCzfOf9ResW G1YYcOZTqAdrErgxefwFgwwQKV2THVSyulJ/2LQBdPt7e4Zp6BCyOqBHThOVqy36 ss3Hhl/0T6uo1PZV2C5hcB6P8HK6YAFbIZoyV12XKe/JhYzgitO44b1bTT3gAi1t XSfGA2lr316mmXNWSJ937Xt5RbYmKnnxODxzDTFtv0wC9+CM+kVccP3odfhBnVjV RP9fuMMlqMsrwYvBJH+/aUWddQVLduVael2zVAhaXRsf3+yas0/nqqsIiqQnEAn8 /IryHrvhlM6uOB+gH5CsXVvaqGJCHA== =juw4 -----END PGP SIGNATURE----- --eAnxKwVhzStH6fSc-- --===============4245175918429951801== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0 cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== --===============4245175918429951801==--