From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 861E4C4360F for ; Sun, 3 Mar 2019 21:11:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E73420830 for ; Sun, 3 Mar 2019 21:11:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726631AbfCCVLN (ORCPT ); Sun, 3 Mar 2019 16:11:13 -0500 Received: from ipmail01.adl6.internode.on.net ([150.101.137.136]:45204 "EHLO ipmail01.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726626AbfCCVLN (ORCPT ); Sun, 3 Mar 2019 16:11:13 -0500 Received: from ppp59-167-129-252.static.internode.on.net (HELO dastard) ([59.167.129.252]) by ipmail01.adl6.internode.on.net with ESMTP; 04 Mar 2019 07:41:03 +1030 Received: from dave by dastard with local (Exim 4.80) (envelope-from ) id 1h0YNy-0005SF-Lt; Mon, 04 Mar 2019 08:11:02 +1100 Date: Mon, 4 Mar 2019 08:11:02 +1100 From: Dave Chinner To: Wang Shilong Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, lixi@ddn.com, adilger@dilger.ca, Wang Shilong Subject: Re: [PATCH 0/8] add generic interface to set/get project Message-ID: <20190303211102.GP23020@dastard> References: <1551449141-7884-1-git-send-email-wshilong1991@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1551449141-7884-1-git-send-email-wshilong1991@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, Mar 01, 2019 at 11:05:33PM +0900, Wang Shilong wrote: > From: Wang Shilong > > Currently, Filesystem use FS_IOC_FS_SETXATTR ioctl > to change project ID of file. However we don't > support ioctl on symlink files, and it is desirable > to change symlink files' project ID just like uid/gid. > > This patch try to reuse existed interface fchownat(), > use group id to set project ID if flag AT_FCHOWN_PROJID > passed in. > > Also extend statx() calles to get symlink files' project > ID and inherit attribute. I'll mention the generic book-keeping stuff here: - Series needs to be cc'd to linux-api@vger.kernel.org - commit messages should be formatted similar to email. i.e. line wrap at 68-72 columns, not 50 - all of the patches have duplicate "From:" lines in the commit message. - most of the patches are missing commit messages. Cheers, Dave. -- Dave Chinner david@fromorbit.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH 0/8] add generic interface to set/get project Date: Mon, 4 Mar 2019 08:11:02 +1100 Message-ID: <20190303211102.GP23020@dastard> References: <1551449141-7884-1-git-send-email-wshilong1991@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1h0YOG-0002UC-54 for linux-f2fs-devel@lists.sourceforge.net; Sun, 03 Mar 2019 21:11:20 +0000 Received: from ipmail01.adl6.internode.on.net ([150.101.137.136]) by sfi-mx-1.v28.lw.sourceforge.com with esmtp (Exim 4.90_1) id 1h0YOE-0025iW-32 for linux-f2fs-devel@lists.sourceforge.net; Sun, 03 Mar 2019 21:11:20 +0000 Content-Disposition: inline In-Reply-To: <1551449141-7884-1-git-send-email-wshilong1991@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Wang Shilong Cc: adilger@dilger.ca, Wang Shilong , lixi@ddn.com, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org On Fri, Mar 01, 2019 at 11:05:33PM +0900, Wang Shilong wrote: > From: Wang Shilong > > Currently, Filesystem use FS_IOC_FS_SETXATTR ioctl > to change project ID of file. However we don't > support ioctl on symlink files, and it is desirable > to change symlink files' project ID just like uid/gid. > > This patch try to reuse existed interface fchownat(), > use group id to set project ID if flag AT_FCHOWN_PROJID > passed in. > > Also extend statx() calles to get symlink files' project > ID and inherit attribute. I'll mention the generic book-keeping stuff here: - Series needs to be cc'd to linux-api@vger.kernel.org - commit messages should be formatted similar to email. i.e. line wrap at 68-72 columns, not 50 - all of the patches have duplicate "From:" lines in the commit message. - most of the patches are missing commit messages. Cheers, Dave. -- Dave Chinner david@fromorbit.com