From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Sun, 3 Mar 2019 23:18:18 +0100 Subject: [U-Boot] [PATCH 1/2] net: dm: fec: Support phy-reset-post-delay property In-Reply-To: <20190301132755.947-2-andrejs.cainikovs@netmodule.com> References: <20190301132755.947-1-andrejs.cainikovs@netmodule.com> <20190301132755.947-2-andrejs.cainikovs@netmodule.com> Message-ID: <20190303231818.35a9fb84@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Andrejs, > As per Linux kernel DT binding doc: > - phy-reset-post-delay : Post reset delay in milliseconds. If present > then a delay of phy-reset-post-delay milliseconds will be observed > after the phy-reset-gpios has been toggled. Can be omitted thus no > delay is observed. Delay is in range of 1ms to 1000ms. Other delays > are invalid. > > Signed-off-by: Andrejs Cainikovs > --- > drivers/net/fec_mxc.c | 11 +++++++++++ > drivers/net/fec_mxc.h | 1 + > 2 files changed, 12 insertions(+) > > diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c > index a14fe43a5b..7fc95fa767 100644 > --- a/drivers/net/fec_mxc.c > +++ b/drivers/net/fec_mxc.c > @@ -1315,6 +1315,8 @@ static void fec_gpio_reset(struct fec_priv > *priv) dm_gpio_set_value(&priv->phy_reset_gpio, 1); > mdelay(priv->reset_delay); > dm_gpio_set_value(&priv->phy_reset_gpio, 0); > + if (priv->reset_post_delay) > + mdelay(priv->reset_post_delay); > } > } > #endif > @@ -1474,6 +1476,15 @@ static int fecmxc_ofdata_to_platdata(struct > udevice *dev) /* property value wrong, use default value */ > priv->reset_delay = 1; > } > + > + priv->reset_post_delay = dev_read_u32_default(dev, > + > "phy-reset-post-delay", > + 0); > + if (priv->reset_post_delay > 1000) { > + printf("FEC MXC: phy reset post delay should be <= > 1000ms\n"); > + /* property value wrong, use default value */ > + priv->reset_post_delay = 0; > + } > #endif > > return 0; > diff --git a/drivers/net/fec_mxc.h b/drivers/net/fec_mxc.h > index e9a661f0a1..e5f2dd75c5 100644 > --- a/drivers/net/fec_mxc.h > +++ b/drivers/net/fec_mxc.h > @@ -258,6 +258,7 @@ struct fec_priv { > #ifdef CONFIG_DM_GPIO > struct gpio_desc phy_reset_gpio; > uint32_t reset_delay; > + uint32_t reset_post_delay; > #endif > #ifdef CONFIG_DM_ETH > u32 interface; Acked-by: Lukasz Majewski (as I had similar patch somewhere .... to fix this issue on IMX6Q). Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: