All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chao Fan <fanc.fnst@cn.fujitsu.com>
To: Louis Taylor <louis@kragniz.eu>
Cc: <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
	<hpa@zytor.com>, <x86@kernel.org>, <bhe@redhat.com>,
	<kirill.shutemov@linux.intel.com>, <linux-kernel@vger.kernel.org>,
	<clang-built-linux@googlegroups.com>, <ndesaulniers@google.com>,
	<jflat@chromium.org>
Subject: Re: [PATCH] x86/KASLR: always return a value from process_mem_region
Date: Mon, 4 Mar 2019 09:20:58 +0800	[thread overview]
Message-ID: <20190304012058.GA28322@localhost.localdomain> (raw)
In-Reply-To: <20190302184929.28971-1-louis@kragniz.eu>

On Sat, Mar 02, 2019 at 06:49:29PM +0000, Louis Taylor wrote:
>When compiling with -Wreturn-type, clang warns:
>
>arch/x86/boot/compressed/kaslr.c:704:1: warning: control may reach end of
>      non-void function [-Wreturn-type]
>
>This function's return statement should probably have been placed
>outside the #endif, so move it there
>
>Link: https://github.com/ClangBuiltLinux/linux/issues/360
>Signed-off-by: Louis Taylor <louis@kragniz.eu>
>---
> arch/x86/boot/compressed/kaslr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/arch/x86/boot/compressed/kaslr.c b/arch/x86/boot/compressed/kaslr.c
>index fa0332dda9f2..2e53c056ba20 100644
>--- a/arch/x86/boot/compressed/kaslr.c
>+++ b/arch/x86/boot/compressed/kaslr.c
>@@ -697,8 +697,8 @@ static bool process_mem_region(struct mem_vector *region,
> 			return 1;
> 		}
> 	}
>-	return 0;
> #endif
>+	return 0;

Make sense, thanks for your PATCH.

Thanks,
Chao Fan

> }
> 
> #ifdef CONFIG_EFI
>-- 
>2.20.1
>
>
>



  parent reply	other threads:[~2019-03-04  1:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-02 18:49 [PATCH] x86/KASLR: always return a value from process_mem_region Louis Taylor
2019-03-03  3:04 ` Nathan Chancellor
2019-03-04  1:20 ` Chao Fan [this message]
2019-03-04 18:10 ` Nick Desaulniers
2019-03-06 20:02 ` Thomas Gleixner
2019-03-06 20:13   ` Thomas Gleixner
2019-03-06 20:37   ` Louis Taylor
2019-03-06 21:37     ` Nick Desaulniers
2019-03-06 21:57       ` Thomas Gleixner
2019-03-06 20:34 ` [tip:x86/boot] x86/boot/KASLR: Always " tip-bot for Louis Taylor
2019-03-06 21:55 ` tip-bot for Louis Taylor
2019-03-06 21:58 ` tip-bot for Louis Taylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190304012058.GA28322@localhost.localdomain \
    --to=fanc.fnst@cn.fujitsu.com \
    --cc=bhe@redhat.com \
    --cc=bp@alien8.de \
    --cc=clang-built-linux@googlegroups.com \
    --cc=hpa@zytor.com \
    --cc=jflat@chromium.org \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=louis@kragniz.eu \
    --cc=mingo@redhat.com \
    --cc=ndesaulniers@google.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.