From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FC0FC43381 for ; Tue, 5 Mar 2019 00:33:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0D390206B6 for ; Tue, 5 Mar 2019 00:33:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="CKfTKqBH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726190AbfCEAdL (ORCPT ); Mon, 4 Mar 2019 19:33:11 -0500 Received: from mail-qk1-f196.google.com ([209.85.222.196]:43844 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726080AbfCEAdK (ORCPT ); Mon, 4 Mar 2019 19:33:10 -0500 Received: by mail-qk1-f196.google.com with SMTP id f196so3883624qke.10 for ; Mon, 04 Mar 2019 16:33:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=OAbjSvyxaW+Zeuzwb7QWUDLdGcRValBYpkDW98PUJgI=; b=CKfTKqBHnXsunLAIut73eQvwF1H3y4FQpSXPLlKj3AyTCA/CtG3Sc9XI6ZqWy59JTY /mrcK/LVjUD/SgfNfihsurTyq7CCXcHHIpz4SKCFqce18A2ztPxF5fPWK5LpUgrH21Zn BumsNauwlfhURjs+fRicKOWx7f2hqfyvO6QHzW0lOcIYYHwYQ9NVtdsHE2nHhyxrjGr6 nuS5N3HUKs9WPo/rkq4wobnA7fslJvD3TmfTZUkSSUj3QVDfmBpY03LEWuuqEwmvnrYv F73/osztBvZDuL7wfwlenZdIX/d7pf4MB6e7Gp/ScbuGYVQ5wravDmjdLd0Lsyl505M8 CEZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=OAbjSvyxaW+Zeuzwb7QWUDLdGcRValBYpkDW98PUJgI=; b=ZkYab4wpZKxQYclNfhylKleOpx4NKHIN4sVfiFe6sy47H6FSSQZPQLvY1gIWCb80Tw bdliAP4+VuySjXzqrzCyUnQqr6bt7+j5lX/k2zcosl5GwnJ46NY8WB9t/82hWURbCm8F IHnUk2AXos9lrGX/Cb/2XckHkAfHLaSSbAxmOkqyxKfUwnq6QYR9C9bck+gLfhAIo0vM 5iGUtG/a8yQC3pfioG+I5yDNfD5n5zBDaMpNRQF74u16NH7G6QB82KpBBiQARe1rTsn1 LYhyzdsgiHdxUd9Yn0mRLpcvnWAg4zisgvpr/qPyVAk+ma8P0HK5u077IVcpGsryLBIp btUw== X-Gm-Message-State: APjAAAWK1xWl4MVSJ2FmYReangfIAskcmjWDmhhaYu+EModDWeIsiP0R YCsN5XRym8YhUyFZriW0OWEH/TLVaBI= X-Google-Smtp-Source: APXvYqzNbJn76Ci/VmSJBfP1DUTLbnuUIfJJ7f3vu/6oK2dzOdoq28WpFEzRLTzgx9ve9e0SYzyb+Q== X-Received: by 2002:a37:d9cb:: with SMTP id q72mr14900668qkl.143.1551745989284; Mon, 04 Mar 2019 16:33:09 -0800 (PST) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id c73sm7063507qka.37.2019.03.04.16.33.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Mar 2019 16:33:09 -0800 (PST) Date: Mon, 4 Mar 2019 16:33:02 -0800 From: Jakub Kicinski To: Jiri Pirko Cc: davem@davemloft.net, netdev@vger.kernel.org, oss-drivers@netronome.com Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports Message-ID: <20190304163302.7e40219e@cakuba.netronome.com> In-Reply-To: <20190304075609.GV2314@nanopsycho> References: <20190301180453.17778-1-jakub.kicinski@netronome.com> <20190301180453.17778-5-jakub.kicinski@netronome.com> <20190302094116.GQ2314@nanopsycho> <20190302114847.733759a1@cakuba.netronome.com> <20190304075609.GV2314@nanopsycho> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 4 Mar 2019 08:56:09 +0100, Jiri Pirko wrote: > Sat, Mar 02, 2019 at 08:48:47PM CET, jakub.kicinski@netronome.com wrote: > >On Sat, 2 Mar 2019 10:41:16 +0100, Jiri Pirko wrote: > >> Fri, Mar 01, 2019 at 07:04:50PM CET, jakub.kicinski@netronome.com wrote: > >> >PCI endpoint corresponds to a PCI device, but such device > >> >can have one more more logical device ports associated with it. > >> >We need a way to distinguish those. Add a PCI subport in the > >> >dumps and print the info in phys_port_name appropriately. > >> > > >> >This is not equivalent to port splitting, there is no split > >> >group. It's just a way of representing multiple netdevs on > >> >a single PCI function. > >> > > >> >Note that the quality of being multiport pertains only to > >> >the PCI function itself. A PF having multiple netdevs does > >> >not mean that its VFs will also have multiple, or that VFs > >> >are associated with any particular port of a multiport VF. > >> > > >> >Example (bus 05 device has subports, bus 82 has only one port per > >> >function): > >> > > >> >$ devlink port > >> >pci/0000:05:00.0/0: type eth netdev enp5s0np0 flavour physical > >> >pci/0000:05:00.0/10000: type eth netdev enp5s0npf0s0 flavour pci_pf pf 0 subport 0 > >> >pci/0000:05:00.0/4: type eth netdev enp5s0np1 flavour physical > >> >pci/0000:05:00.0/11000: type eth netdev enp5s0npf0s1 flavour pci_pf pf 0 subport 1 > >> > >> So these subport devlink ports are eswitch ports for subports, right? > >> > >> Please see the following drawing: > >> > >> +---+ +---+ +---+ > >> pfsub| 5 | vf| 6 | | 7 |pfsub > >> +-+-+ +-+-+ +-+-+ > >> physical link <---------+ | | | > >> | | | | > >> | | | | > >> | | | | > >> +-+-+ +-+-+ +-+-+ +-+-+ > >> | 1 | | 2 | | 3 | | 4 | > >> +--+---+------+---+------+---+------+---+--+ > >> | physical pfsub vf pfsub | > >> | port port port port | > >> | | > >> | eswitch | > >> | | > >> | | > >> +------------------------------------------+ > >> > >> 1) pci/0000:05:00.0/0: type eth netdev enp5s0np0 flavour physical switch_id 00154d130d2f > >> 2) pci/0000:05:00.0/10000: type eth netdev enp5s0npf0s0 flavour pci_pf pf 0 subport 0 switch_id 00154d130d2f > >> 3) pci/0000:05:00.0/10001: type eth netdev enp5s0npf0vf0 flavour pci_vf pf 0 vf 0 switch_id 00154d130d2f > >> 4) pci/0000:05:00.0/10001: type eth netdev enp5s0npf0s1 flavour pci_pf pf 0 subport 1 switch_id 00154d130d2f > >> > >> This is basically what you have and I think we are in sync with that. > >> But what about 5,6,7? Should they have devlink port instances too? > >> > >> 5) pci/0000:05:00.0/1: type eth netdev enp5s0f0?? flavour ???? pf 0 subport 0 > >> 6) pci/0000:05:10.1/0: type eth netdev enp5s10f0 flavour ???? pf 0 vf 0 > >> 7) pci/0000:05:00.0/1: type eth netdev enp5s0f0?? flavour ???? pf 0 subport 1 > >> > >> These are the "peers". > >> I think that there could be flavours "pci_pf" and "pci_vf". Then the > >> "representors" (switch ports) could have flavours "pci_pf_port" and > >> "pci_vf_port" or something like that. User can see right away > >> that is not "PF" of "VF" but rather something "on the other end". > >> Note there is no "switch_id" for these devlink ports that tells the user > >> these devlink ports are not part of any switch. > >> What do you think? > > > >Hmmm.. Hm. Hm. > > > >To me its neat if the devlink instance matches an ASIC. I think it's > >kind of clear for people to understand what it stands for then. So if > >we wanted to do the above we'd have to make the switch_id the first > >class identifier for devlink instances, rather than the bus? But then > > What do you mean by "first class identifier"? Like "a handle"? Yes, a handle. > >VF instances don't have a switch ID so that doesn't work... > > Wait a sec. VF-ports do have. VFs them selves don't. Looking at your example this one: 6) pci/0000:05:10.1/0: type eth netdev enp5s10f0 flavour ???? pf 0 vf 0 that uses VF's DBDF in the devlink instance handle, so I presume this is a VF's devlink instance that will get passed to the VM together with the VF device? > But that is the same for PF. PF would also not have switch id. Yes :( You'd have to mark what constitutes a devlink instance on your drawing. The semantics for devlink instances seem to be the focal point of the discussion. Right now it seems a little bit that folks on the NIC side see a devlink instance as a PCI function and on switch side it's the whole ASIC. > >I need to think about it. > > > >It's also kind of strange that we have to add the noun *port* to the > >flavour of... a port... So I would prefer not to have those showing up > > Yeah. > > >as ports. Can we invent a new command (say "partition"?) that'd take > >the bus info where the partition is to be spawned? > > Got it. But the question is how different this object would be from the > existing "port" we have today. They'd be where "the other side of a PCI link" is represented, restricting ports to only ASIC's forwarding plane ports. > >My next goal is to find a way of grouping multiple bus devices under one > >"ASIC" (which is a devlink instance to me) so it can be understood > >easily how things are laid out when there is more than one PF connected > >to one host. > > These are the "aliases" you mentioned before right? Makes sense. Yes.