* [PATCH] Add brackets around parameter
@ 2019-03-04 16:44 Nishka Dasgupta
0 siblings, 0 replies; 2+ messages in thread
From: Nishka Dasgupta @ 2019-03-04 16:44 UTC (permalink / raw)
To: gregkh, outreachy-kernel; +Cc: Nishka Dasgupta
Add brackets around macro parameter to avoid confusion. Issue detected
by Checkpatch.
Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
---
drivers/staging/gdm724x/netlink_k.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/gdm724x/netlink_k.c b/drivers/staging/gdm724x/netlink_k.c
index 92440c3f055b..36d88f49c922 100644
--- a/drivers/staging/gdm724x/netlink_k.c
+++ b/drivers/staging/gdm724x/netlink_k.c
@@ -19,8 +19,8 @@ static DEFINE_MUTEX(netlink_mutex);
#define ND_NLMSG_SPACE(len) (NLMSG_SPACE(len) + ND_IFINDEX_LEN)
#define ND_NLMSG_DATA(nlh) ((void *)((char *)NLMSG_DATA(nlh) + \
ND_IFINDEX_LEN))
-#define ND_NLMSG_S_LEN(len) (len + ND_IFINDEX_LEN)
-#define ND_NLMSG_R_LEN(nlh) (nlh->nlmsg_len - ND_IFINDEX_LEN)
+#define ND_NLMSG_S_LEN(len) ((len) + ND_IFINDEX_LEN)
+#define ND_NLMSG_R_LEN(nlh) ((nlh)->nlmsg_len - ND_IFINDEX_LEN)
#define ND_NLMSG_IFIDX(nlh) NLMSG_DATA(nlh)
#define ND_MAX_MSG_LEN (1024 * 32)
--
2.19.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] Add brackets around parameter
@ 2019-03-04 16:41 Nishka Dasgupta
0 siblings, 0 replies; 2+ messages in thread
From: Nishka Dasgupta @ 2019-03-04 16:41 UTC (permalink / raw)
To: gregkh, outreachy-kernel; +Cc: Nishka Dasgupta
Add brackets around macro parameter gdm to avoid confusion. Issue
detected by Checkpatch.
Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
---
drivers/staging/gdm724x/gdm_tty.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
index 6e813693a766..eab5c75ee5b1 100644
--- a/drivers/staging/gdm724x/gdm_tty.c
+++ b/drivers/staging/gdm724x/gdm_tty.c
@@ -27,7 +27,7 @@
#define MUX_TX_MAX_SIZE 2048
-#define GDM_TTY_READY(gdm) (gdm && gdm->tty_dev && gdm->port.count)
+#define GDM_TTY_READY(gdm) ((gdm) && (gdm)->tty_dev && (gdm)->port.count)
static struct tty_driver *gdm_driver[TTY_MAX_COUNT];
static struct gdm *gdm_table[TTY_MAX_COUNT][GDM_TTY_MINOR];
--
2.19.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-04 17:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-04 16:44 [PATCH] Add brackets around parameter Nishka Dasgupta
-- strict thread matches above, loose matches on Subject: below --
2019-03-04 16:41 Nishka Dasgupta
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.