From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 4/5] drm/i915: Move rawclck, power_domain and irq un/initialization from modeset functions Date: Mon, 4 Mar 2019 19:34:23 +0200 Message-ID: <20190304173423.GD20097@intel.com> References: <20190302004935.28906-1-jose.souza@intel.com> <20190302004935.28906-4-jose.souza@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9B89D89CF8 for ; Mon, 4 Mar 2019 17:34:27 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190302004935.28906-4-jose.souza@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?iso-8859-1?Q?Jos=E9?= Roberto de Souza Cc: Jani Nikula , intel-gfx@lists.freedesktop.org, Lucas De Marchi List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBNYXIgMDEsIDIwMTkgYXQgMDQ6NDk6MzRQTSAtMDgwMCwgSm9zw6kgUm9iZXJ0byBk ZSBTb3V6YSB3cm90ZToKPiBUaGUgaW5pdGlhbGl6YXRpb24gb2YgdGhvc2UgY29tcG9uZW50ZXMg aXMgcmVxdWlyZWQgYnkgdGhlIEdFTS9HVCBub3QKPiBvbmx5IGRpc3BsYXkgc28gbGV0cyBtb3Zl IHRoZW4gdG8gYSBtb3JlIHRoZSBhcHByb3ByaWF0ZSBwbGFjZS4KPiAKPiBDYzogTHVjYXMgRGUg TWFyY2hpIDxsdWNhcy5kZW1hcmNoaUBpbnRlbC5jb20+Cj4gQ2M6IEphbmkgTmlrdWxhIDxqYW5p Lm5pa3VsYUBpbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogSm9zw6kgUm9iZXJ0byBkZSBTb3V6 YSA8am9zZS5zb3V6YUBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZHJ2LmMgICAgICB8IDM5ICsrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0KPiAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgIDcgLS0tLS0KPiAgMiBmaWxlcyBjaGFu Z2VkLCAyMyBpbnNlcnRpb25zKCspLCAyMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZHJ2LmMKPiBpbmRleCBjYzA3MjU5ZWM5NDYuLjJiNWNlNzY0ZTY5NCAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9kcnYuYwo+IEBAIC02OTEsMjQgKzY5MSwxNSBAQCBzdGF0aWMgaW50IGk5MTVf bW9kZXNldF9sb2FkKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gIAlpZiAocmV0KQo+ICAJCWdv dG8gY2xlYW51cF92Z2FfY2xpZW50Owo+ICAKPiAtCS8qIG11c3QgaGFwcGVuIGJlZm9yZSBpbnRl bF9wb3dlcl9kb21haW5zX2luaXRfaHcoKSBvbiBWTFYvQ0hWICovCj4gLQlpbnRlbF91cGRhdGVf cmF3Y2xrKGRldl9wcml2KTsKPiAtCj4gLQlpbnRlbF9wb3dlcl9kb21haW5zX2luaXRfaHcoZGV2 X3ByaXYsIGZhbHNlKTsKPiAtCj4gIAlpbnRlbF9jc3JfdWNvZGVfaW5pdChkZXZfcHJpdik7Cj4g IAo+IC0JcmV0ID0gaW50ZWxfaXJxX2luc3RhbGwoZGV2X3ByaXYpOwo+IC0JaWYgKHJldCkKPiAt CQlnb3RvIGNsZWFudXBfY3NyOwo+IC0KPiAgCWludGVsX3NldHVwX2dtYnVzKGRldl9wcml2KTsK PiAgCj4gIAkvKiBJbXBvcnRhbnQ6IFRoZSBvdXRwdXQgc2V0dXAgZnVuY3Rpb25zIGNhbGxlZCBi eSBtb2Rlc2V0X2luaXQgbmVlZAo+ICAJICogd29ya2luZyBpcnFzIGZvciBlLmcuIGdtYnVzIGFu ZCBkcCBhdXggdHJhbnNmZXJzLiAqLwo+ICAJcmV0ID0gaW50ZWxfbW9kZXNldF9pbml0KGRldik7 Cj4gIAlpZiAocmV0KQo+IC0JCWdvdG8gY2xlYW51cF9pcnE7Cj4gKwkJZ290byBjbGVhbnVwX2dt YnVzOwo+ICAKPiAgCXJldCA9IGk5MTVfZ2VtX2luaXQoZGV2X3ByaXYpOwo+ICAJaWYgKHJldCkK PiBAQCAtNzM2LDEyICs3MjcsOSBAQCBzdGF0aWMgaW50IGk5MTVfbW9kZXNldF9sb2FkKHN0cnVj dCBkcm1fZGV2aWNlICpkZXYpCj4gIAlpOTE1X2dlbV9maW5pKGRldl9wcml2KTsKPiAgY2xlYW51 cF9tb2Rlc2V0Ogo+ICAJaW50ZWxfbW9kZXNldF9jbGVhbnVwKGRldik7Cj4gLWNsZWFudXBfaXJx Ogo+IC0JZHJtX2lycV91bmluc3RhbGwoZGV2KTsKPiArY2xlYW51cF9nbWJ1czoKPiAgCWludGVs X3RlYXJkb3duX2dtYnVzKGRldl9wcml2KTsKPiAtY2xlYW51cF9jc3I6Cj4gIAlpbnRlbF9jc3Jf dWNvZGVfZmluaShkZXZfcHJpdik7Cj4gLQlpbnRlbF9wb3dlcl9kb21haW5zX2ZpbmlfaHcoZGV2 X3ByaXYpOwo+ICAJdmdhX3N3aXRjaGVyb29fdW5yZWdpc3Rlcl9jbGllbnQocGRldik7Cj4gIGNs ZWFudXBfdmdhX2NsaWVudDoKPiAgCXZnYV9jbGllbnRfcmVnaXN0ZXIocGRldiwgTlVMTCwgTlVM TCwgTlVMTCk7Cj4gQEAgLTE3NjUsOSArMTc1MywxOCBAQCBpbnQgaTkxNV9kcml2ZXJfbG9hZChz dHJ1Y3QgcGNpX2RldiAqcGRldiwgY29uc3Qgc3RydWN0IHBjaV9kZXZpY2VfaWQgKmVudCkKPiAg CWlmIChyZXQgPCAwKQo+ICAJCWdvdG8gb3V0X2NsZWFudXBfbW1pbzsKPiAgCj4gKwkvKiBtdXN0 IGhhcHBlbiBiZWZvcmUgaW50ZWxfcG93ZXJfZG9tYWluc19pbml0X2h3KCkgb24gVkxWL0NIViAq Lwo+ICsJaW50ZWxfdXBkYXRlX3Jhd2NsayhkZXZfcHJpdik7Cj4gKwo+ICsJaW50ZWxfcG93ZXJf ZG9tYWluc19pbml0X2h3KGRldl9wcml2LCBmYWxzZSk7Cj4gKwo+ICsJcmV0ID0gaW50ZWxfaXJx X2luc3RhbGwoZGV2X3ByaXYpOwo+ICsJaWYgKHJldCkKPiArCQlnb3RvIG91dF9jbGVhbnVwX3Bv d2VyOwoKV2hhdCBhcmUgdGhlIHN0ZXBzIHdlJ3JlIHJlb3JkZXJpbmcgd3J0LiBpcnEgZW5hYmxl IGFuZAp3aHkgaXMgaXQgT0sgdG8gcmVvcmRlciB0aGVtPwoKPiArCj4gIAlyZXQgPSBpOTE1X21v ZGVzZXRfbG9hZCgmZGV2X3ByaXYtPmRybSk7Cj4gIAlpZiAocmV0IDwgMCkKPiAtCQlnb3RvIG91 dF9jbGVhbnVwX2h3Owo+ICsJCWdvdG8gb3V0X2NsZWFudXBfaXJxOwo+ICAKPiAgCWk5MTVfZHJp dmVyX3JlZ2lzdGVyKGRldl9wcml2KTsKPiAgCj4gQEAgLTE3NzcsNyArMTc3NCwxMCBAQCBpbnQg aTkxNV9kcml2ZXJfbG9hZChzdHJ1Y3QgcGNpX2RldiAqcGRldiwgY29uc3Qgc3RydWN0IHBjaV9k ZXZpY2VfaWQgKmVudCkKPiAgCj4gIAlyZXR1cm4gMDsKPiAgCj4gLW91dF9jbGVhbnVwX2h3Ogo+ ICtvdXRfY2xlYW51cF9pcnE6Cj4gKwlkcm1faXJxX3VuaW5zdGFsbCgmZGV2X3ByaXYtPmRybSk7 Cj4gK291dF9jbGVhbnVwX3Bvd2VyOgo+ICsJaW50ZWxfcG93ZXJfZG9tYWluc19maW5pX2h3KGRl dl9wcml2KTsKPiAgCWk5MTVfZHJpdmVyX2NsZWFudXBfaHcoZGV2X3ByaXYpOwo+ICBvdXRfY2xl YW51cF9tbWlvOgo+ICAJaTkxNV9kcml2ZXJfY2xlYW51cF9tbWlvKGRldl9wcml2KTsKPiBAQCAt MTgxMCw2ICsxODEwLDEzIEBAIHZvaWQgaTkxNV9kcml2ZXJfdW5sb2FkKHN0cnVjdCBkcm1fZGV2 aWNlICpkZXYpCj4gIAo+ICAJaW50ZWxfZ3Z0X2NsZWFudXAoZGV2X3ByaXYpOwo+ICAKPiArCS8q Cj4gKwkgKiBJbnRlcnJ1cHRzIGFuZCBwb2xsaW5nIGFzIHRoZSBmaXJzdCB0aGluZyB0byBhdm9p ZCBjcmVhdGluZyBoYXZvYy4KPiArCSAqIFRvbyBtdWNoIHN0dWZmIGhlcmUgKHR1cm5pbmcgb2Yg Y29ubmVjdG9ycywgLi4uKSB3b3VsZAo+ICsJICogZXhwZXJpZW5jZSBmYW5jeSByYWNlcyBvdGhl cndpc2UuCj4gKwkgKi8KPiArCWludGVsX2lycV91bmluc3RhbGwoZGV2X3ByaXYpOwoKVGhpcyB0 b28gc2VlbXMgc2xpZ2h0bHkgcXVlc3Rpb25hYmxlIGNvbnNpZGVyaW5nIHRoZSBmbHVzaF93b3Jr cXVldWUoKQpldGMuIGluIGludGVsX21vZGVzZXRfY2xlYW51cCgpLiBDYW4gd2UgYmUgc3VyZSBh bGwgbW9kZXNldCBhY3Rpdml0eSBoYXMKaW4gZmFjdCBmaW5pc2hlZCBzdWZmaWNpZW50bHkgdG8g bm8gcmVxdWlyZSBpbnRlcnJ1cHRzPwoKPiArCj4gIAlpOTE1X21vZGVzZXRfdW5sb2FkKGRldik7 Cj4gIAo+ICAJLyogRnJlZSBlcnJvciBzdGF0ZSBhZnRlciBpbnRlcnJ1cHRzIGFyZSBmdWxseSBk aXNhYmxlZC4gKi8KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXggNzk2 MzM0OGYxYzY0Li41MTU4ZThlY2I5ZWQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jCj4gQEAgLTE2MzY0LDEzICsxNjM2NCw2IEBAIHZvaWQgaW50ZWxfbW9kZXNldF9jbGVh bnVwKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gIAlmbHVzaF93b3JrKCZkZXZfcHJpdi0+YXRv bWljX2hlbHBlci5mcmVlX3dvcmspOwo+ICAJV0FSTl9PTighbGxpc3RfZW1wdHkoJmRldl9wcml2 LT5hdG9taWNfaGVscGVyLmZyZWVfbGlzdCkpOwo+ICAKPiAtCS8qCj4gLQkgKiBJbnRlcnJ1cHRz IGFuZCBwb2xsaW5nIGFzIHRoZSBmaXJzdCB0aGluZyB0byBhdm9pZCBjcmVhdGluZyBoYXZvYy4K PiAtCSAqIFRvbyBtdWNoIHN0dWZmIGhlcmUgKHR1cm5pbmcgb2YgY29ubmVjdG9ycywgLi4uKSB3 b3VsZAo+IC0JICogZXhwZXJpZW5jZSBmYW5jeSByYWNlcyBvdGhlcndpc2UuCj4gLQkgKi8KPiAt CWludGVsX2lycV91bmluc3RhbGwoZGV2X3ByaXYpOwo+IC0KPiAgCS8qCj4gIAkgKiBEdWUgdG8g dGhlIGhwZCBpcnEgc3Rvcm0gaGFuZGxpbmcgdGhlIGhvdHBsdWcgd29yayBjYW4gcmUtYXJtIHRo ZQo+ICAJICogcG9sbCBoYW5kbGVycy4gSGVuY2UgZGlzYWJsZSBwb2xsaW5nIGFmdGVyIGhwZCBo YW5kbGluZyBpcyBzaHV0IGRvd24uCj4gLS0gCj4gMi4yMS4wCj4gCj4gX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0 Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKVmlsbGUgU3lyasOkbMOk CkludGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCklu dGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==