From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFF44C43381 for ; Mon, 4 Mar 2019 20:57:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 94E14206B6 for ; Mon, 4 Mar 2019 20:57:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=brauner.io header.i=@brauner.io header.b="YqpQ+fke" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726425AbfCDU5T (ORCPT ); Mon, 4 Mar 2019 15:57:19 -0500 Received: from mail-ed1-f68.google.com ([209.85.208.68]:38262 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726096AbfCDU5T (ORCPT ); Mon, 4 Mar 2019 15:57:19 -0500 Received: by mail-ed1-f68.google.com with SMTP id h58so5396684edb.5 for ; Mon, 04 Mar 2019 12:57:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brauner.io; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Lfs+edcsPqw9VdJpJJBfthDSqQJQ/Sz5ubtx/mb4vh0=; b=YqpQ+fkeYZyVDLUcP9Ep9pLbZ8qQy74vGru3GEz7x+EITVVUdssO7jIDOH/zHy7n7Y 6wrhYx/c7Neo0odFfr2hFEKokugCzaXJZbdU1EdaooE+mAg7RIqQKOC7a7/cUA26i5uV MXDr0Bxx2rYW8RYGbzOvCxbqVzm9O5BRIZ9jv0Xi3J2ZLteKK6zSz2mLcs4SIrlSlQPT cGX+1NWUHpYgU52cYTZ1RBM/kUReljre6WchYXdaYzPmUj7RQILGRmrVzpWdqQfWC/pg B3gZoIt2Xb8cRjmYtKJMkneWyY4F7tr+RlpgVmLYmqBZE+5dF2H7lFSleSkarykaaIad dUAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Lfs+edcsPqw9VdJpJJBfthDSqQJQ/Sz5ubtx/mb4vh0=; b=KnKTwUaKe3iVpkolxdH6eRq+eIGhGWsqZitV0Q+SDIS88AYfb4WsepV5krnZggn7aS Fr3teIio0nvGfpZVdYvDA/7N5ot2jeRKY5yL0BK7PaIz0unIw6yoMDl7h5IMfvGe7fn5 s2zQWcdtqxrbrhPuAuGOn2x24yU+ReEF9cu0Cyu0UbBVtYtEVxNE+dPFDFBtv69Aq9ov aJMimVV36q13C1LLo2+pETkJBGOCdLLLpV14vRljbEQ8yxMCKbFbZqy3lTU8JZ5EIVeo uX3mjh/6apGoe3fokcc+AU10uOirC19z2S4fcHrHu9EUsKpT6V/HmXwauwMKN7peTBMg +nJA== X-Gm-Message-State: APjAAAWjPUdiazJWbeBweqeTRikirjXFnSVrnGgpyeZaYPlIUpsGUeHc D0nDngYpD0cslZTN3rvlCgLHkw== X-Google-Smtp-Source: APXvYqxQfjzZvjgGr3Hbfl+w+e/Q1cgH44X+UrKJ/OKFJBx1Z/Or0s+H5GzLlu7uAMOVXQRdVCY29Q== X-Received: by 2002:a17:906:860e:: with SMTP id o14mr9242259ejx.202.1551733037325; Mon, 04 Mar 2019 12:57:17 -0800 (PST) Received: from brauner.io ([2a02:8109:b6c0:76e:3ddf:44fc:d22b:95ce]) by smtp.gmail.com with ESMTPSA id w31sm2397479edc.46.2019.03.04.12.57.15 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 04 Mar 2019 12:57:16 -0800 (PST) Date: Mon, 4 Mar 2019 21:57:15 +0100 From: Christian Brauner To: Arnd Bergmann Cc: Luis Chamberlain , Kees Cook , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrew Morton , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH] bpf: fix sysctl.c warning Message-ID: <20190304205714.rhpgpp26rbaghs2i@brauner.io> References: <20190304203443.1992942-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190304203443.1992942-1-arnd@arndb.de> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 04, 2019 at 09:34:12PM +0100, Arnd Bergmann wrote: > When CONFIG_BPF_SYSCALL or CONFIG_SYSCTL is disabled, we get > a warning about an unused function: > > kernel/sysctl.c:3331:12: error: 'proc_dointvec_minmax_bpf_stats' defined but not used [-Werror=unused-function] > static int proc_dointvec_minmax_bpf_stats(struct ctl_table *table, int write, > > The CONFIG_BPF_SYSCALL check was already handled, but the SYSCTL check > is needed on top. > > Fixes: 492ecee892c2 ("bpf: enable program stats") > Signed-off-by: Arnd Bergmann Reviewed-by: Christian Brauner > --- > kernel/sysctl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/sysctl.c b/kernel/sysctl.c > index 46a0d0a14a66..b3df3ab7ac28 100644 > --- a/kernel/sysctl.c > +++ b/kernel/sysctl.c > @@ -3330,7 +3330,7 @@ int proc_doulongvec_ms_jiffies_minmax(struct ctl_table *table, int write, > > #endif /* CONFIG_PROC_SYSCTL */ > > -#ifdef CONFIG_BPF_SYSCALL > +#if defined(CONFIG_BPF_SYSCALL) && defined(CONFIG_SYSCTL) > static int proc_dointvec_minmax_bpf_stats(struct ctl_table *table, int write, > void __user *buffer, size_t *lenp, > loff_t *ppos) > -- > 2.20.0 >